You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by tedxia <gi...@git.apache.org> on 2014/12/29 10:13:08 UTC

[GitHub] storm pull request: STORM-613: Fix wrong getOffset return value

GitHub user tedxia opened a pull request:

    https://github.com/apache/storm/pull/369

    STORM-613: Fix wrong getOffset return value

    When judge getOffset return value, use 0 not NO_OFFSET as invalid offset return value.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tedxia/incubator-storm fix-wrong-getOffset-return-value

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/369.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #369
    
----
commit 895096de35811d0fa5158e550d49d8cdbc497ca0
Author: xiajun <xi...@xiaomi.com>
Date:   2014-12-29T08:52:35Z

    Fix wrong getOffset return value

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-613: Fix wrong getOffset return value

Posted by harshach <gi...@git.apache.org>.

Github user harshach commented on the pull request:

    https://github.com/apache/storm/pull/369#issuecomment-68267623
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-613: Fix wrong getOffset return value

Posted by revans2 <gi...@git.apache.org>.

Github user revans2 commented on the pull request:

    https://github.com/apache/storm/pull/369#issuecomment-68886875
  
    +1 looks fine to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-613: Fix wrong getOffset return value

Posted by Parth-Brahmbhatt <gi...@git.apache.org>.

Github user Parth-Brahmbhatt commented on the pull request:

    https://github.com/apache/storm/pull/369#issuecomment-68314022
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-613: Fix wrong getOffset return value

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/369


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---