You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/04/10 04:06:34 UTC
[GitHub] [cordova-android] erisu opened a new pull request #1198: feat!: upgrade android gradle plugin@4.1.3
erisu opened a new pull request #1198:
URL: https://github.com/apache/cordova-android/pull/1198
### Motivation, Context & Description
* Reintroduces changes that were reverted to not cause issues with 9.1.0 release.
* Changes were cherry-picked to retain original author.
* Original PR Work:
* https://github.com/apache/cordova-android/pull/1079
* https://github.com/apache/cordova-android/pull/1175
* Upgrades Android Gradle Plugin to 4.1.3
**PR is based off PR #1197 and should be rebased after merged.**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io commented on pull request #1198: feat!: upgrade android gradle plugin@4.1.3
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1198:
URL: https://github.com/apache/cordova-android/pull/1198#issuecomment-818508019
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1198?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1198](https://codecov.io/gh/apache/cordova-android/pull/1198?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (18afa5b) into [master](https://codecov.io/gh/apache/cordova-android/commit/46d4d924cc1a31b949425f17a74d8e1a38df10f6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (46d4d92) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/1198?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1198 +/- ##
=======================================
Coverage 72.81% 72.81%
=======================================
Files 21 21
Lines 1747 1747
=======================================
Hits 1272 1272
Misses 475 475
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1198?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1198?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [46d4d92...18afa5b](https://codecov.io/gh/apache/cordova-android/pull/1198?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on pull request #1198: feat!: upgrade android gradle plugin@4.1.3
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1198:
URL: https://github.com/apache/cordova-android/pull/1198#issuecomment-818508019
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1198?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1198](https://codecov.io/gh/apache/cordova-android/pull/1198?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (18afa5b) into [master](https://codecov.io/gh/apache/cordova-android/commit/46d4d924cc1a31b949425f17a74d8e1a38df10f6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (46d4d92) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/1198?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1198 +/- ##
=======================================
Coverage 72.81% 72.81%
=======================================
Files 21 21
Lines 1747 1747
=======================================
Hits 1272 1272
Misses 475 475
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1198?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1198?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [46d4d92...18afa5b](https://codecov.io/gh/apache/cordova-android/pull/1198?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] erisu merged pull request #1198: feat!: upgrade android gradle plugin@4.1.3
Posted by GitBox <gi...@apache.org>.
erisu merged pull request #1198:
URL: https://github.com/apache/cordova-android/pull/1198
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org