You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Yida Wu (Code Review)" <ge...@cloudera.org> on 2025/04/03 05:35:10 UTC

[Impala-ASF-CR] IMPALA-13894: Allow slow check in tuple cache correctness verification when file sizes differ

Yida Wu has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/22661 )

Change subject: IMPALA-13894: Allow slow check in tuple cache correctness verification when file sizes differ
......................................................................

IMPALA-13894: Allow slow check in tuple cache correctness verification when file sizes differ

Currently, tuple cache correctness verification does a fast check,
and returns an error if file sizes are different.

This patch allows a slow check when file sizes differ. Because the
slow check may provide a clearer error message and help prevent
false mismatches when identical rows appear in a different order,
which may lead to size differences.

Tests:
Manually verified that when file sizes differ, the query proceeds
to the slow check after this change.

Change-Id: I02e031410dac32d9df746201b156783a8b7d9a1a
---
M be/src/exec/tuple-text-file-util.cc
1 file changed, 21 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/22661/2
-- 
To view, visit http://gerrit.cloudera.org:8080/22661
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I02e031410dac32d9df746201b156783a8b7d9a1a
Gerrit-Change-Number: 22661
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>