You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by sebb <se...@gmail.com> on 2010/04/29 16:27:49 UTC

Re: svn commit: r939320 - in /tomcat/trunk/modules: jdbc-pool/doc/ tomcat-lite/java/org/apache/tomcat/lite/servlet/ tomcat-lite/java/org/apache/tomcat/lite/util/

On 29/04/2010, kkolinko@apache.org <kk...@apache.org> wrote:
> Author: kkolinko
>  Date: Thu Apr 29 14:23:46 2010
>  New Revision: 939320
>
>  URL: http://svn.apache.org/viewvc?rev=939320&view=rev
>  Log:
>  Set svn:keywords=Id where there is unexpanded $Id$ keyword in the files

Just a thought - could perhaps remove the Date keyword to stop it being used?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r939320 - in /tomcat/trunk/modules: jdbc-pool/doc/ tomcat-lite/java/org/apache/tomcat/lite/servlet/ tomcat-lite/java/org/apache/tomcat/lite/util/

Posted by Konstantin Kolinko <kn...@gmail.com>.
2010/4/29 sebb <se...@gmail.com>:
> On 29/04/2010, Konstantin Kolinko <kn...@gmail.com> wrote:
>> 2010/4/29 sebb <se...@gmail.com>:
>>  >
>>  > Just a thought - could perhaps remove the Date keyword to stop it being used?
>>  >
>>
>>
>> True, but
>>  a) I do not see a fast and easy way to do it in my environment.
>
> I have a Perl script that I use for checking SVN eol-style and
> executable properties.
> I'm intending to update that to generate a list of SVN commands to
> remove the Date keyword.
>

There are two possible ways:

a) edit existing value of svn:keyword and remove "Date" from it,
as we know that it is no more used

b) generate list of keywords that are actually used in particular file

I expect that the result of b) will be more pretty and more valuable,
but harder to verify.


> The point was merely to prevent accidental use of the Date keyword,
> not to speed up SVN.
>

While the above is true, I do not think that "accidental use" is very likely.
I do not see much profit from trying to prevent it.

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r939320 - in /tomcat/trunk/modules: jdbc-pool/doc/ tomcat-lite/java/org/apache/tomcat/lite/servlet/ tomcat-lite/java/org/apache/tomcat/lite/util/

Posted by sebb <se...@gmail.com>.
On 29/04/2010, Konstantin Kolinko <kn...@gmail.com> wrote:
> 2010/4/29 sebb <se...@gmail.com>:
>
> > On 29/04/2010, kkolinko@apache.org <kk...@apache.org> wrote:
>  >> Author: kkolinko
>  >>  Date: Thu Apr 29 14:23:46 2010
>  >>  New Revision: 939320
>  >>
>  >>  URL: http://svn.apache.org/viewvc?rev=939320&view=rev
>  >>  Log:
>  >>  Set svn:keywords=Id where there is unexpanded $Id$ keyword in the files
>  >
>  > Just a thought - could perhaps remove the Date keyword to stop it being used?
>  >
>
>
> True, but
>  a) I do not see a fast and easy way to do it in my environment.

I have a Perl script that I use for checking SVN eol-style and
executable properties.
I'm intending to update that to generate a list of SVN commands to
remove the Date keyword.

>  b) I do not see any harm from that extra keyword being present in svn:keywords.
>
>  It is unlikely that there will be a noticeable change in the speed of
>  svn up and svn checkout if we remove that extra keyword.

The point was merely to prevent accidental use of the Date keyword,
not to speed up SVN.

>  Best regards,
>
> Konstantin Kolinko
>
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>  For additional commands, e-mail: dev-help@tomcat.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r939320 - in /tomcat/trunk/modules: jdbc-pool/doc/ tomcat-lite/java/org/apache/tomcat/lite/servlet/ tomcat-lite/java/org/apache/tomcat/lite/util/

Posted by Konstantin Kolinko <kn...@gmail.com>.
2010/4/29 sebb <se...@gmail.com>:
> On 29/04/2010, kkolinko@apache.org <kk...@apache.org> wrote:
>> Author: kkolinko
>>  Date: Thu Apr 29 14:23:46 2010
>>  New Revision: 939320
>>
>>  URL: http://svn.apache.org/viewvc?rev=939320&view=rev
>>  Log:
>>  Set svn:keywords=Id where there is unexpanded $Id$ keyword in the files
>
> Just a thought - could perhaps remove the Date keyword to stop it being used?
>

True, but
a) I do not see a fast and easy way to do it in my environment.
b) I do not see any harm from that extra keyword being present in svn:keywords.

It is unlikely that there will be a noticeable change in the speed of
svn up and svn checkout if we remove that extra keyword.

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org