You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/05/17 18:55:47 UTC

[GitHub] [superset] nytai commented on a change in pull request #14652: feat: Add `make update` cmd

nytai commented on a change in pull request #14652:
URL: https://github.com/apache/superset/pull/14652#discussion_r633785731



##########
File path: Makefile
##########
@@ -38,6 +38,22 @@ superset:
 	# Load some data to play with
 	superset load-examples
 
+update:

Review comment:
       `npm ci` will reinstall everything in the lockfile (essentially wiping `node_modules` and then installing fresh packages). `npm install` will instal the missing dependencies in `node_modules`, if there's no lockfile one will be created, if there is a lockfile it will be adhered to.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org