You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "colinwerner (via GitHub)" <gi...@apache.org> on 2026/05/27 22:29:19 UTC
[PR] base image in jdk21; fix link in readme [activemq]
colinwerner opened a new pull request, #2052:
URL: https://github.com/apache/activemq/pull/2052
We now use JDK 21 and we have some custom code that we add to the base activemq classic image that is currently compiling against jdk17. We want to move everything to jdk21.
I don't see any down side here...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] base image in jdk21; fix link in readme [activemq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2052:
URL: https://github.com/apache/activemq/pull/2052#issuecomment-5099141553
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] Docker image update to JDK 25 and README updates [activemq]
Posted by "mattrpav (via GitHub)" <gi...@apache.org>.
mattrpav commented on code in PR #2052:
URL: https://github.com/apache/activemq/pull/2052#discussion_r3692361563
##########
assembly/src/docker/Dockerfile:
##########
@@ -16,7 +16,7 @@
# limitations under the License.
################################################################################
-ARG java_version=17
+ARG java_version=21
Review Comment:
The Dockerfile has static value and is not processed as a filtered-resource to pickup the maven property
ref: https://github.com/apache/activemq/blob/a68a3bf206ca15ebff11d011d3dcb41f926b2ff2/assembly/src/docker/Dockerfile#L19
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] base image in jdk21; fix link in readme [activemq]
Posted by "colinwerner (via GitHub)" <gi...@apache.org>.
colinwerner commented on PR #2052:
URL: https://github.com/apache/activemq/pull/2052#issuecomment-4565754218
That makes total sense, @mattrpav. I completely see your point regarding runtime predictability and keeping a consistent baseline for the 6.2. x line.
I'll leave this MR open so we don't lose visibility on it, and we can target it for whenever you're ready to shift the baseline in a future release, perhaps in 6.3.x? In the meantime, we are compiling our code into JDK17...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] Docker image update to JDK 25 and README updates [activemq]
Posted by "colinwerner (via GitHub)" <gi...@apache.org>.
colinwerner commented on PR #2052:
URL: https://github.com/apache/activemq/pull/2052#issuecomment-6044738352
@mattrpav @jbonofre are we good to merge here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] Docker image update to JDK 25 and README updates [activemq]
Posted by "colinwerner (via GitHub)" <gi...@apache.org>.
colinwerner commented on code in PR #2052:
URL: https://github.com/apache/activemq/pull/2052#discussion_r3692449451
##########
assembly/src/docker/Dockerfile:
##########
@@ -16,7 +16,7 @@
# limitations under the License.
################################################################################
-ARG java_version=17
+ARG java_version=21
Review Comment:
@mattrpav Right, it is not filtered. It comes through as a build arg instead; the docker profiles pass java_version via fabric8's args block in assembly/pom.xml, which overrides the ARG default. On main as-is:
```
mvn clean install -DskipTests -Pdocker -Ddocker-java-version=17
docker run --rm apache/activemq:6.4.0-SNAPSHOT java -version
```
gives Temurin-17.0.19+10. Without the `-D` you get 25. Same Dockerfile, only the property changed.
So `mvn -Pdocker` quietly builds 17 today; this just sets the property to 25 so they match.
That said, dropping the arg and the property might be the better fix. The version is declared in two places right now, and they can drift, which is what happened here; #2257 updated the Dockerfile and the property stayed at 17. If it only lives in the Dockerfile, then `docker build` and `mvn -Pdocker` cannot disagree, and there is no `-D` to remember. The one thing it costs is overriding the JDK per build from the command line. Happy to redo it that way if you prefer. Either way, please let me know...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] base image in jdk21; fix link in readme [activemq]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #2052:
URL: https://github.com/apache/activemq/pull/2052#discussion_r3662882527
##########
assembly/src/docker/Dockerfile:
##########
@@ -16,7 +16,7 @@
# limitations under the License.
################################################################################
-ARG java_version=17
+ARG java_version=21
Review Comment:
That should be 25 now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] Docker image update to JDK 25 and README updates [activemq]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #2052:
URL: https://github.com/apache/activemq/pull/2052#issuecomment-5896341261
I will check one thing in the Dockerfile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] base image in jdk21; fix link in readme [activemq]
Posted by "colinwerner (via GitHub)" <gi...@apache.org>.
colinwerner commented on PR #2052:
URL: https://github.com/apache/activemq/pull/2052#issuecomment-4566431054
Thanks for the additional context @jbonofre and @mattrpav. That makes perfect sense. To clarify, my initial thought was just to bump the container's runtime environment to JDK 21 (while keeping the codebase compiled for 17), as JDK 17 limits what users can run alongside or extend the container with, whereas a JDK 21 environment provides a broader, more modern baseline for the image ecosystem. But I completely see how the SecurityManager deprecation, Spring dependencies, and lack of CI testing on 21 make that unsafe right now.
Since the project isn't ready for a JDK 21 runtime baseline yet, I'll leave this MR open as a draft/placeholder so we don't lose visibility on it. We can dust it off whenever the rest of the project and CI are ready to officially validate against Java 21.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] docker-java-version to 25; fix docker hub links [activemq]
Posted by "colinwerner (via GitHub)" <gi...@apache.org>.
colinwerner commented on code in PR #2052:
URL: https://github.com/apache/activemq/pull/2052#discussion_r3692226950
##########
assembly/src/docker/Dockerfile:
##########
@@ -16,7 +16,7 @@
# limitations under the License.
################################################################################
-ARG java_version=17
+ARG java_version=21
Review Comment:
@jbonofre you beat me to it with #2257, so I rebased and dropped my Dockerfile change.
One thing I noticed and don't quite yet understand is that docker-java-version in the root pom is still 17, and the docker and docker-deploy profiles pass it as a build arg, which overrides the ARG default. So `mvn -Pdocker` builds a 17 image while docker build gives 25. I set the property to 25 here so the two agree.
I verified it both ways locally; the default build pulls 25-jre, and the image comes out Temurin-25.0.3+9, and forcing `-Ddocker-java-version=17` pulls 17-jre. Broker starts up fine on 25.
The 6.3.0 image on docker hub is already 25, though, so I am guessing the release was built with `-Ddocker-java-version=25` passed in? Can you confirm? If so, this would just remove the need for the override.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] Docker image update to JDK 25 and README updates [activemq]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #2052:
URL: https://github.com/apache/activemq/pull/2052#issuecomment-6044766547
I have to check if main is tested with Java 25 on main.
I will review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] base image in jdk21; fix link in readme [activemq]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #2052:
URL: https://github.com/apache/activemq/pull/2052#issuecomment-4565857884
@mattrpav is right. Also, the Docker image should not be updated without updated the rest of the project (CI included).
Today, even on `main`, the JDK version is 17 still.
There's two reasons for that:
1. Spring requirements (for the version we are using)
2. SecurityManager change
The Java version update should be a complete PR (https://activemq.apache.org/components/classic/download/).
Are you proposing to bump Java 21 minimum?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] Docker image update to JDK 25 and README updates [activemq]
Posted by "colinwerner (via GitHub)" <gi...@apache.org>.
colinwerner commented on PR #2052:
URL: https://github.com/apache/activemq/pull/2052#issuecomment-5894833678
@mattrpav Rebased onto current main. The only conflict was in `pom.xml` (next to the `docker-maven-plugin` 0.49.0 bump). The root README link fix is already on main, so it's no longer in this PR. The PR now just sets `docker-java-version` to 25 and updates the docker and helm READMEs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] Docker image update to JDK 25 and README updates [activemq]
Posted by "colinwerner (via GitHub)" <gi...@apache.org>.
colinwerner commented on PR #2052:
URL: https://github.com/apache/activemq/pull/2052#issuecomment-6295385483
> Minor: the description still mentions JDK 21 while the change uses 25, worth updating before merge.
@jbonofre I changed the description to point to 25! Thanks for the feedback!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] Docker image update to JDK 25 and README updates [activemq]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre merged PR #2052:
URL: https://github.com/apache/activemq/pull/2052
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] base image in jdk21; fix link in readme [activemq]
Posted by "mattrpav (via GitHub)" <gi...@apache.org>.
mattrpav commented on PR #2052:
URL: https://github.com/apache/activemq/pull/2052#issuecomment-4559283285
Changing the JDK major version shouldn’t happen in a point release.
Users are free to use this as an example as to how to build their own custom containers as well.
v6.2.x is released with JDK 17 as baseline, we should maintain that version alignment and not change that on users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] base image in jdk21; fix link in readme [activemq]
Posted by "mattrpav (via GitHub)" <gi...@apache.org>.
mattrpav commented on PR #2052:
URL: https://github.com/apache/activemq/pull/2052#issuecomment-4565870418
Temurin JDK 17 LTS support plans to go through October of 2027. As a foundational platform, there is value in ActiveMQ supporting the widest range of JDK as possible.
v6.3.0 provide Multi-release jar for Virtual Thread support, but I don’t see a reason to change the baseline version then.
The community provided containers provide a sample and aren’t intended to support all use cases or end user needs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] Docker image update to JDK 25 and README updates [activemq]
Posted by "colinwerner (via GitHub)" <gi...@apache.org>.
colinwerner commented on PR #2052:
URL: https://github.com/apache/activemq/pull/2052#issuecomment-5296538885
@mattrpav @jbonofre anything else missing before merging?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] Docker image update to JDK 25 and README updates [activemq]
Posted by "mattrpav (via GitHub)" <gi...@apache.org>.
mattrpav commented on PR #2052:
URL: https://github.com/apache/activemq/pull/2052#issuecomment-5876139486
@colinwerner can you take a look at the current merge conflict and rebase this PR? I'll merge for 6.4.0 release (which is in progress now)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] Docker image update to JDK 25 and README updates [activemq]
Posted by "colinwerner (via GitHub)" <gi...@apache.org>.
colinwerner commented on PR #2052:
URL: https://github.com/apache/activemq/pull/2052#issuecomment-6044843913
> The PR title is confusing with the description 😂
Yes, I have updated the PR and the title as parts of my PR were pulled into other PRs, but this is what remains.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] Docker image update to JDK 25 and README updates [activemq]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #2052:
URL: https://github.com/apache/activemq/pull/2052#issuecomment-6044790633
The PR title is confusing with the description 😂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact