[jira] [Commented] (GEODE-8302) WAN Conflation stats are being incorrectly incremented

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149352#comment-17149352 ] 

ASF GitHub Bot commented on GEODE-8302:
---------------------------------------

albertogpz commented on pull request #5313:
URL: https://github.com/apache/geode/pull/5313#issuecomment-652368994


   In the last commit I reverted most of the code added in the second [4ff9b1d](https://github.com/apache/geode/pull/5313/commits/4ff9b1d236771d80bbf6f613d1e13b131519743d) and just added a simpler fix.
   The comment from @davebarnes97 about the javadoc in ```GatewaySenderQueue.java``` would not apply anymore as that javadoc would not change.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> WAN Conflation stats are being incorrectly incremented
> ------------------------------------------------------
>
>                 Key: GEODE-8302
>                 URL: https://issues.apache.org/jira/browse/GEODE-8302
>             Project: Geode
>          Issue Type: Bug
>          Components: statistics, wan
>    Affects Versions: 1.14.0
>            Reporter: Donal Evans
>            Assignee: Alberto Gomez
>            Priority: Major
>
> When the below diff (which adds checks to confirm that conflation stats are not incremented in WAN tests with conflation disabled) is applied, the modified tests fail due to conflation stats being incorrectly incremented. This behaviour is only observed since the changes included in this PR were introduced: https://github.com/apache/geode/pull/4928
> {noformat}
> diff --git a/geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/serial/SerialWANStatsDUnitTest.java b/geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/serial/SerialWANStatsDUnitTest.java
> index b2ed76728f..bc6beb0002 100644
> --- a/geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/serial/SerialWANStatsDUnitTest.java
> +++ b/geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/serial/SerialWANStatsDUnitTest.java
> @@ -209,6 +209,7 @@ public class SerialWANStatsDUnitTest extends WANTestBase {
>  
>      vm4.invoke(() -> WANTestBase.checkQueueStats("ln", 0, entries, entries, entries));
>      vm4.invoke(() -> WANTestBase.checkBatchStats("ln", 1, true));
> +    vm4.invoke(() -> WANTestBase.checkConflatedStats("ln", 0));
>  
>      // wait until queue is empty
>      vm5.invoke(() -> await()
> @@ -354,6 +355,7 @@ public class SerialWANStatsDUnitTest extends WANTestBase {
>  
>      vm4.invoke(() -> WANTestBase.checkQueueStats("ln", 0, entries, entries, entries));
>      vm4.invoke(() -> WANTestBase.checkBatchStats("ln", 2, true, true));
> +    vm4.invoke(() -> WANTestBase.checkConflatedStats("ln", 0));
>  
>      // wait until queue is empty
>      vm5.invoke(() -> await()
> {noformat}
> In addition to the tests above, SerialWANPropagation_PartitionedRegionDUnitTest.testPartitionedSerialPropagationHA() fails with incorrectly incremented conflation stats if a similar check is introduced at the end of the test. Again, without the changes introduced by PR #4928, this modified test passes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)