You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "tejaslodayadd (via GitHub)" <gi...@apache.org> on 2026/05/18 01:13:07 UTC
[PR] CASSANALYTICS-140: Clean up non-ASCII characters in main source JavaDoc and comments [cassandra-analytics]
tejaslodayadd opened a new pull request, #210:
URL: https://github.com/apache/cassandra-analytics/pull/210
https://issues.apache.org/jira/browse/CASSANALYTICS-140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSANALYTICS-140: Clean up non-ASCII characters in main source JavaDoc and comments [cassandra-analytics]
Posted by "sarankk (via GitHub)" <gi...@apache.org>.
sarankk commented on code in PR #210:
URL: https://github.com/apache/cassandra-analytics/pull/210#discussion_r3268298658
##########
CHANGES.txt:
##########
@@ -1,5 +1,6 @@
0.5.0
-----
+ * Clean up non-ASCII characters in main source JavaDoc and comments (CASSANALYTICS-140)
Review Comment:
Nit: Since we are touching comments, shall we skip changes.txt addition?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSANALYTICS-140: Clean up non-ASCII characters in main source JavaDoc and comments [cassandra-analytics]
Posted by "frankgh (via GitHub)" <gi...@apache.org>.
frankgh commented on code in PR #210:
URL: https://github.com/apache/cassandra-analytics/pull/210#discussion_r3256230205
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/RecordWriter.java:
##########
@@ -393,8 +393,8 @@ private Map<String, Object> getBindValuesForColumns(Map<String, Object> map, Str
}
// Convert tuples to TupleValue for CQLSSTableWriter
- // - Direct tuple columns: Object[] → TupleValue
- // - Collections with tuples: List<Object[]> → List<TupleValue> (via collection's convertForCqlWriter)
+ // - Direct tuple columns: Object[] -> TupleValue
+ // - Collections with tuples: List<Object[]> -> List<TupleValue> (via collection's convertForCqlWriter)
Review Comment:
ditto
```suggestion
// - Collections with tuples: List<Object[]> -> List<TupleValue> (via collection's convertForCqlWriter)
```
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/RecordWriter.java:
##########
@@ -393,8 +393,8 @@ private Map<String, Object> getBindValuesForColumns(Map<String, Object> map, Str
}
// Convert tuples to TupleValue for CQLSSTableWriter
- // - Direct tuple columns: Object[] → TupleValue
- // - Collections with tuples: List<Object[]> → List<TupleValue> (via collection's convertForCqlWriter)
+ // - Direct tuple columns: Object[] -> TupleValue
Review Comment:
shouldn't this be `->` instead?
```suggestion
// - Direct tuple columns: Object[] -> TupleValue
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSANALYTICS-140: Clean up non-ASCII characters in main source JavaDoc and comments [cassandra-analytics]
Posted by "frankgh (via GitHub)" <gi...@apache.org>.
frankgh merged PR #210:
URL: https://github.com/apache/cassandra-analytics/pull/210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org