You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/07/06 20:04:50 UTC

[GitHub] [bookkeeper] dlg99 commented on a diff in pull request #3390: [Issue 3389] Prioritize compaction of entry logs with the lowest amount of remaining usable data

dlg99 commented on code in PR #3390:
URL: https://github.com/apache/bookkeeper/pull/3390#discussion_r915211419


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java:
##########
@@ -547,6 +549,9 @@ void doCompactEntryLogs(double threshold, long maxTimeMillis) throws EntryLogMet
         MutableLong end = new MutableLong(start);
         MutableLong timeDiff = new MutableLong(0);
 
+        PriorityQueue<EntryLogMetadata> pq = new PriorityQueue<>(Comparator

Review Comment:
   there is a problem with PersistentEntryLogMetadataMap which does not keep metadata in memory and recycles it when leaves forEach call.
   Let me see what I can do there



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org