You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/09/15 02:39:40 UTC
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #37889: [SPARK-40432][SS][PYTHON] Introduce GroupStateImpl and GroupStateTimeout in PySpark
HyukjinKwon commented on code in PR #37889:
URL: https://github.com/apache/spark/pull/37889#discussion_r971467767
##########
sql/catalyst/src/main/java/org/apache/spark/sql/streaming/GroupStateTimeout.java:
##########
@@ -32,6 +32,11 @@
@Experimental
@Evolving
public class GroupStateTimeout {
+ // scalastyle:off line.size.limit
+ // NOTE: if you're adding new type of timeout, you should also fix the places below:
+ // - Scala: org.apache.spark.sql.execution.streaming.GroupStateImpl.getGroupStateTimeoutFromString
+ // - Python: pyspark.sql.streaming.state.GroupStateTimeout
+ // scalastyle:on line.size.limit
Review Comment:
```suggestion
// NOTE: if you're adding new type of timeout, you should also fix the places below:
// - Scala:
// org.apache.spark.sql.execution.streaming.GroupStateImpl.getGroupStateTimeoutFromString
// - Python: pyspark.sql.streaming.state.GroupStateTimeout
```
##########
sql/catalyst/src/main/java/org/apache/spark/sql/streaming/GroupStateTimeout.java:
##########
@@ -32,6 +32,11 @@
@Experimental
@Evolving
public class GroupStateTimeout {
+ // scalastyle:off line.size.limit
+ // NOTE: if you're adding new type of timeout, you should also fix the places below:
+ // - Scala: org.apache.spark.sql.execution.streaming.GroupStateImpl.getGroupStateTimeoutFromString
+ // - Python: pyspark.sql.streaming.state.GroupStateTimeout
+ // scalastyle:on line.size.limit
Review Comment:
no big deal :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org