You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Hongtu Zang <ho...@tcloudcomputing.com> on 2013/02/20 03:11:42 UTC
Review Request: fix CLOUDSTACK-1334:vmware.root.disk.controller doesn't work
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9519/
-----------------------------------------------------------
Review request for cloudstack and mice xia.
Description
-------
fix CLOUDSTACK-1334:vmware.root.disk.controller doesn't work
This addresses bug CLOUDSTACK-1334.
Diffs
-----
plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java 819d399
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManager.java e219c1c
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java e6d5742
Diff: https://reviews.apache.org/r/9519/diff/
Testing
-------
try to modify the vmware.root.disk.controller value.
it works after the vm stopped and start again.
Thanks,
Hongtu Zang
Re: Review Request: fix CLOUDSTACK-1334:vmware.root.disk.controller doesn't
work
Posted by mice xia <mi...@tcloudcomputing.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9519/#review16832
-----------------------------------------------------------
Ship it!
Ship It!
- mice xia
On Feb. 20, 2013, 2:11 a.m., Hongtu Zang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9519/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2013, 2:11 a.m.)
>
>
> Review request for cloudstack and mice xia.
>
>
> Description
> -------
>
> fix CLOUDSTACK-1334:vmware.root.disk.controller doesn't work
>
>
> This addresses bug CLOUDSTACK-1334.
>
>
> Diffs
> -----
>
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java 819d399
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManager.java e219c1c
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java e6d5742
>
> Diff: https://reviews.apache.org/r/9519/diff/
>
>
> Testing
> -------
>
> try to modify the vmware.root.disk.controller value.
> it works after the vm stopped and start again.
>
>
> Thanks,
>
> Hongtu Zang
>
>
Re: Review Request: fix CLOUDSTACK-1334:vmware.root.disk.controller doesn't
work
Posted by Sateesh Chodapuneedi <sa...@citrix.com>.
> On Feb. 21, 2013, 4:23 a.m., Sateesh Chodapuneedi wrote:
> > plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java, line 139
> > <https://reviews.apache.org/r/9519/diff/1/?file=260147#file260147line139>
> >
> > To update the value of key VmDetailsConstance.ROOT_DISK_CONTROLLER we can check if the key is present or not and just call put method over details map to update the value. containsKey/put is simpler than sequence of get/remove/put.
> >
We can call put method directly because anyway (if key exists or not exists) we are trying to put the key/value pair of VmDetailsConstance.ROOT_DISK_CONTROLLER into the map.
- Sateesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9519/#review16830
-----------------------------------------------------------
On Feb. 20, 2013, 2:11 a.m., Hongtu Zang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9519/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2013, 2:11 a.m.)
>
>
> Review request for cloudstack and mice xia.
>
>
> Description
> -------
>
> fix CLOUDSTACK-1334:vmware.root.disk.controller doesn't work
>
>
> This addresses bug CLOUDSTACK-1334.
>
>
> Diffs
> -----
>
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java 819d399
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManager.java e219c1c
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java e6d5742
>
> Diff: https://reviews.apache.org/r/9519/diff/
>
>
> Testing
> -------
>
> try to modify the vmware.root.disk.controller value.
> it works after the vm stopped and start again.
>
>
> Thanks,
>
> Hongtu Zang
>
>
Re: Review Request: fix CLOUDSTACK-1334:vmware.root.disk.controller doesn't
work
Posted by Sateesh Chodapuneedi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9519/#review16830
-----------------------------------------------------------
plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java
<https://reviews.apache.org/r/9519/#comment35753>
Need tab space cleanup
plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java
<https://reviews.apache.org/r/9519/#comment35752>
Need trailing whitespace cleanup
plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java
<https://reviews.apache.org/r/9519/#comment35756>
To update the value of key VmDetailsConstance.ROOT_DISK_CONTROLLER we can check if the key is present or not and just call put method over details map to update the value. containsKey/put is simpler than sequence of get/remove/put.
plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java
<https://reviews.apache.org/r/9519/#comment35751>
Need tab space cleanup
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManager.java
<https://reviews.apache.org/r/9519/#comment35755>
Need tab space cleanup
- Sateesh Chodapuneedi
On Feb. 20, 2013, 2:11 a.m., Hongtu Zang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9519/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2013, 2:11 a.m.)
>
>
> Review request for cloudstack and mice xia.
>
>
> Description
> -------
>
> fix CLOUDSTACK-1334:vmware.root.disk.controller doesn't work
>
>
> This addresses bug CLOUDSTACK-1334.
>
>
> Diffs
> -----
>
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java 819d399
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManager.java e219c1c
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java e6d5742
>
> Diff: https://reviews.apache.org/r/9519/diff/
>
>
> Testing
> -------
>
> try to modify the vmware.root.disk.controller value.
> it works after the vm stopped and start again.
>
>
> Thanks,
>
> Hongtu Zang
>
>