[commons-dbcp] branch master updated: Comment empty blocks and update @since tags.

[gg...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-dbcp.git


The following commit(s) were added to refs/heads/master by this push:
     new 9103d30  Comment empty blocks and update @since tags.
9103d30 is described below

commit 9103d30004447ba576c46e2bfa53836b76b755d4
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Mon Sep 21 11:38:17 2020 -0400

    Comment empty blocks and update @since tags.
---
 .../org/apache/commons/dbcp2/BasicDataSourceMXBean.java     | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/src/main/java/org/apache/commons/dbcp2/BasicDataSourceMXBean.java b/src/main/java/org/apache/commons/dbcp2/BasicDataSourceMXBean.java
index b103641..96dbea7 100644
--- a/src/main/java/org/apache/commons/dbcp2/BasicDataSourceMXBean.java
+++ b/src/main/java/org/apache/commons/dbcp2/BasicDataSourceMXBean.java
@@ -333,15 +333,20 @@ public interface BasicDataSourceMXBean {
      *
      * @throws SQLException if an error occurs initializing the datasource
      *
-     * @since 2.8
+     * @since 2.8.0
      */
-    default void start() throws SQLException {}
+    default void start() throws SQLException {
+        // do nothing
+    }
 
     /**
      * See {@link BasicDataSource#restart()}
+     * 
      * @throws SQLException if an error occurs initializing the datasource
      *
-     * @since 2.8
+     * @since 2.8.0
      */
-    default void restart() throws SQLException {}
+    default void restart() throws SQLException {
+        // do nothing by default?
+    }
 }