You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/07 14:09:42 UTC
[GitHub] [flink] godfreyhe opened a new pull request #12025: [FLINK-17435] [hive] Hive non-partitioned source supports streaming read
godfreyhe opened a new pull request #12025:
URL: https://github.com/apache/flink/pull/12025
## What is the purpose of the change
*for non-partitioned hive source, we can use existing continuous file processing mechanism to read new data. This pr aim let non-partitioned hive source support streaming read.*
## Brief change log
- *A hive FileInputFormat that wraps HiveTableInputFormat*
- *create streaming source with PROCESS_CONTINUOUSLY mode*
## Verifying this change
This change added tests and can be verified as follows:
- *Extended HiveTableSourceTest for streaming read on non-partitioned source*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (**yes** / no)
- If yes, how is the feature documented? (not applicable / docs / **JavaDocs** / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12025: [FLINK-17435] [hive] Hive non-partitioned source supports streaming read
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12025:
URL: https://github.com/apache/flink/pull/12025#issuecomment-625292121
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "30dd6061f66d0c4e0935a9b3537a608ee3db69cd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=762",
"triggerID" : "30dd6061f66d0c4e0935a9b3537a608ee3db69cd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 30dd6061f66d0c4e0935a9b3537a608ee3db69cd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=762)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi commented on pull request #12025: [FLINK-17435] [hive] Hive non-partitioned source supports streaming read
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on pull request #12025:
URL: https://github.com/apache/flink/pull/12025#issuecomment-629241901
Thanks @rmetzger for fixing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12025: [FLINK-17435] [hive] Hive non-partitioned source supports streaming read
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12025:
URL: https://github.com/apache/flink/pull/12025#issuecomment-625292121
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "30dd6061f66d0c4e0935a9b3537a608ee3db69cd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=762",
"triggerID" : "30dd6061f66d0c4e0935a9b3537a608ee3db69cd",
"triggerType" : "PUSH"
}, {
"hash" : "536fe9b624ee00e02522c57cb904a4c795d425c7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=781",
"triggerID" : "536fe9b624ee00e02522c57cb904a4c795d425c7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 30dd6061f66d0c4e0935a9b3537a608ee3db69cd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=762)
* 536fe9b624ee00e02522c57cb904a4c795d425c7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=781)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12025: [FLINK-17435] [hive] Hive non-partitioned source supports streaming read
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12025:
URL: https://github.com/apache/flink/pull/12025#issuecomment-625292121
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "30dd6061f66d0c4e0935a9b3537a608ee3db69cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=762",
"triggerID" : "30dd6061f66d0c4e0935a9b3537a608ee3db69cd",
"triggerType" : "PUSH"
}, {
"hash" : "536fe9b624ee00e02522c57cb904a4c795d425c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=781",
"triggerID" : "536fe9b624ee00e02522c57cb904a4c795d425c7",
"triggerType" : "PUSH"
}, {
"hash" : "04db04d8d1b41ca05618c5b09b83b3031bf7ee11",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1313",
"triggerID" : "04db04d8d1b41ca05618c5b09b83b3031bf7ee11",
"triggerType" : "PUSH"
}, {
"hash" : "d4b70dbd62d22edbaf0c3ff54ca61a35ac93c04e",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1356",
"triggerID" : "d4b70dbd62d22edbaf0c3ff54ca61a35ac93c04e",
"triggerType" : "PUSH"
}, {
"hash" : "c38c037f31687b4d20ef0e183d42cc5f64d3bb45",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1365",
"triggerID" : "c38c037f31687b4d20ef0e183d42cc5f64d3bb45",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d4b70dbd62d22edbaf0c3ff54ca61a35ac93c04e Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1356)
* c38c037f31687b4d20ef0e183d42cc5f64d3bb45 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1365)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12025: [FLINK-17435] [hive] Hive non-partitioned source supports streaming read
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12025:
URL: https://github.com/apache/flink/pull/12025#issuecomment-625292121
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "30dd6061f66d0c4e0935a9b3537a608ee3db69cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=762",
"triggerID" : "30dd6061f66d0c4e0935a9b3537a608ee3db69cd",
"triggerType" : "PUSH"
}, {
"hash" : "536fe9b624ee00e02522c57cb904a4c795d425c7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=781",
"triggerID" : "536fe9b624ee00e02522c57cb904a4c795d425c7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 536fe9b624ee00e02522c57cb904a4c795d425c7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=781)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12025: [FLINK-17435] [hive] Hive non-partitioned source supports streaming read
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12025:
URL: https://github.com/apache/flink/pull/12025#issuecomment-625292121
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "30dd6061f66d0c4e0935a9b3537a608ee3db69cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=762",
"triggerID" : "30dd6061f66d0c4e0935a9b3537a608ee3db69cd",
"triggerType" : "PUSH"
}, {
"hash" : "536fe9b624ee00e02522c57cb904a4c795d425c7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=781",
"triggerID" : "536fe9b624ee00e02522c57cb904a4c795d425c7",
"triggerType" : "PUSH"
}, {
"hash" : "04db04d8d1b41ca05618c5b09b83b3031bf7ee11",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "04db04d8d1b41ca05618c5b09b83b3031bf7ee11",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 536fe9b624ee00e02522c57cb904a4c795d425c7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=781)
* 04db04d8d1b41ca05618c5b09b83b3031bf7ee11 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi merged pull request #12025: [FLINK-17435] [hive] Hive non-partitioned source supports streaming read
Posted by GitBox <gi...@apache.org>.
JingsongLi merged pull request #12025:
URL: https://github.com/apache/flink/pull/12025
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12025: [FLINK-17435] [hive] Hive non-partitioned source supports streaming read
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12025:
URL: https://github.com/apache/flink/pull/12025#issuecomment-625292121
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "30dd6061f66d0c4e0935a9b3537a608ee3db69cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=762",
"triggerID" : "30dd6061f66d0c4e0935a9b3537a608ee3db69cd",
"triggerType" : "PUSH"
}, {
"hash" : "536fe9b624ee00e02522c57cb904a4c795d425c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=781",
"triggerID" : "536fe9b624ee00e02522c57cb904a4c795d425c7",
"triggerType" : "PUSH"
}, {
"hash" : "04db04d8d1b41ca05618c5b09b83b3031bf7ee11",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1313",
"triggerID" : "04db04d8d1b41ca05618c5b09b83b3031bf7ee11",
"triggerType" : "PUSH"
}, {
"hash" : "d4b70dbd62d22edbaf0c3ff54ca61a35ac93c04e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d4b70dbd62d22edbaf0c3ff54ca61a35ac93c04e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 04db04d8d1b41ca05618c5b09b83b3031bf7ee11 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1313)
* d4b70dbd62d22edbaf0c3ff54ca61a35ac93c04e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #12025: [FLINK-17435] [hive] Hive non-partitioned source supports streaming read
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #12025:
URL: https://github.com/apache/flink/pull/12025#issuecomment-629233781
I reopened the ticket
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12025: [FLINK-17435] [hive] Hive non-partitioned source supports streaming read
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12025:
URL: https://github.com/apache/flink/pull/12025#issuecomment-625281248
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 30dd6061f66d0c4e0935a9b3537a608ee3db69cd (Thu May 07 14:13:57 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12025: [FLINK-17435] [hive] Hive non-partitioned source supports streaming read
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12025:
URL: https://github.com/apache/flink/pull/12025#issuecomment-625292121
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "30dd6061f66d0c4e0935a9b3537a608ee3db69cd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "30dd6061f66d0c4e0935a9b3537a608ee3db69cd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 30dd6061f66d0c4e0935a9b3537a608ee3db69cd UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #12025: [FLINK-17435] [hive] Hive non-partitioned source supports streaming read
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #12025:
URL: https://github.com/apache/flink/pull/12025#issuecomment-629232771
Note: This change broke master: https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=1429&view=logs&s=ae4f8708-9994-57d3-c2d7-b892156e7812&j=52b61abe-a3cc-5bde-cc35-1bbe89bb7df5
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12025: [FLINK-17435] [hive] Hive non-partitioned source supports streaming read
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12025:
URL: https://github.com/apache/flink/pull/12025#issuecomment-625292121
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "30dd6061f66d0c4e0935a9b3537a608ee3db69cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=762",
"triggerID" : "30dd6061f66d0c4e0935a9b3537a608ee3db69cd",
"triggerType" : "PUSH"
}, {
"hash" : "536fe9b624ee00e02522c57cb904a4c795d425c7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=781",
"triggerID" : "536fe9b624ee00e02522c57cb904a4c795d425c7",
"triggerType" : "PUSH"
}, {
"hash" : "04db04d8d1b41ca05618c5b09b83b3031bf7ee11",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1313",
"triggerID" : "04db04d8d1b41ca05618c5b09b83b3031bf7ee11",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 536fe9b624ee00e02522c57cb904a4c795d425c7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=781)
* 04db04d8d1b41ca05618c5b09b83b3031bf7ee11 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1313)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on a change in pull request #12025: [FLINK-17435] [hive] Hive non-partitioned source supports streaming read
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #12025:
URL: https://github.com/apache/flink/pull/12025#discussion_r425546227
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/read/HiveTableFileInputFormat.java
##########
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connectors.hive.read;
+
+import org.apache.flink.api.common.functions.RuntimeContext;
+import org.apache.flink.api.common.io.FileInputFormat;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.connectors.hive.HiveTablePartition;
+import org.apache.flink.core.fs.FileInputSplit;
+import org.apache.flink.table.data.RowData;
+
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.mapred.FileSplit;
+
+import java.io.IOException;
+import java.net.URI;
+
+/**
+ * A {@link FileInputFormat} that wraps a {@link HiveTableInputFormat}.
Review comment:
"Only support renaming inserting" is not the limitation of `HiveTableFileInputFormat`, it's the limit of `ContinuousFileMonitoringFunction`, I have add some documents in `FileSystemOptions`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12025: [FLINK-17435] [hive] Hive non-partitioned source supports streaming read
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12025:
URL: https://github.com/apache/flink/pull/12025#issuecomment-625292121
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "30dd6061f66d0c4e0935a9b3537a608ee3db69cd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=762",
"triggerID" : "30dd6061f66d0c4e0935a9b3537a608ee3db69cd",
"triggerType" : "PUSH"
}, {
"hash" : "536fe9b624ee00e02522c57cb904a4c795d425c7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "536fe9b624ee00e02522c57cb904a4c795d425c7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 30dd6061f66d0c4e0935a9b3537a608ee3db69cd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=762)
* 536fe9b624ee00e02522c57cb904a4c795d425c7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi commented on a change in pull request #12025: [FLINK-17435] [hive] Hive non-partitioned source supports streaming read
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #12025:
URL: https://github.com/apache/flink/pull/12025#discussion_r425536040
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/ConsumeOrder.java
##########
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connectors.hive;
+
+/**
+ * {@link ConsumeOrder} defines the orders to continuously consume stream source.
+ */
+public enum ConsumeOrder {
+
+ /**
+ * create-time compare partition/file creation time,
+ * this is not the partition create time in Hive metaStore,
+ * but the folder/file create time in filesystem.
+ */
+ CREATE_TIME_ORDER("create-time"),
+
+ /**
+ * partition-time compare time represented by partition name.
+ */
+ PARTITION_TIME_ORDER("partition-time");
+
+ private final String order;
+ ConsumeOrder(String order) {
+ this.order = order;
+ }
+
+ @Override
+ public String toString() {
+ return order;
+ }
+
+ /**
+ * Get {@link ConsumeOrder} from consume order string.
+ */
+ public static ConsumeOrder getConsumeOrder(String consumeOrderStr) {
+ for (ConsumeOrder consumeOrder : ConsumeOrder.values()) {
Review comment:
`ConsumeOrder.values()` -> `values()`
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/ConsumeOrder.java
##########
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connectors.hive;
+
+/**
+ * {@link ConsumeOrder} defines the orders to continuously consume stream source.
+ */
+public enum ConsumeOrder {
+
+ /**
+ * create-time compare partition/file creation time,
+ * this is not the partition create time in Hive metaStore,
+ * but the folder/file create time in filesystem.
+ */
+ CREATE_TIME_ORDER("create-time"),
+
+ /**
+ * partition-time compare time represented by partition name.
+ */
+ PARTITION_TIME_ORDER("partition-time");
+
+ private final String order;
+ ConsumeOrder(String order) {
Review comment:
Above should have a blank line.
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/read/HiveTableFileInputFormat.java
##########
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connectors.hive.read;
+
+import org.apache.flink.api.common.functions.RuntimeContext;
+import org.apache.flink.api.common.io.FileInputFormat;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.connectors.hive.HiveTablePartition;
+import org.apache.flink.core.fs.FileInputSplit;
+import org.apache.flink.table.data.RowData;
+
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.mapred.FileSplit;
+
+import java.io.IOException;
+import java.net.URI;
+
+/**
+ * A {@link FileInputFormat} that wraps a {@link HiveTableInputFormat}.
+ */
+public class HiveTableFileInputFormat extends FileInputFormat<RowData> {
+
+ private HiveTableInputFormat inputFormat;
+ private HiveTablePartition hiveTablePartition;
+
+ public HiveTableFileInputFormat(
+ HiveTableInputFormat inputFormat,
+ HiveTablePartition hiveTablePartition) {
+ this.inputFormat = inputFormat;
+ this.hiveTablePartition = hiveTablePartition;
+ }
+
+ @Override
+ public void open(FileInputSplit fileSplit) throws IOException {
+ URI uri = fileSplit.getPath().toUri();
+ HiveTableInputSplit split = new HiveTableInputSplit(
+ fileSplit.getSplitNumber(),
+ new FileSplit(new Path(uri), fileSplit.getStart(), fileSplit.getLength(), (String[]) null),
+ inputFormat.getJobConf(),
+ hiveTablePartition
+ );
+ inputFormat.open(split);
+ }
+
+ @Override
+ public boolean reachedEnd() throws IOException {
+ return inputFormat.reachedEnd();
+ }
+
+ @Override
+ public RowData nextRecord(RowData reuse) throws IOException {
+ return inputFormat.nextRecord(reuse);
+ }
+
+ @Override
+ public void configure(Configuration parameters) {
+ inputFormat.configure(parameters);
Review comment:
A better way is first `super.`, second do own works.
same below.
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSource.java
##########
@@ -261,6 +267,57 @@ private boolean isStreamingSource() {
return new DataStreamSource<>(source);
}
+ private DataStream<RowData> createStreamSourceForNonPartitionTable(
+ StreamExecutionEnvironment execEnv,
+ TypeInformation<RowData> typeInfo,
+ HiveTableInputFormat inputFormat,
+ HiveTablePartition hiveTable) {
+ HiveTableFileInputFormat fileInputFormat = new HiveTableFileInputFormat(
+ inputFormat,
+ hiveTable);
+ fileInputFormat.setFilePath(getFilePath());
+
+ final Map<String, String> properties = catalogTable.getOptions();
+
+ String consumeOrderStr = properties.getOrDefault(
+ STREAMING_SOURCE_CONSUME_ORDER.key(),
+ STREAMING_SOURCE_CONSUME_ORDER.defaultValue());
+ ConsumeOrder consumeOrder = ConsumeOrder.getConsumeOrder(consumeOrderStr);
+ if (consumeOrder != ConsumeOrder.CREATE_TIME_ORDER) {
+ throw new UnsupportedOperationException("Unsupported consumer order: " + consumeOrder);
+ }
+
+ String consumeOffset = properties.getOrDefault(
+ STREAMING_SOURCE_CONSUME_START_OFFSET.key(),
+ STREAMING_SOURCE_CONSUME_START_OFFSET.defaultValue());
+ long currentReadTime = Long.MIN_VALUE;
+ if (consumeOffset != null) {
Review comment:
never null.
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSource.java
##########
@@ -261,6 +267,57 @@ private boolean isStreamingSource() {
return new DataStreamSource<>(source);
}
+ private DataStream<RowData> createStreamSourceForNonPartitionTable(
+ StreamExecutionEnvironment execEnv,
+ TypeInformation<RowData> typeInfo,
+ HiveTableInputFormat inputFormat,
+ HiveTablePartition hiveTable) {
+ HiveTableFileInputFormat fileInputFormat = new HiveTableFileInputFormat(
+ inputFormat,
+ hiveTable);
+ fileInputFormat.setFilePath(getFilePath());
Review comment:
Remove `getFilePath`, we can get path from `allHivePartitions`(should be a single object when no partitions.).
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/read/HiveTableFileInputFormat.java
##########
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connectors.hive.read;
+
+import org.apache.flink.api.common.functions.RuntimeContext;
+import org.apache.flink.api.common.io.FileInputFormat;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.connectors.hive.HiveTablePartition;
+import org.apache.flink.core.fs.FileInputSplit;
+import org.apache.flink.table.data.RowData;
+
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.mapred.FileSplit;
+
+import java.io.IOException;
+import java.net.URI;
+
+/**
+ * A {@link FileInputFormat} that wraps a {@link HiveTableInputFormat}.
Review comment:
Please add comments:
- Only support FileInputSplit
- Only support renaming inserting
- getSplit use flinks instead format.
##########
File path: flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveTableSourceTest.java
##########
@@ -531,6 +534,76 @@ public void testStreamPartitionRead() throws Exception {
job.cancel();
}
+ @Test(timeout = 30000)
+ public void testNonPartitionStreamingSourceWithMapredReader() throws Exception {
+ testNonPartitionStreamingSource(true, "test_mapred_reader");
+ }
+
+ @Test(timeout = 30000)
+ public void testNonPartitionStreamingSourceWithVectorizedReader() throws Exception {
+ testNonPartitionStreamingSource(false, "test_vectorized_reader");
+ }
+
+ private void testNonPartitionStreamingSource(Boolean useMapredReader, String tblName) throws Exception {
+ final String catalogName = "hive";
+ final String dbName = "source_db";
+ hiveShell.execute("CREATE TABLE source_db." + tblName + " (" +
+ " a INT," +
+ " b CHAR(1) " +
+ ") TBLPROPERTIES (" +
+ " 'streaming-source.enable'='true'," +
Review comment:
`useMapredReader` only works in parquet and orc, you should use them.
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSource.java
##########
@@ -261,6 +267,57 @@ private boolean isStreamingSource() {
return new DataStreamSource<>(source);
}
+ private DataStream<RowData> createStreamSourceForNonPartitionTable(
+ StreamExecutionEnvironment execEnv,
+ TypeInformation<RowData> typeInfo,
+ HiveTableInputFormat inputFormat,
+ HiveTablePartition hiveTable) {
+ HiveTableFileInputFormat fileInputFormat = new HiveTableFileInputFormat(
+ inputFormat,
+ hiveTable);
+ fileInputFormat.setFilePath(getFilePath());
+
+ final Map<String, String> properties = catalogTable.getOptions();
Review comment:
```
Configuration configuration = new Configuration();
options.forEach(configuration::setString)
```
We can use `Configuration` to get option.
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/ConsumeOrder.java
##########
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connectors.hive;
+
+/**
+ * {@link ConsumeOrder} defines the orders to continuously consume stream source.
+ */
+public enum ConsumeOrder {
+
+ /**
+ * create-time compare partition/file creation time,
+ * this is not the partition create time in Hive metaStore,
+ * but the folder/file create time in filesystem.
+ */
+ CREATE_TIME_ORDER("create-time"),
+
+ /**
+ * partition-time compare time represented by partition name.
+ */
+ PARTITION_TIME_ORDER("partition-time");
+
+ private final String order;
+ ConsumeOrder(String order) {
+ this.order = order;
+ }
+
+ @Override
+ public String toString() {
+ return order;
+ }
+
+ /**
+ * Get {@link ConsumeOrder} from consume order string.
+ */
+ public static ConsumeOrder getConsumeOrder(String consumeOrderStr) {
+ for (ConsumeOrder consumeOrder : ConsumeOrder.values()) {
+ if (consumeOrder.order.equals(consumeOrderStr)) {
Review comment:
`equalsIgnoreCase`
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/ConsumeOrder.java
##########
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connectors.hive;
+
+/**
+ * {@link ConsumeOrder} defines the orders to continuously consume stream source.
+ */
+public enum ConsumeOrder {
+
+ /**
+ * create-time compare partition/file creation time,
+ * this is not the partition create time in Hive metaStore,
+ * but the folder/file create time in filesystem.
+ */
+ CREATE_TIME_ORDER("create-time"),
+
+ /**
+ * partition-time compare time represented by partition name.
+ */
+ PARTITION_TIME_ORDER("partition-time");
+
+ private final String order;
+ ConsumeOrder(String order) {
+ this.order = order;
+ }
+
+ @Override
+ public String toString() {
+ return order;
+ }
+
+ /**
+ * Get {@link ConsumeOrder} from consume order string.
+ */
+ public static ConsumeOrder getConsumeOrder(String consumeOrderStr) {
+ for (ConsumeOrder consumeOrder : ConsumeOrder.values()) {
+ if (consumeOrder.order.equals(consumeOrderStr)) {
+ return consumeOrder;
+ }
+ }
+ return null;
Review comment:
throw exception, we should not pass a null to operators.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12025: [FLINK-17435] [hive] Hive non-partitioned source supports streaming read
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12025:
URL: https://github.com/apache/flink/pull/12025#issuecomment-625292121
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "30dd6061f66d0c4e0935a9b3537a608ee3db69cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=762",
"triggerID" : "30dd6061f66d0c4e0935a9b3537a608ee3db69cd",
"triggerType" : "PUSH"
}, {
"hash" : "536fe9b624ee00e02522c57cb904a4c795d425c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=781",
"triggerID" : "536fe9b624ee00e02522c57cb904a4c795d425c7",
"triggerType" : "PUSH"
}, {
"hash" : "04db04d8d1b41ca05618c5b09b83b3031bf7ee11",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1313",
"triggerID" : "04db04d8d1b41ca05618c5b09b83b3031bf7ee11",
"triggerType" : "PUSH"
}, {
"hash" : "d4b70dbd62d22edbaf0c3ff54ca61a35ac93c04e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1356",
"triggerID" : "d4b70dbd62d22edbaf0c3ff54ca61a35ac93c04e",
"triggerType" : "PUSH"
}, {
"hash" : "c38c037f31687b4d20ef0e183d42cc5f64d3bb45",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1365",
"triggerID" : "c38c037f31687b4d20ef0e183d42cc5f64d3bb45",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c38c037f31687b4d20ef0e183d42cc5f64d3bb45 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1365)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12025: [FLINK-17435] [hive] Hive non-partitioned source supports streaming read
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12025:
URL: https://github.com/apache/flink/pull/12025#issuecomment-625292121
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "30dd6061f66d0c4e0935a9b3537a608ee3db69cd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=762",
"triggerID" : "30dd6061f66d0c4e0935a9b3537a608ee3db69cd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 30dd6061f66d0c4e0935a9b3537a608ee3db69cd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=762)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12025: [FLINK-17435] [hive] Hive non-partitioned source supports streaming read
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12025:
URL: https://github.com/apache/flink/pull/12025#issuecomment-625292121
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "30dd6061f66d0c4e0935a9b3537a608ee3db69cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=762",
"triggerID" : "30dd6061f66d0c4e0935a9b3537a608ee3db69cd",
"triggerType" : "PUSH"
}, {
"hash" : "536fe9b624ee00e02522c57cb904a4c795d425c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=781",
"triggerID" : "536fe9b624ee00e02522c57cb904a4c795d425c7",
"triggerType" : "PUSH"
}, {
"hash" : "04db04d8d1b41ca05618c5b09b83b3031bf7ee11",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1313",
"triggerID" : "04db04d8d1b41ca05618c5b09b83b3031bf7ee11",
"triggerType" : "PUSH"
}, {
"hash" : "d4b70dbd62d22edbaf0c3ff54ca61a35ac93c04e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1356",
"triggerID" : "d4b70dbd62d22edbaf0c3ff54ca61a35ac93c04e",
"triggerType" : "PUSH"
}, {
"hash" : "c38c037f31687b4d20ef0e183d42cc5f64d3bb45",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1365",
"triggerID" : "c38c037f31687b4d20ef0e183d42cc5f64d3bb45",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 04db04d8d1b41ca05618c5b09b83b3031bf7ee11 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1313)
* d4b70dbd62d22edbaf0c3ff54ca61a35ac93c04e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1356)
* c38c037f31687b4d20ef0e183d42cc5f64d3bb45 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1365)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #12025: [FLINK-17435] [hive] Hive non-partitioned source supports streaming read
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #12025:
URL: https://github.com/apache/flink/pull/12025#issuecomment-629233712
I reverted this change in https://github.com/apache/flink/commit/e69d21b6cd99201dfe4ae19d477064be7bc80be0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12025: [FLINK-17435] [hive] Hive non-partitioned source supports streaming read
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12025:
URL: https://github.com/apache/flink/pull/12025#issuecomment-625292121
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "30dd6061f66d0c4e0935a9b3537a608ee3db69cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=762",
"triggerID" : "30dd6061f66d0c4e0935a9b3537a608ee3db69cd",
"triggerType" : "PUSH"
}, {
"hash" : "536fe9b624ee00e02522c57cb904a4c795d425c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=781",
"triggerID" : "536fe9b624ee00e02522c57cb904a4c795d425c7",
"triggerType" : "PUSH"
}, {
"hash" : "04db04d8d1b41ca05618c5b09b83b3031bf7ee11",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1313",
"triggerID" : "04db04d8d1b41ca05618c5b09b83b3031bf7ee11",
"triggerType" : "PUSH"
}, {
"hash" : "d4b70dbd62d22edbaf0c3ff54ca61a35ac93c04e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1356",
"triggerID" : "d4b70dbd62d22edbaf0c3ff54ca61a35ac93c04e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 04db04d8d1b41ca05618c5b09b83b3031bf7ee11 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1313)
* d4b70dbd62d22edbaf0c3ff54ca61a35ac93c04e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1356)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12025: [FLINK-17435] [hive] Hive non-partitioned source supports streaming read
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12025:
URL: https://github.com/apache/flink/pull/12025#issuecomment-625292121
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "30dd6061f66d0c4e0935a9b3537a608ee3db69cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=762",
"triggerID" : "30dd6061f66d0c4e0935a9b3537a608ee3db69cd",
"triggerType" : "PUSH"
}, {
"hash" : "536fe9b624ee00e02522c57cb904a4c795d425c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=781",
"triggerID" : "536fe9b624ee00e02522c57cb904a4c795d425c7",
"triggerType" : "PUSH"
}, {
"hash" : "04db04d8d1b41ca05618c5b09b83b3031bf7ee11",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1313",
"triggerID" : "04db04d8d1b41ca05618c5b09b83b3031bf7ee11",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 04db04d8d1b41ca05618c5b09b83b3031bf7ee11 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1313)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12025: [FLINK-17435] [hive] Hive non-partitioned source supports streaming read
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12025:
URL: https://github.com/apache/flink/pull/12025#issuecomment-625292121
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "30dd6061f66d0c4e0935a9b3537a608ee3db69cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=762",
"triggerID" : "30dd6061f66d0c4e0935a9b3537a608ee3db69cd",
"triggerType" : "PUSH"
}, {
"hash" : "536fe9b624ee00e02522c57cb904a4c795d425c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=781",
"triggerID" : "536fe9b624ee00e02522c57cb904a4c795d425c7",
"triggerType" : "PUSH"
}, {
"hash" : "04db04d8d1b41ca05618c5b09b83b3031bf7ee11",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1313",
"triggerID" : "04db04d8d1b41ca05618c5b09b83b3031bf7ee11",
"triggerType" : "PUSH"
}, {
"hash" : "d4b70dbd62d22edbaf0c3ff54ca61a35ac93c04e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1356",
"triggerID" : "d4b70dbd62d22edbaf0c3ff54ca61a35ac93c04e",
"triggerType" : "PUSH"
}, {
"hash" : "c38c037f31687b4d20ef0e183d42cc5f64d3bb45",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c38c037f31687b4d20ef0e183d42cc5f64d3bb45",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 04db04d8d1b41ca05618c5b09b83b3031bf7ee11 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1313)
* d4b70dbd62d22edbaf0c3ff54ca61a35ac93c04e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1356)
* c38c037f31687b4d20ef0e183d42cc5f64d3bb45 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org