You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by "cxzl25 (via GitHub)" <gi...@apache.org> on 2024/02/19 08:58:40 UTC

[PR] ORC-1623: Use `directOut.put(out)` instead of `directOut.put(out.array())` in `TestZstd` test [orc]

cxzl25 opened a new pull request, #1806:
URL: https://github.com/apache/orc/pull/1806

   ### What changes were proposed in this pull request?
   This PR aims to use `directOut.put(out)` instead of `directOut.put(out.array())` in `TestZstd` test.
   
   ### Why are the changes needed?
   Improve the readability of test code.
   
   ### How was this patch tested?
   GA
   
   ### Was this patch authored or co-authored using generative AI tooling?
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] ORC-1623: Use `directOut.put(out)` instead of `directOut.put(out.array())` in `TestZstd` test [orc]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #1806:
URL: https://github.com/apache/orc/pull/1806#issuecomment-1952866307

   To @deshanxiao , please try to merge this to `main` and `branch-2.0` by using script `dev/merge_orc_pr.py`. 😄 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] ORC-1623: Use `directOut.put(out)` instead of `directOut.put(out.array())` in `TestZstd` test [orc]

Posted by "deshanxiao (via GitHub)" <gi...@apache.org>.
deshanxiao closed pull request #1806: ORC-1623: Use `directOut.put(out)` instead of `directOut.put(out.array())` in `TestZstd` test
URL: https://github.com/apache/orc/pull/1806


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] ORC-1623: Use `directOut.put(out)` instead of `directOut.put(out.array())` in `TestZstd` test [orc]

Posted by "deshanxiao (via GitHub)" <gi...@apache.org>.
deshanxiao commented on PR #1806:
URL: https://github.com/apache/orc/pull/1806#issuecomment-1952018048

   Thanks @cxzl25 . Pending CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] ORC-1623: Use `directOut.put(out)` instead of `directOut.put(out.array())` in `TestZstd` test [orc]

Posted by "deshanxiao (via GitHub)" <gi...@apache.org>.
deshanxiao commented on PR #1806:
URL: https://github.com/apache/orc/pull/1806#issuecomment-1953349227

   Thanks @cxzl25 @dongjoon-hyun  Merged to main/branch-2.0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org