[GitHub] [calcite] danny0405 commented on a change in pull request #1554: [CALCITE-3462] Add method in RelBuilder for conveniently projecting out expressions

[GitBox <gi...@apache.org>]

danny0405 commented on a change in pull request #1554: [CALCITE-3462] Add method in RelBuilder for conveniently projecting out expressions
URL: https://github.com/apache/calcite/pull/1554#discussion_r355099335
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/tools/RelBuilder.java
 ##########
 @@ -1189,8 +1187,8 @@ public RelBuilder filter(Iterable<? extends RexNode> predicates) {
     return filter(ImmutableSet.of(), predicates);
   }
 
-  /** Creates a {@link Filter} of a list of correlation variables
-   * and an array of predicates.
+  /** Creates a {@link Filter} with the specified correlation variables
+   * and predicates.
 
 Review comment:
   Just curious, is `with the specified` better than `of a list of` ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services