You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/08/28 03:52:49 UTC
[GitHub] [lucene-solr] arafalov opened a new pull request #1794: SOLR-14783: Remove DIH from 9.0
arafalov opened a new pull request #1794:
URL: https://github.com/apache/lucene-solr/pull/1794
# Description
DIH has been deprecated in 8.6 and was marked to remove in 9.0
# Solution
This removes DIH and vast majority of its references.
(Should probably be squashed on merge, it was split into many commits for ease of review.)
# Checklist
Please review the following and check all that apply:
- [X] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [X] I have created a Jira issue and added the issue ID to my pull request title.
- [X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [X] I have developed this patch against the `master` branch.
- [X] I have run `ant precommit` and the appropriate test suite.
- [X] I have added/removed documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] ctargett commented on a change in pull request #1794: SOLR-14783: Remove DIH from 9.0
Posted by GitBox <gi...@apache.org>.
ctargett commented on a change in pull request #1794:
URL: https://github.com/apache/lucene-solr/pull/1794#discussion_r479437696
##########
File path: solr/solr-ref-guide/src/major-changes-in-solr-9.adoc
##########
@@ -122,6 +122,8 @@ _(raw; not yet edited)_
and "follower". This includes API calls for the replication handler and metrics. For rolling
upgrades into 9.0, you need to be on Solr version 8.7 or greater. Some metrics also changed, alerts and
monitors on Solr KPIs that mention "master" or "slave" will also now be "leader" and "follower"
+
+* SOLR-14783: Data Imprort Handler (DIH) has been removed from Solr. The community package is available at: https://github.com/rohitbemax/dataimporthandler (Alexandre Rafalovitch)
Review comment:
Typo in "Imprort" here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] janhoy commented on pull request #1794: SOLR-14783: Remove DIH from 9.0
Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #1794:
URL: https://github.com/apache/lucene-solr/pull/1794#issuecomment-682385545
Great work btw, Alexandre. DIH seems to be sprinkled in everywhere, must have been a ton of work!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] arafalov commented on a change in pull request #1794: SOLR-14783: Remove DIH from 9.0
Posted by GitBox <gi...@apache.org>.
arafalov commented on a change in pull request #1794:
URL: https://github.com/apache/lucene-solr/pull/1794#discussion_r479593096
##########
File path: solr/solr-ref-guide/src/uploading-structured-data-store-data-with-the-data-import-handler.adoc
##########
@@ -1,1077 +0,0 @@
-= Uploading Structured Data Store Data with the Data Import Handler
Review comment:
Ok. I'll keep it removed. Maybe in the next version of the Ref Guide, we can feed the section headers into the search as well and DIH could be in the title of one of the sections to find.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] janhoy commented on a change in pull request #1794: SOLR-14783: Remove DIH from 9.0
Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #1794:
URL: https://github.com/apache/lucene-solr/pull/1794#discussion_r478902761
##########
File path: solr/solr-ref-guide/src/uploading-structured-data-store-data-with-the-data-import-handler.adoc
##########
@@ -1,1077 +0,0 @@
-= Uploading Structured Data Store Data with the Data Import Handler
Review comment:
Should this page stay in 9.x as a placeholder, but with a text explaining that DIH is no longer maintained by the project, pointing to the 3rd party package? Or should such references be in a totally new RefGuide page where all deprecated/removed features that are now packages, are listed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] arafalov commented on a change in pull request #1794: SOLR-14783: Remove DIH from 9.0
Posted by GitBox <gi...@apache.org>.
arafalov commented on a change in pull request #1794:
URL: https://github.com/apache/lucene-solr/pull/1794#discussion_r479592970
##########
File path: solr/README.md
##########
@@ -142,8 +141,7 @@ server/
example/
Contains example documents and an alternative Solr home
- directory containing examples of how to use the Data Import Handler,
- see example/example-DIH/README.md for more information.
+ directory containing variours examples.
Review comment:
Not mine, but fixed anyway. Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] arafalov closed pull request #1794: SOLR-14783: Remove DIH from 9.0
Posted by GitBox <gi...@apache.org>.
arafalov closed pull request #1794:
URL: https://github.com/apache/lucene-solr/pull/1794
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] arafalov commented on a change in pull request #1794: SOLR-14783: Remove DIH from 9.0
Posted by GitBox <gi...@apache.org>.
arafalov commented on a change in pull request #1794:
URL: https://github.com/apache/lucene-solr/pull/1794#discussion_r479248434
##########
File path: solr/solr-ref-guide/src/uploading-structured-data-store-data-with-the-data-import-handler.adoc
##########
@@ -1,1077 +0,0 @@
-= Uploading Structured Data Store Data with the Data Import Handler
Review comment:
@ctargett , your opinion would be very valued on the documentation part. Currently, the patch deletes all DIH references and pages except for history and new mention in significant-changes. I did it to make sure I did not leave any dangling cross-references or files. We can put it back or cross-link somewhere else as you think is best.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] arafalov commented on a change in pull request #1794: SOLR-14783: Remove DIH from 9.0
Posted by GitBox <gi...@apache.org>.
arafalov commented on a change in pull request #1794:
URL: https://github.com/apache/lucene-solr/pull/1794#discussion_r479592961
##########
File path: solr/solr-ref-guide/src/major-changes-in-solr-9.adoc
##########
@@ -122,6 +122,8 @@ _(raw; not yet edited)_
and "follower". This includes API calls for the replication handler and metrics. For rolling
upgrades into 9.0, you need to be on Solr version 8.7 or greater. Some metrics also changed, alerts and
monitors on Solr KPIs that mention "master" or "slave" will also now be "leader" and "follower"
+
+* SOLR-14783: Data Imprort Handler (DIH) has been removed from Solr. The community package is available at: https://github.com/rohitbemax/dataimporthandler (Alexandre Rafalovitch)
Review comment:
Fixed. Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] arafalov commented on pull request #1794: SOLR-14783: Remove DIH from 9.0
Posted by GitBox <gi...@apache.org>.
arafalov commented on pull request #1794:
URL: https://github.com/apache/lucene-solr/pull/1794#issuecomment-683300992
Closes #1794
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] epugh commented on a change in pull request #1794: SOLR-14783: Remove DIH from 9.0
Posted by GitBox <gi...@apache.org>.
epugh commented on a change in pull request #1794:
URL: https://github.com/apache/lucene-solr/pull/1794#discussion_r479440152
##########
File path: solr/README.md
##########
@@ -142,8 +141,7 @@ server/
example/
Contains example documents and an alternative Solr home
- directory containing examples of how to use the Data Import Handler,
- see example/example-DIH/README.md for more information.
+ directory containing variours examples.
Review comment:
One more typo ;-) "various"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] ctargett commented on a change in pull request #1794: SOLR-14783: Remove DIH from 9.0
Posted by GitBox <gi...@apache.org>.
ctargett commented on a change in pull request #1794:
URL: https://github.com/apache/lucene-solr/pull/1794#discussion_r479452123
##########
File path: solr/solr-ref-guide/src/uploading-structured-data-store-data-with-the-data-import-handler.adoc
##########
@@ -1,1077 +0,0 @@
-= Uploading Structured Data Store Data with the Data Import Handler
Review comment:
It's an interesting question, and I don't have an answer. I dislike trying to keep a mostly blank page around, because each version of the Guide should stand by itself and be for the version it describes - 9.0 won't have DIH so the page shouldn't be there. That's a general principle. But, the reality is people will look for it and may be lost when they don't find it.
I don't have an ideal solution generally, but in this case I coincidentally happen to be planning a mass re-org of the entire Ref Guide (SOLR-14444) for 9.0. One of the things I'm considering is to consolidate the content of some pages which will remove some. Other pages I intend to rename. So, I'll need to find an answer to the problem. I'm keeping track of these changes in a spreadsheet, in case we need it for however we choose to handle it. Right now I've added this page to my list of changes (with other 9.0 removals that have happened), so I'm OK if you go forward removing it with this effort.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] arafalov merged pull request #1794: SOLR-14783: Remove DIH from 9.0
Posted by GitBox <gi...@apache.org>.
arafalov merged pull request #1794:
URL: https://github.com/apache/lucene-solr/pull/1794
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org