You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2025/03/04 14:20:00 UTC
[jira] [Commented] (MDEP-972) copy-dependencies could copy signatures
[ https://issues.apache.org/jira/browse/MDEP-972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932335#comment-17932335 ]
ASF GitHub Bot commented on MDEP-972:
-------------------------------------
Ndacyayisenga-droid opened a new pull request, #514:
URL: https://github.com/apache/maven-dependency-plugin/pull/514
…e artifacts
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MDEP) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MDEP-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MDEP-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
> copy-dependencies could copy signatures
> ---------------------------------------
>
> Key: MDEP-972
> URL: https://issues.apache.org/jira/browse/MDEP-972
> Project: Maven Dependency Plugin
> Issue Type: Improvement
> Components: copy-dependencies
> Reporter: Benjamin Marwell
> Assignee: Benjamin Marwell
> Priority: Minor
>
> h2. Use case
> Sometimes, the user might wish to keep the signatures for later validation, eg when creating a distribution.
> h2. Compatibility
> This feature can be enabled by system property. The default is off (for compatibility).
>
> h2. Implementation details
> Create a new option, Boolean. Default value is false.
> Good name would be something like "copySignatures" or something with signatures. Make some suggestions.
> Don't forget to add the system property name to the annotation, which could have the prefix "mdep.".
--
This message was sent by Atlassian Jira
(v8.20.10#820010)