[jira] [Commented] (NUTCH-2431) Filterchecker to implement Tool-interface

["Sebastian Nagel (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NUTCH-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16240277#comment-16240277 ] 

Sebastian Nagel commented on NUTCH-2431:
----------------------------------------

+1 but
- could add {{-D...}} or {{-Dproperty=value}} to the command-line help to make clear that it's possible to override properties
- patch does not apply to master because it requires NUTCH-2320: [~jurian], could either decouple it or integrate the latter first and then make sure that the patch still applies?

> Filterchecker to implement Tool-interface
> -----------------------------------------
>
>                 Key: NUTCH-2431
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2431
>             Project: Nutch
>          Issue Type: Improvement
>    Affects Versions: 1.13
>            Reporter: Jurian Broertjes
>            Priority: Minor
>              Labels: urlfilter
>         Attachments: NUTCH-2431.patch
>
>
> The current implementation of the URLFilterChecker does not allow for commandline config overrides. It needs to implement the Tool interface for this. 
> Please see the attached patch



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)