You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/06/10 14:49:23 UTC
[GitHub] [flink] aljoscha opened a new pull request #12589: [FLINK-17327] Fix Kafka Producer Resource Leaks
aljoscha opened a new pull request #12589:
URL: https://github.com/apache/flink/pull/12589
## What is the purpose of the change
This fixes thread leaks that will lead to Flink Task Managers being killed because of the watchdog.
A summary of the bug:
- our code calls close() on the KafkaProducer (Kafka code), which is equivalent to calling close with a timeout of Long.MAX_VALUE
- this means threads will leak when a failure happens, for example because of Broker downtime
- the Flink Task Watchdog will kill the Task Manager because of these threads after a timeout
The fix is to always call close() with a reasonable timeout.
The fix also requires a Kafka version bump because of KAFKA-6635/KAFKA-7763, which mean that resources still leak even when closing with a timeout. Additionally, we need to close with exactly zero as timeout, because otherwise in-flight transactions will be aborted.
## Brief change log
- always call close with zero timeout
- bump Kafka version, this requires some changes to how we use reflection on the Kafka Producer because the internals changed
I add code that forbids calling `close()` with zero timeout by throwing an exception. Alternatively, I could change that to call `close(0)` under the hood, i.e. always enforce calling with zero timeout from the "inside".
## Verifying this change
This is covered by existing threads. I didn't add a test that verifies that we fix the original bug because we would essentially be testing Kafka internals. If I have to I might be able to whip something up.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): yes, Kafka
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
Doesn't introduce a new feature.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12589: [FLINK-17327] Fix Kafka Producer Resource Leaks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12589:
URL: https://github.com/apache/flink/pull/12589#issuecomment-642078835
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3201",
"triggerID" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"triggerType" : "PUSH"
}, {
"hash" : "d94219e43b9ec7087a1d87aae6cbef395fa9862c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3252",
"triggerID" : "d94219e43b9ec7087a1d87aae6cbef395fa9862c",
"triggerType" : "PUSH"
}, {
"hash" : "7b046578a4dcdf41f971409b4e3d5c409ad27316",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3277",
"triggerID" : "7b046578a4dcdf41f971409b4e3d5c409ad27316",
"triggerType" : "PUSH"
}, {
"hash" : "4dcc3252561499a444be7c76fd8ef6edb6547211",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3285",
"triggerID" : "4dcc3252561499a444be7c76fd8ef6edb6547211",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7b046578a4dcdf41f971409b4e3d5c409ad27316 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3277)
* 4dcc3252561499a444be7c76fd8ef6edb6547211 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3285)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12589: [FLINK-17327] Fix Kafka Producer Resource Leaks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12589:
URL: https://github.com/apache/flink/pull/12589#issuecomment-642078835
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3201",
"triggerID" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"triggerType" : "PUSH"
}, {
"hash" : "d94219e43b9ec7087a1d87aae6cbef395fa9862c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3252",
"triggerID" : "d94219e43b9ec7087a1d87aae6cbef395fa9862c",
"triggerType" : "PUSH"
}, {
"hash" : "7b046578a4dcdf41f971409b4e3d5c409ad27316",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3277",
"triggerID" : "7b046578a4dcdf41f971409b4e3d5c409ad27316",
"triggerType" : "PUSH"
}, {
"hash" : "4dcc3252561499a444be7c76fd8ef6edb6547211",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3285",
"triggerID" : "4dcc3252561499a444be7c76fd8ef6edb6547211",
"triggerType" : "PUSH"
}, {
"hash" : "5f3e78794bce9be9960e6bb444d77d748267cd05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3331",
"triggerID" : "5f3e78794bce9be9960e6bb444d77d748267cd05",
"triggerType" : "PUSH"
}, {
"hash" : "9f1c9e9085c8e5ec4ed84d2b54d6e4ffb6c6095e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3389",
"triggerID" : "9f1c9e9085c8e5ec4ed84d2b54d6e4ffb6c6095e",
"triggerType" : "PUSH"
}, {
"hash" : "0cd1604b7e3ae2382235c61c8e1a246eb3f584e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3417",
"triggerID" : "0cd1604b7e3ae2382235c61c8e1a246eb3f584e1",
"triggerType" : "PUSH"
}, {
"hash" : "2dfedf8984c25e6bc3f54367d0e8715f1893ad42",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3496",
"triggerID" : "2dfedf8984c25e6bc3f54367d0e8715f1893ad42",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2dfedf8984c25e6bc3f54367d0e8715f1893ad42 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3496)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12589: [FLINK-17327] Fix Kafka Producer Resource Leaks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12589:
URL: https://github.com/apache/flink/pull/12589#issuecomment-642078835
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3201",
"triggerID" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"triggerType" : "PUSH"
}, {
"hash" : "d94219e43b9ec7087a1d87aae6cbef395fa9862c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3252",
"triggerID" : "d94219e43b9ec7087a1d87aae6cbef395fa9862c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d94219e43b9ec7087a1d87aae6cbef395fa9862c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3252)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12589: [FLINK-17327] Fix Kafka Producer Resource Leaks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12589:
URL: https://github.com/apache/flink/pull/12589#issuecomment-642078835
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3201",
"triggerID" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"triggerType" : "PUSH"
}, {
"hash" : "d94219e43b9ec7087a1d87aae6cbef395fa9862c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d94219e43b9ec7087a1d87aae6cbef395fa9862c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f487b7e0ac685c9eeb239c169726a8abf235e421 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3201)
* d94219e43b9ec7087a1d87aae6cbef395fa9862c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12589: [FLINK-17327] Fix Kafka Producer Resource Leaks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12589:
URL: https://github.com/apache/flink/pull/12589#issuecomment-642078835
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3201",
"triggerID" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"triggerType" : "PUSH"
}, {
"hash" : "d94219e43b9ec7087a1d87aae6cbef395fa9862c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3252",
"triggerID" : "d94219e43b9ec7087a1d87aae6cbef395fa9862c",
"triggerType" : "PUSH"
}, {
"hash" : "7b046578a4dcdf41f971409b4e3d5c409ad27316",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3277",
"triggerID" : "7b046578a4dcdf41f971409b4e3d5c409ad27316",
"triggerType" : "PUSH"
}, {
"hash" : "4dcc3252561499a444be7c76fd8ef6edb6547211",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3285",
"triggerID" : "4dcc3252561499a444be7c76fd8ef6edb6547211",
"triggerType" : "PUSH"
}, {
"hash" : "5f3e78794bce9be9960e6bb444d77d748267cd05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3331",
"triggerID" : "5f3e78794bce9be9960e6bb444d77d748267cd05",
"triggerType" : "PUSH"
}, {
"hash" : "9f1c9e9085c8e5ec4ed84d2b54d6e4ffb6c6095e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3389",
"triggerID" : "9f1c9e9085c8e5ec4ed84d2b54d6e4ffb6c6095e",
"triggerType" : "PUSH"
}, {
"hash" : "0cd1604b7e3ae2382235c61c8e1a246eb3f584e1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3417",
"triggerID" : "0cd1604b7e3ae2382235c61c8e1a246eb3f584e1",
"triggerType" : "PUSH"
}, {
"hash" : "2dfedf8984c25e6bc3f54367d0e8715f1893ad42",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3496",
"triggerID" : "2dfedf8984c25e6bc3f54367d0e8715f1893ad42",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0cd1604b7e3ae2382235c61c8e1a246eb3f584e1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3417)
* 2dfedf8984c25e6bc3f54367d0e8715f1893ad42 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3496)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] qinjunjerry commented on a change in pull request #12589: [FLINK-17327] Fix Kafka Producer Resource Leaks
Posted by GitBox <gi...@apache.org>.
qinjunjerry commented on a change in pull request #12589:
URL: https://github.com/apache/flink/pull/12589#discussion_r438218371
##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer.java
##########
@@ -961,6 +971,10 @@ protected void recoverAndCommit(FlinkKafkaProducer.KafkaTransactionState transac
"Presumably this transaction has been already committed before",
ex,
transaction);
+ } finally {
+ if (producer != null) {
+ producer.close(30, TimeUnit.SECONDS);
Review comment:
@aljoscha We want to use close(3) instead of close(0) here, right? I have to say I did not read all the code logic there. Same question for the one below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #12589: [FLINK-17327] Fix Kafka Producer Resource Leaks
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #12589:
URL: https://github.com/apache/flink/pull/12589#issuecomment-643172279
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #12589: [FLINK-17327] Fix Kafka Producer Resource Leaks
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #12589:
URL: https://github.com/apache/flink/pull/12589#issuecomment-644256789
Thanks for the reviews! I'm merging
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] becketqin commented on a change in pull request #12589: [FLINK-17327] Fix Kafka Producer Resource Leaks
Posted by GitBox <gi...@apache.org>.
becketqin commented on a change in pull request #12589:
URL: https://github.com/apache/flink/pull/12589#discussion_r438671644
##########
File path: flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011.java
##########
@@ -675,7 +676,7 @@ public void close() throws FlinkKafka011Exception {
break;
case AT_LEAST_ONCE:
case NONE:
- currentTransaction.producer.close();
+ currentTransaction.producer.close(0, TimeUnit.SECONDS);
Review comment:
Technically speaking, we should only close the producer with timeout zero when it is a exactly once producer.
A more consistent approach might be always call flush first, then close the producer with 0 timeout. That should work for both exactly-once and at-least-once cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha closed pull request #12589: [FLINK-17327] Fix Kafka Producer Resource Leaks
Posted by GitBox <gi...@apache.org>.
aljoscha closed pull request #12589:
URL: https://github.com/apache/flink/pull/12589
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on a change in pull request #12589: [FLINK-17327] Fix Kafka Producer Resource Leaks
Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #12589:
URL: https://github.com/apache/flink/pull/12589#discussion_r438582786
##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer.java
##########
@@ -961,6 +971,10 @@ protected void recoverAndCommit(FlinkKafkaProducer.KafkaTransactionState transac
"Presumably this transaction has been already committed before",
ex,
transaction);
+ } finally {
+ if (producer != null) {
+ producer.close(30, TimeUnit.SECONDS);
Review comment:
Ah, something in the rebase must have gone wrong, initially there were two separate commits. Thanks for catching it!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12589: [FLINK-17327] Fix Kafka Producer Resource Leaks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12589:
URL: https://github.com/apache/flink/pull/12589#issuecomment-642078835
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3201",
"triggerID" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"triggerType" : "PUSH"
}, {
"hash" : "d94219e43b9ec7087a1d87aae6cbef395fa9862c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3252",
"triggerID" : "d94219e43b9ec7087a1d87aae6cbef395fa9862c",
"triggerType" : "PUSH"
}, {
"hash" : "7b046578a4dcdf41f971409b4e3d5c409ad27316",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3277",
"triggerID" : "7b046578a4dcdf41f971409b4e3d5c409ad27316",
"triggerType" : "PUSH"
}, {
"hash" : "4dcc3252561499a444be7c76fd8ef6edb6547211",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3285",
"triggerID" : "4dcc3252561499a444be7c76fd8ef6edb6547211",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4dcc3252561499a444be7c76fd8ef6edb6547211 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3285)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on a change in pull request #12589: [FLINK-17327] Fix Kafka Producer Resource Leaks
Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #12589:
URL: https://github.com/apache/flink/pull/12589#discussion_r439301597
##########
File path: flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/statemachine/kafka/KafkaStandaloneGenerator.java
##########
@@ -90,7 +91,7 @@ public void collect(Event evt) {
@Override
public void close() {
- producer.close();
+ producer.close(Duration.ofSeconds(0));
Review comment:
I will actually revert this change because it's a standalone generator that's not executing in Flink.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #12589: [FLINK-17327] Fix Kafka Producer Resource Leaks
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #12589:
URL: https://github.com/apache/flink/pull/12589#issuecomment-647974387
This was fixed, yes: https://issues.apache.org/jira/browse/FLINK-18311. I don't know how it happened, I had green builds on my private Azure before I merged. Something must have gone wrong (possibly in layer 8... 😅)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12589: [FLINK-17327] Fix Kafka Producer Resource Leaks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12589:
URL: https://github.com/apache/flink/pull/12589#issuecomment-642078835
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3201",
"triggerID" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"triggerType" : "PUSH"
}, {
"hash" : "d94219e43b9ec7087a1d87aae6cbef395fa9862c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3252",
"triggerID" : "d94219e43b9ec7087a1d87aae6cbef395fa9862c",
"triggerType" : "PUSH"
}, {
"hash" : "7b046578a4dcdf41f971409b4e3d5c409ad27316",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3277",
"triggerID" : "7b046578a4dcdf41f971409b4e3d5c409ad27316",
"triggerType" : "PUSH"
}, {
"hash" : "4dcc3252561499a444be7c76fd8ef6edb6547211",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3285",
"triggerID" : "4dcc3252561499a444be7c76fd8ef6edb6547211",
"triggerType" : "PUSH"
}, {
"hash" : "5f3e78794bce9be9960e6bb444d77d748267cd05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3331",
"triggerID" : "5f3e78794bce9be9960e6bb444d77d748267cd05",
"triggerType" : "PUSH"
}, {
"hash" : "9f1c9e9085c8e5ec4ed84d2b54d6e4ffb6c6095e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3389",
"triggerID" : "9f1c9e9085c8e5ec4ed84d2b54d6e4ffb6c6095e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9f1c9e9085c8e5ec4ed84d2b54d6e4ffb6c6095e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3389)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12589: [FLINK-17327] Fix Kafka Producer Resource Leaks
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12589:
URL: https://github.com/apache/flink/pull/12589#issuecomment-642078835
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f487b7e0ac685c9eeb239c169726a8abf235e421 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on a change in pull request #12589: [FLINK-17327] Fix Kafka Producer Resource Leaks
Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #12589:
URL: https://github.com/apache/flink/pull/12589#discussion_r439308935
##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer.java
##########
@@ -1182,7 +1208,7 @@ int getTransactionCoordinatorId() {
private void recycleTransactionalProducer(FlinkKafkaInternalProducer<byte[], byte[]> producer) {
availableTransactionalIds.add(producer.getTransactionalId());
- producer.close();
+ producer.close(Duration.ofSeconds(0));
Review comment:
Will do that, yes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #12589: [FLINK-17327] Fix Kafka Producer Resource Leaks
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #12589:
URL: https://github.com/apache/flink/pull/12589#issuecomment-642765504
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #12589: [FLINK-17327] Fix Kafka Producer Resource Leaks
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #12589:
URL: https://github.com/apache/flink/pull/12589#issuecomment-643997385
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12589: [FLINK-17327] Fix Kafka Producer Resource Leaks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12589:
URL: https://github.com/apache/flink/pull/12589#issuecomment-642078835
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3201",
"triggerID" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"triggerType" : "PUSH"
}, {
"hash" : "d94219e43b9ec7087a1d87aae6cbef395fa9862c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3252",
"triggerID" : "d94219e43b9ec7087a1d87aae6cbef395fa9862c",
"triggerType" : "PUSH"
}, {
"hash" : "7b046578a4dcdf41f971409b4e3d5c409ad27316",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7b046578a4dcdf41f971409b4e3d5c409ad27316",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d94219e43b9ec7087a1d87aae6cbef395fa9862c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3252)
* 7b046578a4dcdf41f971409b4e3d5c409ad27316 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12589: [FLINK-17327] Fix Kafka Producer Resource Leaks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12589:
URL: https://github.com/apache/flink/pull/12589#issuecomment-642078835
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3201",
"triggerID" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"triggerType" : "PUSH"
}, {
"hash" : "d94219e43b9ec7087a1d87aae6cbef395fa9862c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3252",
"triggerID" : "d94219e43b9ec7087a1d87aae6cbef395fa9862c",
"triggerType" : "PUSH"
}, {
"hash" : "7b046578a4dcdf41f971409b4e3d5c409ad27316",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3277",
"triggerID" : "7b046578a4dcdf41f971409b4e3d5c409ad27316",
"triggerType" : "PUSH"
}, {
"hash" : "4dcc3252561499a444be7c76fd8ef6edb6547211",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3285",
"triggerID" : "4dcc3252561499a444be7c76fd8ef6edb6547211",
"triggerType" : "PUSH"
}, {
"hash" : "5f3e78794bce9be9960e6bb444d77d748267cd05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3331",
"triggerID" : "5f3e78794bce9be9960e6bb444d77d748267cd05",
"triggerType" : "PUSH"
}, {
"hash" : "9f1c9e9085c8e5ec4ed84d2b54d6e4ffb6c6095e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3389",
"triggerID" : "9f1c9e9085c8e5ec4ed84d2b54d6e4ffb6c6095e",
"triggerType" : "PUSH"
}, {
"hash" : "0cd1604b7e3ae2382235c61c8e1a246eb3f584e1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0cd1604b7e3ae2382235c61c8e1a246eb3f584e1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9f1c9e9085c8e5ec4ed84d2b54d6e4ffb6c6095e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3389)
* 0cd1604b7e3ae2382235c61c8e1a246eb3f584e1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12589: [FLINK-17327] Fix Kafka Producer Resource Leaks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12589:
URL: https://github.com/apache/flink/pull/12589#issuecomment-642078835
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3201",
"triggerID" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"triggerType" : "PUSH"
}, {
"hash" : "d94219e43b9ec7087a1d87aae6cbef395fa9862c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3252",
"triggerID" : "d94219e43b9ec7087a1d87aae6cbef395fa9862c",
"triggerType" : "PUSH"
}, {
"hash" : "7b046578a4dcdf41f971409b4e3d5c409ad27316",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3277",
"triggerID" : "7b046578a4dcdf41f971409b4e3d5c409ad27316",
"triggerType" : "PUSH"
}, {
"hash" : "4dcc3252561499a444be7c76fd8ef6edb6547211",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3285",
"triggerID" : "4dcc3252561499a444be7c76fd8ef6edb6547211",
"triggerType" : "PUSH"
}, {
"hash" : "5f3e78794bce9be9960e6bb444d77d748267cd05",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3331",
"triggerID" : "5f3e78794bce9be9960e6bb444d77d748267cd05",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4dcc3252561499a444be7c76fd8ef6edb6547211 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3285)
* 5f3e78794bce9be9960e6bb444d77d748267cd05 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3331)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12589: [FLINK-17327] Fix Kafka Producer Resource Leaks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12589:
URL: https://github.com/apache/flink/pull/12589#issuecomment-642078835
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3201",
"triggerID" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"triggerType" : "PUSH"
}, {
"hash" : "d94219e43b9ec7087a1d87aae6cbef395fa9862c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3252",
"triggerID" : "d94219e43b9ec7087a1d87aae6cbef395fa9862c",
"triggerType" : "PUSH"
}, {
"hash" : "7b046578a4dcdf41f971409b4e3d5c409ad27316",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3277",
"triggerID" : "7b046578a4dcdf41f971409b4e3d5c409ad27316",
"triggerType" : "PUSH"
}, {
"hash" : "4dcc3252561499a444be7c76fd8ef6edb6547211",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3285",
"triggerID" : "4dcc3252561499a444be7c76fd8ef6edb6547211",
"triggerType" : "PUSH"
}, {
"hash" : "5f3e78794bce9be9960e6bb444d77d748267cd05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3331",
"triggerID" : "5f3e78794bce9be9960e6bb444d77d748267cd05",
"triggerType" : "PUSH"
}, {
"hash" : "9f1c9e9085c8e5ec4ed84d2b54d6e4ffb6c6095e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3389",
"triggerID" : "9f1c9e9085c8e5ec4ed84d2b54d6e4ffb6c6095e",
"triggerType" : "PUSH"
}, {
"hash" : "0cd1604b7e3ae2382235c61c8e1a246eb3f584e1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3417",
"triggerID" : "0cd1604b7e3ae2382235c61c8e1a246eb3f584e1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0cd1604b7e3ae2382235c61c8e1a246eb3f584e1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3417)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12589: [FLINK-17327] Fix Kafka Producer Resource Leaks
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12589:
URL: https://github.com/apache/flink/pull/12589#issuecomment-642067911
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit f487b7e0ac685c9eeb239c169726a8abf235e421 (Wed Jun 10 15:01:40 UTC 2020)
**Warnings:**
* **2 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-17327).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12589: [FLINK-17327] Fix Kafka Producer Resource Leaks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12589:
URL: https://github.com/apache/flink/pull/12589#issuecomment-642078835
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3201",
"triggerID" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"triggerType" : "PUSH"
}, {
"hash" : "d94219e43b9ec7087a1d87aae6cbef395fa9862c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3252",
"triggerID" : "d94219e43b9ec7087a1d87aae6cbef395fa9862c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f487b7e0ac685c9eeb239c169726a8abf235e421 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3201)
* d94219e43b9ec7087a1d87aae6cbef395fa9862c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3252)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12589: [FLINK-17327] Fix Kafka Producer Resource Leaks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12589:
URL: https://github.com/apache/flink/pull/12589#issuecomment-642078835
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3201",
"triggerID" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f487b7e0ac685c9eeb239c169726a8abf235e421 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3201)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #12589: [FLINK-17327] Fix Kafka Producer Resource Leaks
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #12589:
URL: https://github.com/apache/flink/pull/12589#issuecomment-642559128
@becketqin I pushed changes, please take another look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12589: [FLINK-17327] Fix Kafka Producer Resource Leaks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12589:
URL: https://github.com/apache/flink/pull/12589#issuecomment-642078835
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3201",
"triggerID" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"triggerType" : "PUSH"
}, {
"hash" : "d94219e43b9ec7087a1d87aae6cbef395fa9862c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3252",
"triggerID" : "d94219e43b9ec7087a1d87aae6cbef395fa9862c",
"triggerType" : "PUSH"
}, {
"hash" : "7b046578a4dcdf41f971409b4e3d5c409ad27316",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3277",
"triggerID" : "7b046578a4dcdf41f971409b4e3d5c409ad27316",
"triggerType" : "PUSH"
}, {
"hash" : "4dcc3252561499a444be7c76fd8ef6edb6547211",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3285",
"triggerID" : "4dcc3252561499a444be7c76fd8ef6edb6547211",
"triggerType" : "PUSH"
}, {
"hash" : "5f3e78794bce9be9960e6bb444d77d748267cd05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3331",
"triggerID" : "5f3e78794bce9be9960e6bb444d77d748267cd05",
"triggerType" : "PUSH"
}, {
"hash" : "9f1c9e9085c8e5ec4ed84d2b54d6e4ffb6c6095e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3389",
"triggerID" : "9f1c9e9085c8e5ec4ed84d2b54d6e4ffb6c6095e",
"triggerType" : "PUSH"
}, {
"hash" : "0cd1604b7e3ae2382235c61c8e1a246eb3f584e1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3417",
"triggerID" : "0cd1604b7e3ae2382235c61c8e1a246eb3f584e1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9f1c9e9085c8e5ec4ed84d2b54d6e4ffb6c6095e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3389)
* 0cd1604b7e3ae2382235c61c8e1a246eb3f584e1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3417)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12589: [FLINK-17327] Fix Kafka Producer Resource Leaks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12589:
URL: https://github.com/apache/flink/pull/12589#issuecomment-642078835
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3201",
"triggerID" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"triggerType" : "PUSH"
}, {
"hash" : "d94219e43b9ec7087a1d87aae6cbef395fa9862c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3252",
"triggerID" : "d94219e43b9ec7087a1d87aae6cbef395fa9862c",
"triggerType" : "PUSH"
}, {
"hash" : "7b046578a4dcdf41f971409b4e3d5c409ad27316",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3277",
"triggerID" : "7b046578a4dcdf41f971409b4e3d5c409ad27316",
"triggerType" : "PUSH"
}, {
"hash" : "4dcc3252561499a444be7c76fd8ef6edb6547211",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3285",
"triggerID" : "4dcc3252561499a444be7c76fd8ef6edb6547211",
"triggerType" : "PUSH"
}, {
"hash" : "5f3e78794bce9be9960e6bb444d77d748267cd05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3331",
"triggerID" : "5f3e78794bce9be9960e6bb444d77d748267cd05",
"triggerType" : "PUSH"
}, {
"hash" : "9f1c9e9085c8e5ec4ed84d2b54d6e4ffb6c6095e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3389",
"triggerID" : "9f1c9e9085c8e5ec4ed84d2b54d6e4ffb6c6095e",
"triggerType" : "PUSH"
}, {
"hash" : "0cd1604b7e3ae2382235c61c8e1a246eb3f584e1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3417",
"triggerID" : "0cd1604b7e3ae2382235c61c8e1a246eb3f584e1",
"triggerType" : "PUSH"
}, {
"hash" : "2dfedf8984c25e6bc3f54367d0e8715f1893ad42",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2dfedf8984c25e6bc3f54367d0e8715f1893ad42",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0cd1604b7e3ae2382235c61c8e1a246eb3f584e1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3417)
* 2dfedf8984c25e6bc3f54367d0e8715f1893ad42 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12589: [FLINK-17327] Fix Kafka Producer Resource Leaks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12589:
URL: https://github.com/apache/flink/pull/12589#issuecomment-642078835
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3201",
"triggerID" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"triggerType" : "PUSH"
}, {
"hash" : "d94219e43b9ec7087a1d87aae6cbef395fa9862c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3252",
"triggerID" : "d94219e43b9ec7087a1d87aae6cbef395fa9862c",
"triggerType" : "PUSH"
}, {
"hash" : "7b046578a4dcdf41f971409b4e3d5c409ad27316",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3277",
"triggerID" : "7b046578a4dcdf41f971409b4e3d5c409ad27316",
"triggerType" : "PUSH"
}, {
"hash" : "4dcc3252561499a444be7c76fd8ef6edb6547211",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3285",
"triggerID" : "4dcc3252561499a444be7c76fd8ef6edb6547211",
"triggerType" : "PUSH"
}, {
"hash" : "5f3e78794bce9be9960e6bb444d77d748267cd05",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3331",
"triggerID" : "5f3e78794bce9be9960e6bb444d77d748267cd05",
"triggerType" : "PUSH"
}, {
"hash" : "9f1c9e9085c8e5ec4ed84d2b54d6e4ffb6c6095e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9f1c9e9085c8e5ec4ed84d2b54d6e4ffb6c6095e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f3e78794bce9be9960e6bb444d77d748267cd05 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3331)
* 9f1c9e9085c8e5ec4ed84d2b54d6e4ffb6c6095e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12589: [FLINK-17327] Fix Kafka Producer Resource Leaks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12589:
URL: https://github.com/apache/flink/pull/12589#issuecomment-642078835
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3201",
"triggerID" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"triggerType" : "PUSH"
}, {
"hash" : "d94219e43b9ec7087a1d87aae6cbef395fa9862c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3252",
"triggerID" : "d94219e43b9ec7087a1d87aae6cbef395fa9862c",
"triggerType" : "PUSH"
}, {
"hash" : "7b046578a4dcdf41f971409b4e3d5c409ad27316",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3277",
"triggerID" : "7b046578a4dcdf41f971409b4e3d5c409ad27316",
"triggerType" : "PUSH"
}, {
"hash" : "4dcc3252561499a444be7c76fd8ef6edb6547211",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4dcc3252561499a444be7c76fd8ef6edb6547211",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d94219e43b9ec7087a1d87aae6cbef395fa9862c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3252)
* 7b046578a4dcdf41f971409b4e3d5c409ad27316 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3277)
* 4dcc3252561499a444be7c76fd8ef6edb6547211 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12589: [FLINK-17327] Fix Kafka Producer Resource Leaks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12589:
URL: https://github.com/apache/flink/pull/12589#issuecomment-642078835
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3201",
"triggerID" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"triggerType" : "PUSH"
}, {
"hash" : "d94219e43b9ec7087a1d87aae6cbef395fa9862c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3252",
"triggerID" : "d94219e43b9ec7087a1d87aae6cbef395fa9862c",
"triggerType" : "PUSH"
}, {
"hash" : "7b046578a4dcdf41f971409b4e3d5c409ad27316",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3277",
"triggerID" : "7b046578a4dcdf41f971409b4e3d5c409ad27316",
"triggerType" : "PUSH"
}, {
"hash" : "4dcc3252561499a444be7c76fd8ef6edb6547211",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3285",
"triggerID" : "4dcc3252561499a444be7c76fd8ef6edb6547211",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d94219e43b9ec7087a1d87aae6cbef395fa9862c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3252)
* 7b046578a4dcdf41f971409b4e3d5c409ad27316 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3277)
* 4dcc3252561499a444be7c76fd8ef6edb6547211 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3285)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12589: [FLINK-17327] Fix Kafka Producer Resource Leaks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12589:
URL: https://github.com/apache/flink/pull/12589#issuecomment-642078835
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3201",
"triggerID" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f487b7e0ac685c9eeb239c169726a8abf235e421 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3201)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #12589: [FLINK-17327] Fix Kafka Producer Resource Leaks
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #12589:
URL: https://github.com/apache/flink/pull/12589#issuecomment-644564287
Note: The CI build for this PR was not passing.
In the Azure UI, you can "Toggle Timestamps" next to the "View Raw Log" button. You'll then see that the test stalls for over 20 minutes until the VM gets killed
```
2020-06-15T12:56:54.0056633Z [INFO] Running org.apache.flink.tests.util.kafka.StreamingKafkaITCase
2020-06-15T13:23:53.9144859Z ##[error]The operation was canceled.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12589: [FLINK-17327] Fix Kafka Producer Resource Leaks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12589:
URL: https://github.com/apache/flink/pull/12589#issuecomment-642078835
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3201",
"triggerID" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"triggerType" : "PUSH"
}, {
"hash" : "d94219e43b9ec7087a1d87aae6cbef395fa9862c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3252",
"triggerID" : "d94219e43b9ec7087a1d87aae6cbef395fa9862c",
"triggerType" : "PUSH"
}, {
"hash" : "7b046578a4dcdf41f971409b4e3d5c409ad27316",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3277",
"triggerID" : "7b046578a4dcdf41f971409b4e3d5c409ad27316",
"triggerType" : "PUSH"
}, {
"hash" : "4dcc3252561499a444be7c76fd8ef6edb6547211",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3285",
"triggerID" : "4dcc3252561499a444be7c76fd8ef6edb6547211",
"triggerType" : "PUSH"
}, {
"hash" : "5f3e78794bce9be9960e6bb444d77d748267cd05",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3331",
"triggerID" : "5f3e78794bce9be9960e6bb444d77d748267cd05",
"triggerType" : "PUSH"
}, {
"hash" : "9f1c9e9085c8e5ec4ed84d2b54d6e4ffb6c6095e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3389",
"triggerID" : "9f1c9e9085c8e5ec4ed84d2b54d6e4ffb6c6095e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f3e78794bce9be9960e6bb444d77d748267cd05 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3331)
* 9f1c9e9085c8e5ec4ed84d2b54d6e4ffb6c6095e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3389)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12589: [FLINK-17327] Fix Kafka Producer Resource Leaks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12589:
URL: https://github.com/apache/flink/pull/12589#issuecomment-642078835
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3201",
"triggerID" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"triggerType" : "PUSH"
}, {
"hash" : "d94219e43b9ec7087a1d87aae6cbef395fa9862c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3252",
"triggerID" : "d94219e43b9ec7087a1d87aae6cbef395fa9862c",
"triggerType" : "PUSH"
}, {
"hash" : "7b046578a4dcdf41f971409b4e3d5c409ad27316",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3277",
"triggerID" : "7b046578a4dcdf41f971409b4e3d5c409ad27316",
"triggerType" : "PUSH"
}, {
"hash" : "4dcc3252561499a444be7c76fd8ef6edb6547211",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3285",
"triggerID" : "4dcc3252561499a444be7c76fd8ef6edb6547211",
"triggerType" : "PUSH"
}, {
"hash" : "5f3e78794bce9be9960e6bb444d77d748267cd05",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3331",
"triggerID" : "5f3e78794bce9be9960e6bb444d77d748267cd05",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f3e78794bce9be9960e6bb444d77d748267cd05 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3331)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] becketqin commented on a change in pull request #12589: [FLINK-17327] Fix Kafka Producer Resource Leaks
Posted by GitBox <gi...@apache.org>.
becketqin commented on a change in pull request #12589:
URL: https://github.com/apache/flink/pull/12589#discussion_r439159451
##########
File path: flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/statemachine/kafka/KafkaStandaloneGenerator.java
##########
@@ -90,7 +91,7 @@ public void collect(Event evt) {
@Override
public void close() {
- producer.close();
+ producer.close(Duration.ofSeconds(0));
Review comment:
Should we also flush the producer here?
##########
File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer.java
##########
@@ -1182,7 +1208,7 @@ int getTransactionCoordinatorId() {
private void recycleTransactionalProducer(FlinkKafkaInternalProducer<byte[], byte[]> producer) {
availableTransactionalIds.add(producer.getTransactionalId());
- producer.close();
+ producer.close(Duration.ofSeconds(0));
Review comment:
Can we also flush the producer here? It probably does not matter at this point because this method is invoked either after committing or aborting transactions, but I just want to be safe here in case this method is called in other places in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12589: [FLINK-17327] Fix Kafka Producer Resource Leaks
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12589:
URL: https://github.com/apache/flink/pull/12589#issuecomment-642078835
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3201",
"triggerID" : "f487b7e0ac685c9eeb239c169726a8abf235e421",
"triggerType" : "PUSH"
}, {
"hash" : "d94219e43b9ec7087a1d87aae6cbef395fa9862c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3252",
"triggerID" : "d94219e43b9ec7087a1d87aae6cbef395fa9862c",
"triggerType" : "PUSH"
}, {
"hash" : "7b046578a4dcdf41f971409b4e3d5c409ad27316",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3277",
"triggerID" : "7b046578a4dcdf41f971409b4e3d5c409ad27316",
"triggerType" : "PUSH"
}, {
"hash" : "4dcc3252561499a444be7c76fd8ef6edb6547211",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3285",
"triggerID" : "4dcc3252561499a444be7c76fd8ef6edb6547211",
"triggerType" : "PUSH"
}, {
"hash" : "5f3e78794bce9be9960e6bb444d77d748267cd05",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5f3e78794bce9be9960e6bb444d77d748267cd05",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4dcc3252561499a444be7c76fd8ef6edb6547211 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3285)
* 5f3e78794bce9be9960e6bb444d77d748267cd05 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on a change in pull request #12589: [FLINK-17327] Fix Kafka Producer Resource Leaks
Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #12589:
URL: https://github.com/apache/flink/pull/12589#discussion_r438691884
##########
File path: flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011.java
##########
@@ -675,7 +676,7 @@ public void close() throws FlinkKafka011Exception {
break;
case AT_LEAST_ONCE:
case NONE:
- currentTransaction.producer.close();
+ currentTransaction.producer.close(0, TimeUnit.SECONDS);
Review comment:
Good catch! I'll change it to always flush here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org