You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2018/06/16 06:29:17 UTC
[GitHub] emilianbold commented on issue #593: [NETBEANS-837] Update winp to
released 1.26 version and fix license
emilianbold commented on issue #593: [NETBEANS-837] Update winp to released 1.26 version and fix license
URL: https://github.com/apache/incubator-netbeans/pull/593#issuecomment-397791021
Yes, of course, it's good to use upstream versions and only patch if necessary.
The history of the patch is convoluted.
It seems to me that initially it added the DDL_TARGET system property: https://github.com/emilianbold/netbeans-releases/commit/96cb331b988290db870e35450f5fcec0cdf6d74f#diff-ac12f5b0fbc0ffeb077ce213ec649449
And this is something winp still has: https://github.com/kohsuke/winp/blob/master/src/main/java/org/jvnet/winp/Native.java#L147
But then they had a memory leak https://netbeans.org/bugzilla/show_bug.cgi?id=180915 so they got rid of that system property and expressly ignore it: https://github.com/emilianbold/netbeans-releases/commit/77d8d691e17a546d2080b4a9e854f5240aff1431#diff-ac12f5b0fbc0ffeb077ce213ec649449
Now, I suspect that we might still get memory leaks with the current winp?
Maybe we have to clear the system property before calling winp?
We would need to test this on Windows before using the upstream version, see if #180915 still holds.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists