[GitHub] [activemq-artemis] gemmellr commented on pull request #4418: ARTEMIS-4206 Dealing with Large Message Issues / duplicate deliveries / messages hanging on folder

["gemmellr (via GitHub)" <gi...@apache.org>]

gemmellr commented on PR #4418:
URL: https://github.com/apache/activemq-artemis/pull/4418#issuecomment-1498768874

   > I can squash 2 commits in one for two different and related issues. I thought it was better to keep separated.
   
   No, lets not squash 'different changes' into one commit (yes I saw, its too late), lets keep different changes separate. In that spirit, the original comment was around lets also try not to make different changes entirely reliant on each other anyway by intertwining and overlapping their multiple commits, such that you cant very simply pick or see the effect of one of the different changes in isolation because the commits were mixed together rather than sequential while adding.
   
   Aside, on the squashed commit log message, it starts telling you how to enable the ref counting debug, and then also ends telling you how to enable the ref counting debug but in a less clear way. Seems like one of them could go.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org