You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by GitBox <gi...@apache.org> on 2022/05/16 16:14:52 UTC

[GitHub] [directory-studio] roubert opened a new pull request, #33: DIRSTUDIO-1298: Fix the Postal Address value editor en-/decoding.

roubert opened a new pull request, #33:
URL: https://github.com/apache/directory-studio/pull/33

   This builds on the changes made for DIRSTUDIO-1296 to give the value editor complete and correct en-/decoding of the RFC 4517 Postal Address syntax.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org

[GitHub] [directory-studio] roubert commented on pull request #33: DIRSTUDIO-1298: Fix the Postal Address value editor en-/decoding.

Posted by GitBox <gi...@apache.org>.
roubert commented on PR #33:
URL: https://github.com/apache/directory-studio/pull/33#issuecomment-1138430436

   Maybe we could merge this now when you have integration tests pending?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org

[GitHub] [directory-studio] roubert commented on pull request #33: DIRSTUDIO-1298: Fix the Postal Address value editor en-/decoding.

Posted by GitBox <gi...@apache.org>.
roubert commented on PR #33:
URL: https://github.com/apache/directory-studio/pull/33#issuecomment-1127869818

   It would (of course) be nice to have an integration test also for the `AddressDialog`, but as far as I can tell there aren't any existing tests for those dialogs and I fear that writing one from scratch myself would be beyond my capabilities.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org

[GitHub] [directory-studio] seelmann merged pull request #33: DIRSTUDIO-1298: Fix the Postal Address value editor en-/decoding.

Posted by GitBox <gi...@apache.org>.
seelmann merged PR #33:
URL: https://github.com/apache/directory-studio/pull/33


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org

[GitHub] [directory-studio] seelmann commented on pull request #33: DIRSTUDIO-1298: Fix the Postal Address value editor en-/decoding.

Posted by GitBox <gi...@apache.org>.
seelmann commented on PR #33:
URL: https://github.com/apache/directory-studio/pull/33#issuecomment-1128453433

   > It would (of course) be nice to have an integration test also for the `AddressDialog`, but as far as I can tell there aren't any existing tests for those dialogs
   
   I created a test, please adjust as needed: https://github.com/apache/directory-studio/pull/34
   
   > I fear that writing one from scratch myself would be beyond my capabilities.
   
   I have to disagree :)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org

[GitHub] [directory-studio] seelmann commented on pull request #33: DIRSTUDIO-1298: Fix the Postal Address value editor en-/decoding.

Posted by GitBox <gi...@apache.org>.
seelmann commented on PR #33:
URL: https://github.com/apache/directory-studio/pull/33#issuecomment-1153226030

   Adapted the tests: https://github.com/apache/directory-studio/pull/38


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org