You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/06/14 11:28:49 UTC
[GitHub] [apisix] dickens7 opened a new issue, #7251: bug: skywalking-logger and error-log-logger plugin service_instance_name set $hostname invalid
dickens7 opened a new issue, #7251:
URL: https://github.com/apache/apisix/issues/7251
### Current Behavior
skywalking-logger and error-log-logger plugins set service_instance_name to `$hostname` and report to skywalking
instance is represented as `"$hostname"`string
### Expected Behavior
Expect service instances to be a string of $hostname instead of "$hostname" after reporting to Skywalking
### Error Logs
no error logs
### Steps to Reproduce
We can refer to the skywalking plugin processing method
https://github.com/apache/apisix/blob/master/apisix/plugins/skywalking.lua#L130-L132
### Environment
- APISIX version (run `apisix version`): 2.13.1
- Operating system (run `uname -a`): Linux apisix-844457679-8242t 5.10.102.1-microsoft-standard-WSL2+ #1 SMP Mon Jun 13 04:56:19 UTC 2022 x86_64 Linux
- OpenResty / Nginx version (run `openresty -V` or `nginx -V`): openresty/1.19.9.1
- etcd version, if relevant (run `curl http://127.0.0.1:9090/v1/server_info`):
- APISIX Dashboard version, if relevant:
- Plugin runner version, for issues related to plugin runners:
- LuaRocks version, for installation issues (run `luarocks --version`):
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] dickens7 commented on issue #7251: request help: skywalking-logger and error-log-logger plugin service_instance_name set $hostname invalid
Posted by GitBox <gi...@apache.org>.
dickens7 commented on issue #7251:
URL: https://github.com/apache/apisix/issues/7251#issuecomment-1155388090
assign me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander closed issue #7251: request help: skywalking-logger and error-log-logger plugin service_instance_name set $hostname invalid
Posted by GitBox <gi...@apache.org>.
spacewander closed issue #7251: request help: skywalking-logger and error-log-logger plugin service_instance_name set $hostname invalid
URL: https://github.com/apache/apisix/issues/7251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #7251: request help: skywalking-logger and error-log-logger plugin service_instance_name set $hostname invalid
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on issue #7251:
URL: https://github.com/apache/apisix/issues/7251#issuecomment-1155365241
It was originally designed that way, but I think it's a good idea.
@dickens7 PR is welcome!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org