You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2021/11/12 00:58:40 UTC
[GitHub] [daffodil-vscode] Shanedell opened a new pull request #49: Launch Config Wizard
Shanedell opened a new pull request #49:
URL: https://github.com/apache/daffodil-vscode/pull/49
Create launch.json config wizard:
- Create new command called launch.config
- When command is ran the user will go through a selection process to set all variables for the launch.json
- Add an icon for running the new command to the toolbar (gear icon)
- Once all items are selected by the user the .vscode/launch.json will be created
Closes #38
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on pull request #49: Launch Config Wizard
Posted by GitBox <gi...@apache.org>.
Shanedell commented on pull request #49:
URL: https://github.com/apache/daffodil-vscode/pull/49#issuecomment-975542610
I mostly need to do the updating of the launch.json and it will be good to go
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] jw3 commented on pull request #49: Launch Config Wizard
Posted by GitBox <gi...@apache.org>.
jw3 commented on pull request #49:
URL: https://github.com/apache/daffodil-vscode/pull/49#issuecomment-968062828
> ... and text fields
Nothing special in mind here, just a file picker with path display.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell edited a comment on pull request #49: Launch Config Wizard
Posted by GitBox <gi...@apache.org>.
Shanedell edited a comment on pull request #49:
URL: https://github.com/apache/daffodil-vscode/pull/49#issuecomment-973613992
@mbeckerle @stevedlawrence @jw3
So for this PR I am thinking we keep it where is at now which is making a entry inside of the Settings of Visual Studio Code and pull down the default values from that config if the file `.vscode/launch.json` is not available. I think this will work better instead of remaking those default values inside of the code in different areas.
Then after this one is merged I have an idea of how to make a GUI wizard for making the launch.json using a WebView panel.
So if this works for you guys I can remove the closing of 38 from the description as well as update the description and work on GUI wizard in a different PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell edited a comment on pull request #49: Launch Config Wizard
Posted by GitBox <gi...@apache.org>.
Shanedell edited a comment on pull request #49:
URL: https://github.com/apache/daffodil-vscode/pull/49#issuecomment-973613992
@mbeckerle @stevedlawrence @jw3
So for this PR I am thinking we keep it where is at now which is making a entry inside of the Settings of Visual Studio Code and pull down the default values from that config if the file `.vscode/launch.json` is not available. I think this will work better instead of remaking those default values inside of the code in different areas.
Then after this one is merged I have an idea of how to make a GUI wizard for making the launch.json using a WebView panel.
If this would be the way to go I can remove the closing of 38 from the description as well as update the description and work on GUI wizard in a different PR.
The other option is a just throw in the code for GUI wizard inside of this PR, either one works fine just wanted to check before doing anything
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] jw3 commented on pull request #49: Launch Config Wizard
Posted by GitBox <gi...@apache.org>.
jw3 commented on pull request #49:
URL: https://github.com/apache/daffodil-vscode/pull/49#issuecomment-975521943
Nice :+1: So what's it look like when you have multiple launch configurations?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on pull request #49: Launch Config Wizard
Posted by GitBox <gi...@apache.org>.
Shanedell commented on pull request #49:
URL: https://github.com/apache/daffodil-vscode/pull/49#issuecomment-982908976
From the most recent commit it utilized option 2, if 1 is desired more I can easily make that update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on pull request #49: Launch Config Wizard
Posted by GitBox <gi...@apache.org>.
Shanedell commented on pull request #49:
URL: https://github.com/apache/daffodil-vscode/pull/49#issuecomment-969029350
Oh okay so you mean making a new item in the `Extensions` dropdown for `Daffodil Debugger` where you can set all the properties and it doesn't need to create a new folder and file inside of the workspace it just uses the global settings file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] jw3 commented on a change in pull request #49: Launch Config Wizard
Posted by GitBox <gi...@apache.org>.
jw3 commented on a change in pull request #49:
URL: https://github.com/apache/daffodil-vscode/pull/49#discussion_r761435778
##########
File path: src/adapter/activateDaffodilDebug.ts
##########
@@ -291,21 +286,29 @@ class DaffodilConfigurationProvider
): ProviderResult<DebugConfiguration> {
// if launch.json is missing or empty
if (!config.type && !config.request && !config.name) {
- const editor = vscode.window.activeTextEditor
- if (editor && editor.document.languageId === 'xml') {
- config.type = 'dfdl'
- config.name = 'Launch'
- config.request = 'launch'
- config.program = '${file}'
- config.data = '${command:AskForDataName}'
- config.stopOnEntry = true
- config.useExistingServer = false
- config.infosetOutput = {
- type: 'file',
- path: '${file}-infoset.xml',
- }
- config.debugServer = 4711
- }
+ config = getConfig('Launch', 'launch', 'dfdl')
+ // config.type = 'dfdl'
Review comment:
can this commented out code be removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on pull request #49: Launch Config Wizard
Posted by GitBox <gi...@apache.org>.
Shanedell commented on pull request #49:
URL: https://github.com/apache/daffodil-vscode/pull/49#issuecomment-982826722
@jw3 Which would be preferred one or two?
1.) Same layout for `Name` as before but whenever the dropdown selection is not `New Config` the input box is invisible, when selected will appears.
Not Selected:
Selected:
2.) When `New Config` is selected a label with text box beside it appears?
Not Selected:
Selected:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on pull request #49: Launch Config Wizard
Posted by GitBox <gi...@apache.org>.
Shanedell commented on pull request #49:
URL: https://github.com/apache/daffodil-vscode/pull/49#issuecomment-969017366
Oh I think I see what you are saying.
So a panel that will:
- Show all the different variables that can be set, with their default value in parenthesis like `debugServer (default: 4711)`
- When the user clicks on one of the panel options it will bring up the proper input type to select the item
- Once input is retrieved the panel will be updated with that value
- Once the user clicks `OK` or `Save` on the panel it will create the `.vscode/launch.json`
Was this similar to what you were thinking @jw3 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on pull request #49: Launch Config Wizard
Posted by GitBox <gi...@apache.org>.
Shanedell commented on pull request #49:
URL: https://github.com/apache/daffodil-vscode/pull/49#issuecomment-973613992
@mbeckerle @stevedlawrence @jw3
So for this PR I am thinking we keep it where is at now which is making a entry inside of the Settings of Visual Studio Code and pull down the default values from that config if the file `.vscode/launch.json` is not available. I think this will work better instead of remaking those default values inside of the code in different areas.
Then after this one is merged I have an idea of how to GUI wizard for making the launch.json using a WebView panel.
So if this works for you guys I can remove the closing of 38 from the description and work on GUI wizard in a different PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] jw3 commented on pull request #49: Launch Config Wizard
Posted by GitBox <gi...@apache.org>.
jw3 commented on pull request #49:
URL: https://github.com/apache/daffodil-vscode/pull/49#issuecomment-984970369
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] jw3 commented on pull request #49: Launch Config Wizard
Posted by GitBox <gi...@apache.org>.
jw3 commented on pull request #49:
URL: https://github.com/apache/daffodil-vscode/pull/49#issuecomment-981911022
@Shanedell The GUI looks good but I think needs something for handling multiple configurations, it's going to be confusing otherwise.
Is there any way to add a simple list component to the editing screen, that lists all the configs from the launch.json and when a selection is made it changes what configuration is loaded in the editing view?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] jw3 commented on pull request #49: Launch Config Wizard
Posted by GitBox <gi...@apache.org>.
jw3 commented on pull request #49:
URL: https://github.com/apache/daffodil-vscode/pull/49#issuecomment-982594321
The drop down sounds like a good approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] jw3 commented on pull request #49: Launch Config Wizard
Posted by GitBox <gi...@apache.org>.
jw3 commented on pull request #49:
URL: https://github.com/apache/daffodil-vscode/pull/49#issuecomment-969026145
> When the user clicks on one of the panel options it will bring up the proper input type to select the item
I'm not sure about this statement. I am just thinking of standard UI components to configure each setting.
For an example in VS Code go to File -> Preferences -> Settings
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell edited a comment on pull request #49: Launch Config Wizard
Posted by GitBox <gi...@apache.org>.
Shanedell edited a comment on pull request #49:
URL: https://github.com/apache/daffodil-vscode/pull/49#issuecomment-975525451
So basically my idea was that if the save button is clicked if the `.vscode/lauch.json` does not exist it will be created. But if it does exist we will read in the file then append the new configuration to the list of configs. Once the list of configs is updated write the update back to the file, does that make sense?
Right now I hard code the name of the config but I can also make that something you can fill out on the UI for having multiple configs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on pull request #49: Launch Config Wizard
Posted by GitBox <gi...@apache.org>.
Shanedell commented on pull request #49:
URL: https://github.com/apache/daffodil-vscode/pull/49#issuecomment-975525451
So basically my idea was that if the save button is clicked if the `.vscode/lauch.json` does not exist it will be created. But if it does exist we will read in the file then append the new configuration to the list of configs. Once the list of configs is updated write the update back to the file, does that make sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] jw3 commented on pull request #49: Launch Config Wizard
Posted by GitBox <gi...@apache.org>.
jw3 commented on pull request #49:
URL: https://github.com/apache/daffodil-vscode/pull/49#issuecomment-983144532
I think you could leave the field be editable, but if you use the picker then it overwrites whatever was there. It is fine if someone wants to edit it after that, or instead of that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell edited a comment on pull request #49: Launch Config Wizard
Posted by GitBox <gi...@apache.org>.
Shanedell edited a comment on pull request #49:
URL: https://github.com/apache/daffodil-vscode/pull/49#issuecomment-981938770
@jw3 Yeah I think I could add something like a button that says `Edit Config` when selected instead of asking for a name it will be a dropdown will the configs listed in it?
Or a dropdown with the list of available configs already in the file then an entry for `New Item` if `New Item` is selected the Name text box will be enabled for naming the new config?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on pull request #49: Launch Config Wizard
Posted by GitBox <gi...@apache.org>.
Shanedell commented on pull request #49:
URL: https://github.com/apache/daffodil-vscode/pull/49#issuecomment-969210741
@jw3 something like this to give it a better visualization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] jw3 commented on pull request #49: Launch Config Wizard
Posted by GitBox <gi...@apache.org>.
jw3 commented on pull request #49:
URL: https://github.com/apache/daffodil-vscode/pull/49#issuecomment-968986324
Usually when you click on a settings button you get a panel with settings, then you click ok when done.
The way it is implemented now will probably be surprising to most users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] jw3 edited a comment on pull request #49: Launch Config Wizard
Posted by GitBox <gi...@apache.org>.
jw3 edited a comment on pull request #49:
URL: https://github.com/apache/daffodil-vscode/pull/49#issuecomment-975521943
Nice :+1: So what does it look like when you have multiple launch configurations?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] jw3 commented on pull request #49: Launch Config Wizard
Posted by GitBox <gi...@apache.org>.
jw3 commented on pull request #49:
URL: https://github.com/apache/daffodil-vscode/pull/49#issuecomment-975782394
Agree, this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on pull request #49: Launch Config Wizard
Posted by GitBox <gi...@apache.org>.
Shanedell commented on pull request #49:
URL: https://github.com/apache/daffodil-vscode/pull/49#issuecomment-975805095
@mbeckerle @jw3 I have added the code for the GUI and updated the PR description to accommodate the changes I have made.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on pull request #49: Launch Config Wizard
Posted by GitBox <gi...@apache.org>.
Shanedell commented on pull request #49:
URL: https://github.com/apache/daffodil-vscode/pull/49#issuecomment-983143317
Oh yeah I don't have the settings page update fields based on the selected config, that makes a lot of sense though I will fix that.
So instead of the input box able to be edited have a button beside it like `Browse` that opens a file browser and that updates the input box value with the path to file selected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] jw3 commented on pull request #49: Launch Config Wizard
Posted by GitBox <gi...@apache.org>.
jw3 commented on pull request #49:
URL: https://github.com/apache/daffodil-vscode/pull/49#issuecomment-982899563
I like 2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] jw3 edited a comment on pull request #49: Launch Config Wizard
Posted by GitBox <gi...@apache.org>.
jw3 edited a comment on pull request #49:
URL: https://github.com/apache/daffodil-vscode/pull/49#issuecomment-983144532
I think you could leave the field be editable, but if you use the picker then it overwrites whatever was there. It is fine if someone wants to edit it after picking a file, or instead of picking a file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on pull request #49: Launch Config Wizard
Posted by GitBox <gi...@apache.org>.
Shanedell commented on pull request #49:
URL: https://github.com/apache/daffodil-vscode/pull/49#issuecomment-983758070
@jw3
- Updated the webview to update values based on config selected
- Updated the way the input for the infoset output path shows
- Created a `Browse` button for the `Program` and `Data`
- When clicked will open a file picker and once file is selected the input box is updated
- Did not do this for others as they either weren't asking for a file or in the case of the path for infoset output I did as I assumed that may not exist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on a change in pull request #49: Launch Config Wizard
Posted by GitBox <gi...@apache.org>.
Shanedell commented on a change in pull request #49:
URL: https://github.com/apache/daffodil-vscode/pull/49#discussion_r761439065
##########
File path: src/adapter/activateDaffodilDebug.ts
##########
@@ -291,21 +286,29 @@ class DaffodilConfigurationProvider
): ProviderResult<DebugConfiguration> {
// if launch.json is missing or empty
if (!config.type && !config.request && !config.name) {
- const editor = vscode.window.activeTextEditor
- if (editor && editor.document.languageId === 'xml') {
- config.type = 'dfdl'
- config.name = 'Launch'
- config.request = 'launch'
- config.program = '${file}'
- config.data = '${command:AskForDataName}'
- config.stopOnEntry = true
- config.useExistingServer = false
- config.infosetOutput = {
- type: 'file',
- path: '${file}-infoset.xml',
- }
- config.debugServer = 4711
- }
+ config = getConfig('Launch', 'launch', 'dfdl')
+ // config.type = 'dfdl'
Review comment:
yes I completely forgot about it will remove it now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] jw3 commented on pull request #49: Launch Config Wizard
Posted by GitBox <gi...@apache.org>.
jw3 commented on pull request #49:
URL: https://github.com/apache/daffodil-vscode/pull/49#issuecomment-975533564
Yeah that all makes sense. How far away is the rough draft from being ready for PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on pull request #49: Launch Config Wizard
Posted by GitBox <gi...@apache.org>.
Shanedell commented on pull request #49:
URL: https://github.com/apache/daffodil-vscode/pull/49#issuecomment-975635108
@jw3 I have gotten the GUI working good and updating the configurations is working as well now. I also made it so that an exact duplicate config will not be added to the `launch.json`. When the config being saved is already in the `launch.config` the user will get an a warning message that says `The conf trying to be saved already exists in the launch.json`.
Do you think I should add this code to this PR as I based it off this branch or wait till this PR is merged to push up the code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on pull request #49: Launch Config Wizard
Posted by GitBox <gi...@apache.org>.
Shanedell commented on pull request #49:
URL: https://github.com/apache/daffodil-vscode/pull/49#issuecomment-975519573
@jw3 I do have a rough draft of a UI for the config wizard that I made based on this branch, I will post it here for comments about some items that may need changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] jw3 commented on pull request #49: Launch Config Wizard
Posted by GitBox <gi...@apache.org>.
jw3 commented on pull request #49:
URL: https://github.com/apache/daffodil-vscode/pull/49#issuecomment-967197520
Interesting approach, though I'm not sure this is more usable than editing the json by hand.
Do you have the ability to show a component that has these options in the form of check boxes and text fields?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] jw3 commented on pull request #49: Launch Config Wizard
Posted by GitBox <gi...@apache.org>.
jw3 commented on pull request #49:
URL: https://github.com/apache/daffodil-vscode/pull/49#issuecomment-969524311
Yeah I think that is pretty close.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on pull request #49: Launch Config Wizard
Posted by GitBox <gi...@apache.org>.
Shanedell commented on pull request #49:
URL: https://github.com/apache/daffodil-vscode/pull/49#issuecomment-968975970
@jw3 Is there a specific variable you are wanting this for?
As the `path` and `data` variables are already files pickers, I believe these do not show you the full path since you use the operating systems file explorer to chose the file.
I might not be understanding what you may be asking to be done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] jw3 merged pull request #49: Launch Config Wizard
Posted by GitBox <gi...@apache.org>.
jw3 merged pull request #49:
URL: https://github.com/apache/daffodil-vscode/pull/49
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on pull request #49: Launch Config Wizard
Posted by GitBox <gi...@apache.org>.
Shanedell commented on pull request #49:
URL: https://github.com/apache/daffodil-vscode/pull/49#issuecomment-981938770
@jw3 Yeah I think I could add something like a button that says `Edit Config` when selected instead of asking for a name it will be a dropdown will the configs listed in it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] jw3 commented on pull request #49: Launch Config Wizard
Posted by GitBox <gi...@apache.org>.
jw3 commented on pull request #49:
URL: https://github.com/apache/daffodil-vscode/pull/49#issuecomment-983133301
This looks close but the fields do not update when I select different values in from the drop down.
For example one config has `123` as the port another has `456`, when I select either of these the port remains `4711`.
Also for the infoset output type there needs to be a file path field when the `file` type is selected.
Would it be possible for all file path fields to have a file picker button that launches a file chooser?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] mbeckerle commented on pull request #49: Launch Config Wizard
Posted by GitBox <gi...@apache.org>.
mbeckerle commented on pull request #49:
URL: https://github.com/apache/daffodil-vscode/pull/49#issuecomment-975743680
My thought is that you should add it to the existing PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell edited a comment on pull request #49: Launch Config Wizard
Posted by GitBox <gi...@apache.org>.
Shanedell edited a comment on pull request #49:
URL: https://github.com/apache/daffodil-vscode/pull/49#issuecomment-975805095
@mbeckerle @jw3 I have added the code for the GUI and updated the PR description to accommodate the changes I have made. With a question about checking for duplicates
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] jw3 commented on pull request #49: Launch Config Wizard
Posted by GitBox <gi...@apache.org>.
jw3 commented on pull request #49:
URL: https://github.com/apache/daffodil-vscode/pull/49#issuecomment-975471128
> making a entry inside of the Settings of Visual Studio Code and pull down the default values from that config if the file .vscode/launch.json is not available
That sounds good. So we have these options
1. A `launch.json` is not required, the default launch config is available from the settings page
2. A `launch.json` can be created in which case it will be detected and used
This seems to take care of the simple case where a user just wants to run something the simplest way possible while allowing for the alternative case where someone wants multiple launch profiles with different options.
> Then after this one is merged I have an idea of how to make a GUI wizard for making the launch.json using a WebView panel.
Sounds good. I think it will be useful to see a UI tailored for this app and determine if that is a better fit than the settings page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org