You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by "gemmellr (via GitHub)" <gi...@apache.org> on 2023/05/03 10:37:50 UTC

[GitHub] [activemq-artemis] gemmellr commented on a diff in pull request #4435: ARTEMIS-4238 deprecate transactionTimeout activation config prop

gemmellr commented on code in PR #4435:
URL: https://github.com/apache/activemq-artemis/pull/4435#discussion_r1183517862


##########
artemis-ra/src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQActivationSpec.java:
##########
@@ -120,6 +120,7 @@ public class ActiveMQActivationSpec extends ConnectionFactoryProperties implemen
    /**
     * Transaction timeout
     */
+   @Deprecated

Review Comment:
   If it is deprecated for future removal as indicated in the documentation, should the Deprecated tag indicate that with the forRemoval flag?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org