[GitHub] [flink-kubernetes-operator] mxm commented on a diff in pull request #664: [FLINK-33027] Allow users to override parallelism of excluded vertices

["mxm (via GitHub)" <gi...@apache.org>]

mxm commented on code in PR #664:
URL: https://github.com/apache/flink-kubernetes-operator/pull/664#discussion_r1315650268


##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/JobAutoScaler.java:
##########
@@ -30,6 +28,6 @@ public interface JobAutoScaler {
     /** Called when the custom resource is deleted. */
     void cleanup(FlinkResourceContext<?> ctx);
 
-    /** Get the current parallelism overrides for the job. */
-    Map<String, String> getParallelismOverrides(FlinkResourceContext<?> ctx);
+    /** Apply current parallelism overrides. */
+    void applyParallelismOverrides(FlinkResourceContext<?> ctx);

Review Comment:
   Is this interface method really necessary? Overrides should be applied in the scale method, no?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org