[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #588: sim: add a pseudo netdev backed by vpnkit

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on a change in pull request #588: sim: add a pseudo netdev backed by vpnkit
URL: https://github.com/apache/incubator-nuttx/pull/588#discussion_r394932676
 
 

 ##########
 File path: arch/sim/src/sim/up_vpnkit.c
 ##########
 @@ -0,0 +1,259 @@
+/****************************************************************************
+ * arch/sim/src/sim/up_vpnkit.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.  The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <sys/types.h>
+#include <sys/un.h>
+
+/* XXX broken api: mixing nuttx and host in_addr_t */
+
+#include <netinet/in.h>
+
+#include <poll.h>
+#include <stdio.h>
+#include <string.h>
+#include <unistd.h>
+
+#include "vpnkit/protocol.h"
+
+/****************************************************************************
+ * Pre-processor Definitions
+ ****************************************************************************/
+
+#define ERROR(fmt, ...) \
+        fprintf(stderr, "up_vpnkit: " fmt "\n\r", ##__VA_ARGS__)
+#define INFO(fmt, ...) \
+        fprintf(stderr, "up_vpnkit: " fmt "\n\r", ##__VA_ARGS__)
+#define DEBUG(fmt, ...)
+
+/****************************************************************************
+ * Public Data
+ ****************************************************************************/
+
+const char *g_vpnkit_socket_path = "/tmp/vpnkit-nuttx"; /* XXX config */
+struct vif_info g_vifinfo;
+int g_vpnkit_fd = -1;
 
 Review comment:
   all can be static?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services