You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/01 00:42:49 UTC
[GitHub] [airflow] ShakaibKhan opened a new pull request #15123: check for zipped files in import rules for upgrade check
ShakaibKhan opened a new pull request #15123:
URL: https://github.com/apache/airflow/pull/15123
This addresses #15004
added zip file check for import rules of upgrade check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #15123: check for zipped files in import rules for upgrade check
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #15123:
URL: https://github.com/apache/airflow/pull/15123#issuecomment-811557830
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on a change in pull request #15123: check for zipped files in import rules for upgrade check
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on a change in pull request #15123:
URL: https://github.com/apache/airflow/pull/15123#discussion_r605430470
##########
File path: airflow/upgrade/rules/import_changes.py
##########
@@ -141,8 +141,9 @@ def _check_missing_providers(providers):
yield "Please install `{}`".format(dist_name)
def check(self):
- dag_folder = conf.get("core", "dags_folder")
- files = list_py_file_paths(directory=dag_folder, include_examples=False)
+ dags_folder = conf.get("core", "dags_folder")
+ dags_folder = correct_maybe_zipped(dags_folder)
+ files = list_py_file_paths(directory=dags_folder, include_examples=False)
files = [file for file in files if os.path.splitext(file)[1] == ".py"]
Review comment:
This change is not working, I tested with a zip file and it didn't work.
My suggestion is to work on the `files` variable, it contains all the files in the folder that has `.py` file in them. Both zipped files that has `.py` in them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #15123: check for zipped files in import rules for upgrade check
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #15123:
URL: https://github.com/apache/airflow/pull/15123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15123: check for zipped files in import rules for upgrade check
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15123:
URL: https://github.com/apache/airflow/pull/15123#issuecomment-845586854
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org