You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by hl...@apache.org on 2008/06/27 01:13:37 UTC
svn commit: r672054 - in
/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components:
Select.java Submit.java TextArea.java TextField.java
Author: hlship
Date: Thu Jun 26 16:13:37 2008
New Revision: 672054
URL: http://svn.apache.org/viewvc?rev=672054&view=rev
Log:
TAPESTRY-2484: Some built-in Tapestry components are final and should be extensible
Modified:
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Select.java
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Submit.java
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/TextArea.java
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/TextField.java
Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Select.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Select.java?rev=672054&r1=672053&r2=672054&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Select.java (original)
+++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Select.java Thu Jun 26 16:13:37 2008
@@ -42,7 +42,7 @@
* can be overriden by binding the encoder parameter, or extended by contributing a {@link ValueEncoderFactory} into the
* service's configuration.
*/
-public final class Select extends AbstractField
+public class Select extends AbstractField
{
private class Renderer extends SelectModelRenderer
{
Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Submit.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Submit.java?rev=672054&r1=672053&r2=672054&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Submit.java (original)
+++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Submit.java Thu Jun 26 16:13:37 2008
@@ -31,7 +31,7 @@
* submit responsible for the form submission will post a notification that allows the application to know that it was
* the responsible entity. The notification is named "selected" and has no context.
*/
-public final class Submit extends AbstractField
+public class Submit extends AbstractField
{
static final String SELECTED_EVENT = "selected";
Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/TextArea.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/TextArea.java?rev=672054&r1=672053&r2=672054&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/TextArea.java (original)
+++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/TextArea.java Thu Jun 26 16:13:37 2008
@@ -26,7 +26,7 @@
*
* @see org.apache.tapestry5.corelib.components.TextOutput
*/
-public final class TextArea extends AbstractTextField
+public class TextArea extends AbstractTextField
{
private String value;
Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/TextField.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/TextField.java?rev=672054&r1=672053&r2=672054&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/TextField.java (original)
+++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/TextField.java Thu Jun 26 16:13:37 2008
@@ -25,10 +25,10 @@
* Includes the <code>size</code> attribute, if a {@link org.apache.tapestry5.beaneditor.Width} annotation is present on
* the property bound to the value parameter.
*/
-public final class TextField extends AbstractTextField
+public class TextField extends AbstractTextField
{
@Override
- protected final void writeFieldTag(MarkupWriter writer, String value)
+ protected void writeFieldTag(MarkupWriter writer, String value)
{
writer.element("input",