You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@kudu.apache.org by "Yifan Zhang (Code Review)" <ge...@cloudera.org> on 2022/08/03 03:46:08 UTC

[kudu-CR] KUDU-3353 [schema] Add an immutable attribute on column schema (part 1)

Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18742 )

Change subject: KUDU-3353 [schema] Add an immutable attribute on column schema (part 1)
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18742/7//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18742/7//COMMIT_MSG@16
PS7, Line 16: UPDATE_IGNORE
We already have UPDATE_IGNORE operation, it ignores the operation if a key not found error occurs. So now this operation will ignore both 'key not found error' and 'update on immutable column error'? Should we seperate this these two different kind of IGNORE operations?



-- 
To view, visit http://gerrit.cloudera.org:8080/18742
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I01e5a806c0e873239b49e6d0b37a7e36578b508d
Gerrit-Change-Number: 18742
Gerrit-PatchSet: 7
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Wed, 03 Aug 2022 03:46:08 +0000
Gerrit-HasComments: Yes