You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2017/10/12 17:02:30 UTC

Review Request 62939: Document the Linux build requirements.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62939/
-----------------------------------------------------------

Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, and Jie Yu.


Bugs: MESOS-8027
    https://issues.apache.org/jira/browse/MESOS-8027


Repository: mesos


Description
-------

Since O_CLOEXEC was introduces in Linux 2.6.3, document that we require
at least this kernel version to build (and run) correctly.


Diffs
-----

  docs/getting-started.md 7496a10937e2119846e655c477707a30fa90b946 


Diff: https://reviews.apache.org/r/62939/diff/1/


Testing
-------

None.


Thanks,

James Peach

Re: Review Request 62939: Document the Linux build requirements.

Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62939/#review187817
-----------------------------------------------------------


Fix it, then Ship it!





docs/getting-started.md
Line 27 (original), 27 (patched)
<https://reviews.apache.org/r/62939/#comment264858>

    nit: let's fix the spacing around `>=` for `3.10`, i.e.
    
        ... recent kernel >= 3.10 ...


- Benjamin Bannier


On Oct. 12, 2017, 7:02 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62939/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2017, 7:02 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, and Jie Yu.
> 
> 
> Bugs: MESOS-8027
>     https://issues.apache.org/jira/browse/MESOS-8027
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Since O_CLOEXEC was introduces in Linux 2.6.3, document that we require
> at least this kernel version to build (and run) correctly.
> 
> 
> Diffs
> -----
> 
>   docs/getting-started.md 7496a10937e2119846e655c477707a30fa90b946 
> 
> 
> Diff: https://reviews.apache.org/r/62939/diff/1/
> 
> 
> Testing
> -------
> 
> None.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 62939: Document the Linux build requirements.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62939/#review187853
-----------------------------------------------------------



FAIL: Failed to apply the dependent review: 62638.

Failed command: `python.exe .\support\apply-reviews.py -n -r 62638`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62939

Relevant logs:

- [apply-review-62638-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62939/logs/apply-review-62638-stdout.log):

```
error: patch failed: 3rdparty/stout/include/stout/os/open.hpp:23
error: 3rdparty/stout/include/stout/os/open.hpp: patch does not apply
error: patch failed: 3rdparty/stout/include/stout/os/windows/fcntl.hpp:22
error: 3rdparty/stout/include/stout/os/windows/fcntl.hpp: patch does not apply
error: patch failed: 3rdparty/stout/include/stout/windows.hpp:165
error: 3rdparty/stout/include/stout/windows.hpp: patch does not apply
```

- Mesos Reviewbot Windows


On Oct. 12, 2017, 5:12 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62939/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2017, 5:12 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, and Jie Yu.
> 
> 
> Bugs: MESOS-8027
>     https://issues.apache.org/jira/browse/MESOS-8027
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Since O_CLOEXEC was introduces in Linux 2.6.3, document that we require
> at least this kernel version to build (and run) correctly.
> 
> 
> Diffs
> -----
> 
>   docs/getting-started.md 7496a10937e2119846e655c477707a30fa90b946 
> 
> 
> Diff: https://reviews.apache.org/r/62939/diff/2/
> 
> 
> Testing
> -------
> 
> None.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 62939: Document the Linux build requirements.

Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62939/
-----------------------------------------------------------

(Updated Oct. 12, 2017, 5:12 p.m.)


Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, and Jie Yu.


Bugs: MESOS-8027
    https://issues.apache.org/jira/browse/MESOS-8027


Repository: mesos


Description
-------

Since O_CLOEXEC was introduces in Linux 2.6.3, document that we require
at least this kernel version to build (and run) correctly.


Diffs (updated)
-----

  docs/getting-started.md 7496a10937e2119846e655c477707a30fa90b946 


Diff: https://reviews.apache.org/r/62939/diff/2/

Changes: https://reviews.apache.org/r/62939/diff/1-2/


Testing
-------

None.


Thanks,

James Peach