You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "Fine0830 (via GitHub)" <gi...@apache.org> on 2023/03/28 11:01:35 UTC
[GitHub] [skywalking-booster-ui] Fine0830 opened a new pull request, #250: feat: update trace profiling protocol
Fine0830 opened a new pull request, #250:
URL: https://github.com/apache/skywalking-booster-ui/pull/250
Reference https://github.com/apache/skywalking-query-protocol/pull/111
Video
https://user-images.githubusercontent.com/20871783/228215542-f849c779-001e-4601-adc5-1317ebd11d53.mov
Signed-off-by: Qiuxia Fan <qi...@apache.org>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] Fine0830 commented on pull request #250: feat: update trace profiling protocol
Posted by "Fine0830 (via GitHub)" <gi...@apache.org>.
Fine0830 commented on PR #250:
URL: https://github.com/apache/skywalking-booster-ui/pull/250#issuecomment-1488031815
Are there any further questions? @mrproliu @wu-sheng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] Fine0830 commented on pull request #250: feat: update trace profiling protocol
Posted by "Fine0830 (via GitHub)" <gi...@apache.org>.
Fine0830 commented on PR #250:
URL: https://github.com/apache/skywalking-booster-ui/pull/250#issuecomment-1489482870
> Let's add the icons to the `List` view of the trace too. It should be helpful
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] Fine0830 commented on pull request #250: feat: update trace profiling protocol
Posted by "Fine0830 (via GitHub)" <gi...@apache.org>.
Fine0830 commented on PR #250:
URL: https://github.com/apache/skywalking-booster-ui/pull/250#issuecomment-1486881519
What is the condition of un-profiled span? @mrproliu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] mrproliu commented on pull request #250: feat: update trace profiling protocol
Posted by "mrproliu (via GitHub)" <gi...@apache.org>.
mrproliu commented on PR #250:
URL: https://github.com/apache/skywalking-booster-ui/pull/250#issuecomment-1486725501
Could you provide an image when the span cannot be profiled?
We do not have a multi-segment situation in the current demo environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] wu-sheng commented on pull request #250: feat: update trace profiling protocol
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #250:
URL: https://github.com/apache/skywalking-booster-ui/pull/250#issuecomment-1488033227
I had a discussion with @mrproliu. He will forward the conclusion to you soon, I think. :)
There are some polish requirements at here and trace page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] wu-sheng merged pull request #250: feat: update trace profiling protocol
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #250:
URL: https://github.com/apache/skywalking-booster-ui/pull/250
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] Fine0830 commented on pull request #250: feat: update trace profiling protocol
Posted by "Fine0830 (via GitHub)" <gi...@apache.org>.
Fine0830 commented on PR #250:
URL: https://github.com/apache/skywalking-booster-ui/pull/250#issuecomment-1487933812
Add a tip for un-profiled spans.
https://user-images.githubusercontent.com/20871783/228427875-5cbc3f07-2e25-4e23-94ea-88bf6631777d.mov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] wu-sheng commented on pull request #250: feat: update trace profiling protocol
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #250:
URL: https://github.com/apache/skywalking-booster-ui/pull/250#issuecomment-1487979241
@mrproliu Is `undertow` the un-profilied span? I thought we have it profiled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] mrproliu commented on pull request #250: feat: update trace profiling protocol
Posted by "mrproliu (via GitHub)" <gi...@apache.org>.
mrproliu commented on PR #250:
URL: https://github.com/apache/skywalking-booster-ui/pull/250#issuecomment-1486863754
For now, I just check it locally. Tomorrow, I will change the "songs" service to use Undertow as Web Service in the test environment, then let @Fine0830 try it out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] mrproliu commented on pull request #250: feat: update trace profiling protocol
Posted by "mrproliu (via GitHub)" <gi...@apache.org>.
mrproliu commented on PR #250:
URL: https://github.com/apache/skywalking-booster-ui/pull/250#issuecomment-1486884113
> What is the condition of un-profiled span? @mrproliu
https://github.com/apache/skywalking-query-protocol/blob/master/profile.graphqls#L137 as `false`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] Fine0830 commented on pull request #250: feat: update trace profiling protocol
Posted by "Fine0830 (via GitHub)" <gi...@apache.org>.
Fine0830 commented on PR #250:
URL: https://github.com/apache/skywalking-booster-ui/pull/250#issuecomment-1488438741
Done
https://user-images.githubusercontent.com/20871783/228523237-21675cb5-31b8-4c73-a333-a4825b30b720.mov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] wu-sheng commented on pull request #250: feat: update trace profiling protocol
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #250:
URL: https://github.com/apache/skywalking-booster-ui/pull/250#issuecomment-1486882650
> For now, I just check it locally. Tomorrow, I will change the "songs" service to use Undertow as Web Service in the test environment, then let @Fine0830 try it out.
Make sense. FYI @kezhenxu94 To adopt the new profiling feature, we are going to make the `songs` service somehow has x-thread tasks in the workflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] mrproliu commented on pull request #250: feat: update trace profiling protocol
Posted by "mrproliu (via GitHub)" <gi...@apache.org>.
mrproliu commented on PR #250:
URL: https://github.com/apache/skywalking-booster-ui/pull/250#issuecomment-1487985919
> @mrproliu Is undertow the un-profilied span? I thought we have it profiled.
The "/songs" is un-profiled span. The real code is running on the "UndertowDispatch".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] wu-sheng commented on pull request #250: feat: update trace profiling protocol
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #250:
URL: https://github.com/apache/skywalking-booster-ui/pull/250#issuecomment-1486839589
Besides the un-profilied span, @mrproliu do we have mock data about the cross-thread profiling? I think we need to check whether the segments are linked and whether the stack is able to support this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] Fine0830 commented on pull request #250: feat: update trace profiling protocol
Posted by "Fine0830 (via GitHub)" <gi...@apache.org>.
Fine0830 commented on PR #250:
URL: https://github.com/apache/skywalking-booster-ui/pull/250#issuecomment-1486964857
I don't found the mock data about un-profiled span. Can you provide this? @mrproliu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] wu-sheng commented on pull request #250: feat: update trace profiling protocol
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #250:
URL: https://github.com/apache/skywalking-booster-ui/pull/250#issuecomment-1488596183
Let's add the icons to the `List` view of the trace too. It should be helpful
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] Fine0830 commented on pull request #250: feat: update trace profiling protocol
Posted by "Fine0830 (via GitHub)" <gi...@apache.org>.
Fine0830 commented on PR #250:
URL: https://github.com/apache/skywalking-booster-ui/pull/250#issuecomment-1489564914
Add tips
https://user-images.githubusercontent.com/20871783/228706205-81c77fe2-16ce-45d3-ad94-a69e3a1d77f1.mov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org