You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Peeyush Bishnoi <bp...@yahoo.co.in> on 2015/09/28 11:14:36 UTC
Review Request 38800: FALCON-1491: Update ActiveMQ version to 5.12
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38800/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-1491
https://issues.apache.org/jira/browse/FALCON-1491
Repository: falcon-git
Description
-------
FALCON-1491: Update ActiveMQ version to 5.12
Diffs
-----
addons/hivedr/pom.xml fc04f20
common/src/main/resources/startup.properties 9db460c
messaging/pom.xml 6528278
messaging/src/test/java/org/apache/falcon/messaging/JMSMessageConsumerTest.java 5bbcc87
pom.xml 8127b46
rerun/pom.xml b07e4e9
src/conf/startup.properties 8f3bc35
test-tools/hadoop-webapp/pom.xml eea00dc
unit/src/main/resources/startup.properties 4207ab9
webapp/pom.xml a4d5a8d
Diff: https://reviews.apache.org/r/38800/diff/
Testing
-------
Yes.
Thanks,
Peeyush Bishnoi
Re: Review Request 38800: FALCON-1491: Update ActiveMQ version to 5.12
Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.
> On Sept. 28, 2015, 7:08 p.m., Ajay Yadava wrote:
> > messaging/pom.xml, line 96
> > <https://reviews.apache.org/r/38800/diff/1/?file=1085743#file1085743line96>
> >
> > Do we really need everything in activemq-all? Is this a mandatory requirement to fix the issue being described in JIRA?
>
> Peeyush Bishnoi wrote:
> For the given exception, we need to upgrade the activemq to 5.12.0. activemq-core is within activemq-all which is in version 5.12.0.
>
> Ajay Yadava wrote:
> My concern is that activemq-all will contain lot of other things which we don't need. Can we avoid including those dependencies and continue to use just upgraded version of activemq-core, will that not solve the issue?
I too have thought similarly and tried to avoid classes which we don't require. But as I have mentioned, for version 5.12.0 activemq-all is only available that inclusively contain classes for activemq-core jar file and it's dependencies.
- Peeyush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38800/#review100844
-----------------------------------------------------------
On Sept. 28, 2015, 9:14 a.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38800/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2015, 9:14 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1491
> https://issues.apache.org/jira/browse/FALCON-1491
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> FALCON-1491: Update ActiveMQ version to 5.12
>
>
> Diffs
> -----
>
> addons/hivedr/pom.xml fc04f20
> common/src/main/resources/startup.properties 9db460c
> messaging/pom.xml 6528278
> messaging/src/test/java/org/apache/falcon/messaging/JMSMessageConsumerTest.java 5bbcc87
> pom.xml 8127b46
> rerun/pom.xml b07e4e9
> src/conf/startup.properties 8f3bc35
> test-tools/hadoop-webapp/pom.xml eea00dc
> unit/src/main/resources/startup.properties 4207ab9
> webapp/pom.xml a4d5a8d
>
> Diff: https://reviews.apache.org/r/38800/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 38800: FALCON-1491: Update ActiveMQ version to 5.12
Posted by Ajay Yadava <aj...@gmail.com>.
> On Sept. 28, 2015, 7:08 p.m., Ajay Yadava wrote:
> > messaging/pom.xml, line 96
> > <https://reviews.apache.org/r/38800/diff/1/?file=1085743#file1085743line96>
> >
> > Do we really need everything in activemq-all? Is this a mandatory requirement to fix the issue being described in JIRA?
>
> Peeyush Bishnoi wrote:
> For the given exception, we need to upgrade the activemq to 5.12.0. activemq-core is within activemq-all which is in version 5.12.0.
My concern is that activemq-all will contain lot of other things which we don't need. Can we avoid including those dependencies and continue to use just upgraded version of activemq-core, will that not solve the issue?
- Ajay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38800/#review100844
-----------------------------------------------------------
On Sept. 28, 2015, 9:14 a.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38800/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2015, 9:14 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1491
> https://issues.apache.org/jira/browse/FALCON-1491
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> FALCON-1491: Update ActiveMQ version to 5.12
>
>
> Diffs
> -----
>
> addons/hivedr/pom.xml fc04f20
> common/src/main/resources/startup.properties 9db460c
> messaging/pom.xml 6528278
> messaging/src/test/java/org/apache/falcon/messaging/JMSMessageConsumerTest.java 5bbcc87
> pom.xml 8127b46
> rerun/pom.xml b07e4e9
> src/conf/startup.properties 8f3bc35
> test-tools/hadoop-webapp/pom.xml eea00dc
> unit/src/main/resources/startup.properties 4207ab9
> webapp/pom.xml a4d5a8d
>
> Diff: https://reviews.apache.org/r/38800/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 38800: FALCON-1491: Update ActiveMQ version to 5.12
Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.
> On Sept. 28, 2015, 7:08 p.m., Ajay Yadava wrote:
> > messaging/src/test/java/org/apache/falcon/messaging/JMSMessageConsumerTest.java, line 150
> > <https://reviews.apache.org/r/38800/diff/1/?file=1085744#file1085744line150>
> >
> > Is this value affected by upgrade?
yes.
- Peeyush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38800/#review100844
-----------------------------------------------------------
On Sept. 28, 2015, 9:14 a.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38800/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2015, 9:14 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1491
> https://issues.apache.org/jira/browse/FALCON-1491
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> FALCON-1491: Update ActiveMQ version to 5.12
>
>
> Diffs
> -----
>
> addons/hivedr/pom.xml fc04f20
> common/src/main/resources/startup.properties 9db460c
> messaging/pom.xml 6528278
> messaging/src/test/java/org/apache/falcon/messaging/JMSMessageConsumerTest.java 5bbcc87
> pom.xml 8127b46
> rerun/pom.xml b07e4e9
> src/conf/startup.properties 8f3bc35
> test-tools/hadoop-webapp/pom.xml eea00dc
> unit/src/main/resources/startup.properties 4207ab9
> webapp/pom.xml a4d5a8d
>
> Diff: https://reviews.apache.org/r/38800/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 38800: FALCON-1491: Update ActiveMQ version to 5.12
Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.
> On Sept. 28, 2015, 7:08 p.m., Ajay Yadava wrote:
> > messaging/pom.xml, line 96
> > <https://reviews.apache.org/r/38800/diff/1/?file=1085743#file1085743line96>
> >
> > Do we really need everything in activemq-all? Is this a mandatory requirement to fix the issue being described in JIRA?
For the given exception, we need to upgrade the activemq to 5.12.0. activemq-core is within activemq-all which is in version 5.12.0.
> On Sept. 28, 2015, 7:08 p.m., Ajay Yadava wrote:
> > webapp/pom.xml, line 342
> > <https://reviews.apache.org/r/38800/diff/1/?file=1085750#file1085750line342>
> >
> > This change also doesn't seem to be related to the bug mentioned in the description? Is this required to fix the issue?
kahadb need to be similar version of activemq. As version 5.12.0 is used, kahadb is supported from package activemq-kahadb-store which is available for 5.12.0.
- Peeyush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38800/#review100844
-----------------------------------------------------------
On Sept. 28, 2015, 9:14 a.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38800/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2015, 9:14 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1491
> https://issues.apache.org/jira/browse/FALCON-1491
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> FALCON-1491: Update ActiveMQ version to 5.12
>
>
> Diffs
> -----
>
> addons/hivedr/pom.xml fc04f20
> common/src/main/resources/startup.properties 9db460c
> messaging/pom.xml 6528278
> messaging/src/test/java/org/apache/falcon/messaging/JMSMessageConsumerTest.java 5bbcc87
> pom.xml 8127b46
> rerun/pom.xml b07e4e9
> src/conf/startup.properties 8f3bc35
> test-tools/hadoop-webapp/pom.xml eea00dc
> unit/src/main/resources/startup.properties 4207ab9
> webapp/pom.xml a4d5a8d
>
> Diff: https://reviews.apache.org/r/38800/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 38800: FALCON-1491: Update ActiveMQ version to 5.12
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38800/#review100844
-----------------------------------------------------------
messaging/pom.xml (line 96)
<https://reviews.apache.org/r/38800/#comment158094>
Do we really need everything in activemq-all? Is this a mandatory requirement to fix the issue being described in JIRA?
messaging/src/test/java/org/apache/falcon/messaging/JMSMessageConsumerTest.java (line 150)
<https://reviews.apache.org/r/38800/#comment158095>
Is this value affected by upgrade?
webapp/pom.xml (line 342)
<https://reviews.apache.org/r/38800/#comment158097>
This change also doesn't seem to be related to the bug mentioned in the description? Is this required to fix the issue?
- Ajay Yadava
On Sept. 28, 2015, 9:14 a.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38800/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2015, 9:14 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1491
> https://issues.apache.org/jira/browse/FALCON-1491
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> FALCON-1491: Update ActiveMQ version to 5.12
>
>
> Diffs
> -----
>
> addons/hivedr/pom.xml fc04f20
> common/src/main/resources/startup.properties 9db460c
> messaging/pom.xml 6528278
> messaging/src/test/java/org/apache/falcon/messaging/JMSMessageConsumerTest.java 5bbcc87
> pom.xml 8127b46
> rerun/pom.xml b07e4e9
> src/conf/startup.properties 8f3bc35
> test-tools/hadoop-webapp/pom.xml eea00dc
> unit/src/main/resources/startup.properties 4207ab9
> webapp/pom.xml a4d5a8d
>
> Diff: https://reviews.apache.org/r/38800/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 38800: FALCON-1491: Update ActiveMQ version to 5.12
Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38800/#review101602
-----------------------------------------------------------
Ship it!
Ship It!
- Pallavi Rao
On Oct. 6, 2015, 4:41 a.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38800/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2015, 4:41 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1491
> https://issues.apache.org/jira/browse/FALCON-1491
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> FALCON-1491: Update ActiveMQ version to 5.12
>
>
> Diffs
> -----
>
> addons/hivedr/pom.xml fc04f20
> common/src/main/resources/startup.properties 9db460c
> messaging/pom.xml 6528278
> messaging/src/test/java/org/apache/falcon/messaging/JMSMessageConsumerTest.java 5bbcc87
> pom.xml 8127b46
> rerun/pom.xml b07e4e9
> src/conf/startup.properties 8f3bc35
> test-tools/hadoop-webapp/pom.xml eea00dc
> unit/src/main/resources/startup.properties 4207ab9
> webapp/pom.xml a4d5a8d
>
> Diff: https://reviews.apache.org/r/38800/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 38800: FALCON-1491: Update ActiveMQ version to 5.12
Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38800/#review101606
-----------------------------------------------------------
Ship it!
Good work. May be we should push activemq to a separate messaging profile to better manage dependencies in future
- Venkat Ranganathan
On Oct. 5, 2015, 9:41 p.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38800/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2015, 9:41 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1491
> https://issues.apache.org/jira/browse/FALCON-1491
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> FALCON-1491: Update ActiveMQ version to 5.12
>
>
> Diffs
> -----
>
> addons/hivedr/pom.xml fc04f20
> common/src/main/resources/startup.properties 9db460c
> messaging/pom.xml 6528278
> messaging/src/test/java/org/apache/falcon/messaging/JMSMessageConsumerTest.java 5bbcc87
> pom.xml 8127b46
> rerun/pom.xml b07e4e9
> src/conf/startup.properties 8f3bc35
> test-tools/hadoop-webapp/pom.xml eea00dc
> unit/src/main/resources/startup.properties 4207ab9
> webapp/pom.xml a4d5a8d
>
> Diff: https://reviews.apache.org/r/38800/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 38800: FALCON-1491: Update ActiveMQ version to 5.12
Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38800/
-----------------------------------------------------------
(Updated Oct. 6, 2015, 4:41 a.m.)
Review request for Falcon.
Changes
-------
Updated patch after incorporating review comments.
Bugs: FALCON-1491
https://issues.apache.org/jira/browse/FALCON-1491
Repository: falcon-git
Description
-------
FALCON-1491: Update ActiveMQ version to 5.12
Diffs (updated)
-----
addons/hivedr/pom.xml fc04f20
common/src/main/resources/startup.properties 9db460c
messaging/pom.xml 6528278
messaging/src/test/java/org/apache/falcon/messaging/JMSMessageConsumerTest.java 5bbcc87
pom.xml 8127b46
rerun/pom.xml b07e4e9
src/conf/startup.properties 8f3bc35
test-tools/hadoop-webapp/pom.xml eea00dc
unit/src/main/resources/startup.properties 4207ab9
webapp/pom.xml a4d5a8d
Diff: https://reviews.apache.org/r/38800/diff/
Testing
-------
Yes.
Thanks,
Peeyush Bishnoi
Re: Review Request 38800: FALCON-1491: Update ActiveMQ version to 5.12
Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.
> On Oct. 5, 2015, 8:52 a.m., Pallavi Rao wrote:
> > common/src/main/resources/startup.properties, line 56
> > <https://reviews.apache.org/r/38800/diff/2/?file=1088488#file1088488line56>
> >
> > May be activemq-client is sufficient here. See related comment below.
There are differences in sub-modules of activemq-client and activemq-core. Also for embedded broker activemq-core/activemq-all is required.
> On Oct. 5, 2015, 8:52 a.m., Pallavi Rao wrote:
> > addons/hivedr/pom.xml, line 96
> > <https://reviews.apache.org/r/38800/diff/2/?file=1088487#file1088487line96>
> >
> > No new exclusions required?
Exclusion is performed to exclude the optional artifacts from activemq-all.
> On Oct. 5, 2015, 8:52 a.m., Pallavi Rao wrote:
> > messaging/pom.xml, line 96
> > <https://reviews.apache.org/r/38800/diff/2/?file=1088489#file1088489line96>
> >
> > activemq-client is sufficient for compilation of this package. Only tests use broker. So, can we just use activemq-all with test scope and activemq-client with compile scope?
For activemq 5.12.0, there is no activemq-core, it is activemq-all which contain artifacts from activemq-core. This messaging module require broker so we need to use activemq-all otherwise compilation will fail.
> On Oct. 5, 2015, 8:52 a.m., Pallavi Rao wrote:
> > messaging/pom.xml, line 121
> > <https://reviews.apache.org/r/38800/diff/2/?file=1088489#file1088489line121>
> >
> > Repeated exclusion
Fixed.
> On Oct. 5, 2015, 8:52 a.m., Pallavi Rao wrote:
> > pom.xml, line 757
> > <https://reviews.apache.org/r/38800/diff/2/?file=1088491#file1088491line757>
> >
> > Exclusion is repeated.
Fixed.
> On Oct. 5, 2015, 8:52 a.m., Pallavi Rao wrote:
> > rerun/pom.xml, line 92
> > <https://reviews.apache.org/r/38800/diff/2/?file=1088492#file1088492line92>
> >
> > Is activemq-client is sufficient for compile and test of this package?
Same Comment as above.
> On Oct. 5, 2015, 8:52 a.m., Pallavi Rao wrote:
> > test-tools/hadoop-webapp/pom.xml, line 192
> > <https://reviews.apache.org/r/38800/diff/2/?file=1088494#file1088494line192>
> >
> > Same comment as above may be use appropriate packages with different scopes?
Same comment as above.
- Peeyush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38800/#review101450
-----------------------------------------------------------
On Oct. 1, 2015, 1:23 p.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38800/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2015, 1:23 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1491
> https://issues.apache.org/jira/browse/FALCON-1491
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> FALCON-1491: Update ActiveMQ version to 5.12
>
>
> Diffs
> -----
>
> addons/hivedr/pom.xml fc04f20
> common/src/main/resources/startup.properties 9db460c
> messaging/pom.xml 6528278
> messaging/src/test/java/org/apache/falcon/messaging/JMSMessageConsumerTest.java 5bbcc87
> pom.xml 8127b46
> rerun/pom.xml b07e4e9
> src/conf/startup.properties 8f3bc35
> test-tools/hadoop-webapp/pom.xml eea00dc
> unit/src/main/resources/startup.properties 4207ab9
> webapp/pom.xml a4d5a8d
>
> Diff: https://reviews.apache.org/r/38800/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 38800: FALCON-1491: Update ActiveMQ version to 5.12
Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38800/#review101450
-----------------------------------------------------------
addons/hivedr/pom.xml (line 96)
<https://reviews.apache.org/r/38800/#comment158835>
No new exclusions required?
common/src/main/resources/startup.properties (line 56)
<https://reviews.apache.org/r/38800/#comment158836>
May be activemq-client is sufficient here. See related comment below.
messaging/pom.xml (line 96)
<https://reviews.apache.org/r/38800/#comment158838>
activemq-client is sufficient for compilation of this package. Only tests use broker. So, can we just use activemq-all with test scope and activemq-client with compile scope?
messaging/pom.xml (line 121)
<https://reviews.apache.org/r/38800/#comment158839>
Repeated exclusion
pom.xml (line 757)
<https://reviews.apache.org/r/38800/#comment158834>
Exclusion is repeated.
rerun/pom.xml (line 92)
<https://reviews.apache.org/r/38800/#comment158842>
Is activemq-client is sufficient for compile and test of this package?
test-tools/hadoop-webapp/pom.xml (line 192)
<https://reviews.apache.org/r/38800/#comment158843>
Same comment as above may be use appropriate packages with different scopes?
- Pallavi Rao
On Oct. 1, 2015, 1:23 p.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38800/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2015, 1:23 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1491
> https://issues.apache.org/jira/browse/FALCON-1491
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> FALCON-1491: Update ActiveMQ version to 5.12
>
>
> Diffs
> -----
>
> addons/hivedr/pom.xml fc04f20
> common/src/main/resources/startup.properties 9db460c
> messaging/pom.xml 6528278
> messaging/src/test/java/org/apache/falcon/messaging/JMSMessageConsumerTest.java 5bbcc87
> pom.xml 8127b46
> rerun/pom.xml b07e4e9
> src/conf/startup.properties 8f3bc35
> test-tools/hadoop-webapp/pom.xml eea00dc
> unit/src/main/resources/startup.properties 4207ab9
> webapp/pom.xml a4d5a8d
>
> Diff: https://reviews.apache.org/r/38800/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 38800: FALCON-1491: Update ActiveMQ version to 5.12
Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38800/
-----------------------------------------------------------
(Updated Oct. 1, 2015, 1:23 p.m.)
Review request for Falcon.
Changes
-------
Updated patch that will exclude the many activemq dependencies.
Bugs: FALCON-1491
https://issues.apache.org/jira/browse/FALCON-1491
Repository: falcon-git
Description
-------
FALCON-1491: Update ActiveMQ version to 5.12
Diffs (updated)
-----
addons/hivedr/pom.xml fc04f20
common/src/main/resources/startup.properties 9db460c
messaging/pom.xml 6528278
messaging/src/test/java/org/apache/falcon/messaging/JMSMessageConsumerTest.java 5bbcc87
pom.xml 8127b46
rerun/pom.xml b07e4e9
src/conf/startup.properties 8f3bc35
test-tools/hadoop-webapp/pom.xml eea00dc
unit/src/main/resources/startup.properties 4207ab9
webapp/pom.xml a4d5a8d
Diff: https://reviews.apache.org/r/38800/diff/
Testing
-------
Yes.
Thanks,
Peeyush Bishnoi