You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Brill Pappin (JIRA)" <ji...@apache.org> on 2007/11/09 04:01:50 UTC
[jira] Created: (WICKET-1138) Better warning of design errors
during development
Better warning of design errors during development
--------------------------------------------------
Key: WICKET-1138
URL: https://issues.apache.org/jira/browse/WICKET-1138
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.3.0-beta4
Reporter: Brill Pappin
As suggested in this list post:
http://www.nabble.com/Form%3A-onSubmit-not-called-tf4763217.html#a13659761
> Although it was my own fault hands down (silly me didn't write a test first)
> I'm thinking that I could have saved hours with some sort of indication...
> now that its happened once the lesson is pretty clear, but a lot of people
> are going to stumble over stuff like that when they first get into Wicket.
Yeah. If you can open up a JIRA issue for it, we can think/ discuss
what we could do here.
Eelco
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1138) Better warning of design errors
during development
Posted by "Gwyn Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541260 ]
Gwyn Evans commented on WICKET-1138:
------------------------------------
If you did have a feedback panel, would there have been a message that would at a minimum, point you in the right direction to find the problem?
If so, then maybe what we need to do is log any unprocessed warning or error messages when in development mode.
> Better warning of design errors during development
> --------------------------------------------------
>
> Key: WICKET-1138
> URL: https://issues.apache.org/jira/browse/WICKET-1138
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta4
> Reporter: Brill Pappin
>
> As suggested in this list post:
> http://www.nabble.com/Form%3A-onSubmit-not-called-tf4763217.html#a13659761
> > Although it was my own fault hands down (silly me didn't write a test first)
> > I'm thinking that I could have saved hours with some sort of indication...
> > now that its happened once the lesson is pretty clear, but a lot of people
> > are going to stumble over stuff like that when they first get into Wicket.
> Yeah. If you can open up a JIRA issue for it, we can think/ discuss
> what we could do here.
> Eelco
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1138) Better warning of design errors
during development
Posted by "Brill Pappin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542636 ]
Brill Pappin commented on WICKET-1138:
--------------------------------------
I'm not sure that would cover the problem.
In this case it was a type mismatch (String -> Date) so and exception would have been thrown before it ever made it into a message object.
> Better warning of design errors during development
> --------------------------------------------------
>
> Key: WICKET-1138
> URL: https://issues.apache.org/jira/browse/WICKET-1138
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta4
> Reporter: Brill Pappin
> Assignee: Eelco Hillenius
> Fix For: 1.3.0-rc2
>
>
> As suggested in this list post:
> http://www.nabble.com/Form%3A-onSubmit-not-called-tf4763217.html#a13659761
> > Although it was my own fault hands down (silly me didn't write a test first)
> > I'm thinking that I could have saved hours with some sort of indication...
> > now that its happened once the lesson is pretty clear, but a lot of people
> > are going to stumble over stuff like that when they first get into Wicket.
> Yeah. If you can open up a JIRA issue for it, we can think/ discuss
> what we could do here.
> Eelco
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1138) Better warning of design errors
during development
Posted by "Brill Pappin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541228 ]
Brill Pappin commented on WICKET-1138:
--------------------------------------
You could do that, and it would catch a bunch at once if you had more than one "unconsumed" message... but I'm thinking simpler as I may not *want* to consume all the messages.
>From my point of view, all I really needed was something to say "I tried to save this value back to your model but got an error that said X".
You'd get that message immediatly when a converter failed (in my case, string to date).
I guess I see this as a bug in my code rather than something I "should" have done in good style, and I don't want Wicket trying to decide what good style is, or try and guess what I meant to do.
However, I think indicating that there were errors that where not displayed in any way would also be helpful in getting people to add a feedback panel, so maybe we have two entry points into this potential problem.
> Better warning of design errors during development
> --------------------------------------------------
>
> Key: WICKET-1138
> URL: https://issues.apache.org/jira/browse/WICKET-1138
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta4
> Reporter: Brill Pappin
>
> As suggested in this list post:
> http://www.nabble.com/Form%3A-onSubmit-not-called-tf4763217.html#a13659761
> > Although it was my own fault hands down (silly me didn't write a test first)
> > I'm thinking that I could have saved hours with some sort of indication...
> > now that its happened once the lesson is pretty clear, but a lot of people
> > are going to stumble over stuff like that when they first get into Wicket.
> Yeah. If you can open up a JIRA issue for it, we can think/ discuss
> what we could do here.
> Eelco
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1138) Better warning of design errors
during development
Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Frank Bille Jensen updated WICKET-1138:
---------------------------------------
Fix Version/s: (was: 1.3.0-rc2)
1.3.0-rc3
> Better warning of design errors during development
> --------------------------------------------------
>
> Key: WICKET-1138
> URL: https://issues.apache.org/jira/browse/WICKET-1138
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta4
> Reporter: Brill Pappin
> Assignee: Eelco Hillenius
> Fix For: 1.3.0-rc3
>
>
> As suggested in this list post:
> http://www.nabble.com/Form%3A-onSubmit-not-called-tf4763217.html#a13659761
> > Although it was my own fault hands down (silly me didn't write a test first)
> > I'm thinking that I could have saved hours with some sort of indication...
> > now that its happened once the lesson is pretty clear, but a lot of people
> > are going to stumble over stuff like that when they first get into Wicket.
> Yeah. If you can open up a JIRA issue for it, we can think/ discuss
> what we could do here.
> Eelco
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1138) Better warning of design errors
during development
Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Frank Bille Jensen updated WICKET-1138:
---------------------------------------
Fix Version/s: (was: 1.4-M2)
1.4-M3
> Better warning of design errors during development
> --------------------------------------------------
>
> Key: WICKET-1138
> URL: https://issues.apache.org/jira/browse/WICKET-1138
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Reporter: Brill Pappin
> Assignee: Eelco Hillenius
> Fix For: 1.4-M3
>
>
> As suggested in this list post:
> http://www.nabble.com/Form%3A-onSubmit-not-called-tf4763217.html#a13659761
> > Although it was my own fault hands down (silly me didn't write a test first)
> > I'm thinking that I could have saved hours with some sort of indication...
> > now that its happened once the lesson is pretty clear, but a lot of people
> > are going to stumble over stuff like that when they first get into Wicket.
> Yeah. If you can open up a JIRA issue for it, we can think/ discuss
> what we could do here.
> Eelco
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1138) Better warning of design errors
during development
Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Frank Bille Jensen updated WICKET-1138:
---------------------------------------
Fix Version/s: (was: 1.4-M1)
1.4-M2
> Better warning of design errors during development
> --------------------------------------------------
>
> Key: WICKET-1138
> URL: https://issues.apache.org/jira/browse/WICKET-1138
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Reporter: Brill Pappin
> Assignee: Eelco Hillenius
> Fix For: 1.4-M2
>
>
> As suggested in this list post:
> http://www.nabble.com/Form%3A-onSubmit-not-called-tf4763217.html#a13659761
> > Although it was my own fault hands down (silly me didn't write a test first)
> > I'm thinking that I could have saved hours with some sort of indication...
> > now that its happened once the lesson is pretty clear, but a lot of people
> > are going to stumble over stuff like that when they first get into Wicket.
> Yeah. If you can open up a JIRA issue for it, we can think/ discuss
> what we could do here.
> Eelco
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1138) Better warning of design errors
during development
Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542639 ]
Eelco Hillenius commented on WICKET-1138:
-----------------------------------------
But the exception is thrown as a ConversionException which is later caught and logged as a feedback message. If it wasn't caught, you would have seen an error page.
> Better warning of design errors during development
> --------------------------------------------------
>
> Key: WICKET-1138
> URL: https://issues.apache.org/jira/browse/WICKET-1138
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta4
> Reporter: Brill Pappin
> Assignee: Eelco Hillenius
> Fix For: 1.3.0-rc2
>
>
> As suggested in this list post:
> http://www.nabble.com/Form%3A-onSubmit-not-called-tf4763217.html#a13659761
> > Although it was my own fault hands down (silly me didn't write a test first)
> > I'm thinking that I could have saved hours with some sort of indication...
> > now that its happened once the lesson is pretty clear, but a lot of people
> > are going to stumble over stuff like that when they first get into Wicket.
> Yeah. If you can open up a JIRA issue for it, we can think/ discuss
> what we could do here.
> Eelco
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1138) Better warning of design errors
during development
Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Frank Bille Jensen updated WICKET-1138:
---------------------------------------
Fix Version/s: (was: 1.3.0-rc3)
1.3.1
> Better warning of design errors during development
> --------------------------------------------------
>
> Key: WICKET-1138
> URL: https://issues.apache.org/jira/browse/WICKET-1138
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta4
> Reporter: Brill Pappin
> Assignee: Eelco Hillenius
> Fix For: 1.3.1
>
>
> As suggested in this list post:
> http://www.nabble.com/Form%3A-onSubmit-not-called-tf4763217.html#a13659761
> > Although it was my own fault hands down (silly me didn't write a test first)
> > I'm thinking that I could have saved hours with some sort of indication...
> > now that its happened once the lesson is pretty clear, but a lot of people
> > are going to stumble over stuff like that when they first get into Wicket.
> Yeah. If you can open up a JIRA issue for it, we can think/ discuss
> what we could do here.
> Eelco
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1138) Better warning of design errors
during development
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542779 ]
Johan Compagner commented on WICKET-1138:
-----------------------------------------
so in Session.detach go over the current feedback messages and print them?
But i dont know if we know if they are shown or not. Because what is shown? FeedbackBorder?
> Better warning of design errors during development
> --------------------------------------------------
>
> Key: WICKET-1138
> URL: https://issues.apache.org/jira/browse/WICKET-1138
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta4
> Reporter: Brill Pappin
> Assignee: Eelco Hillenius
> Fix For: 1.3.0-rc2
>
>
> As suggested in this list post:
> http://www.nabble.com/Form%3A-onSubmit-not-called-tf4763217.html#a13659761
> > Although it was my own fault hands down (silly me didn't write a test first)
> > I'm thinking that I could have saved hours with some sort of indication...
> > now that its happened once the lesson is pretty clear, but a lot of people
> > are going to stumble over stuff like that when they first get into Wicket.
> Yeah. If you can open up a JIRA issue for it, we can think/ discuss
> what we could do here.
> Eelco
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1138) Better warning of design errors
during development
Posted by "Martijn Dashorst (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martijn Dashorst updated WICKET-1138:
-------------------------------------
Fix Version/s: (was: 1.4-M3)
1.4-M4
Moved to next milestone release.
> Better warning of design errors during development
> --------------------------------------------------
>
> Key: WICKET-1138
> URL: https://issues.apache.org/jira/browse/WICKET-1138
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Reporter: Brill Pappin
> Assignee: Eelco Hillenius
> Fix For: 1.4-M4
>
>
> As suggested in this list post:
> http://www.nabble.com/Form%3A-onSubmit-not-called-tf4763217.html#a13659761
> > Although it was my own fault hands down (silly me didn't write a test first)
> > I'm thinking that I could have saved hours with some sort of indication...
> > now that its happened once the lesson is pretty clear, but a lot of people
> > are going to stumble over stuff like that when they first get into Wicket.
> Yeah. If you can open up a JIRA issue for it, we can think/ discuss
> what we could do here.
> Eelco
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1138) Better warning of design errors
during development
Posted by "Gwyn Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542720 ]
Gwyn Evans commented on WICKET-1138:
------------------------------------
Yes, it's logged as a feedback message, but I don't think that just the debug log's good enough when there's no feedback panel, as globally setting 'debug' provides too much of a flood of info.
How feasible is it to be able to (in DEV mode) detect any unprocessed feedback messages and log any error/warning ones at those logging levels? Not stack-traces, but just the msg itself & the fact it's unprocessed or would that generate too much info in 'normal' development?
> Better warning of design errors during development
> --------------------------------------------------
>
> Key: WICKET-1138
> URL: https://issues.apache.org/jira/browse/WICKET-1138
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta4
> Reporter: Brill Pappin
> Assignee: Eelco Hillenius
> Fix For: 1.3.0-rc2
>
>
> As suggested in this list post:
> http://www.nabble.com/Form%3A-onSubmit-not-called-tf4763217.html#a13659761
> > Although it was my own fault hands down (silly me didn't write a test first)
> > I'm thinking that I could have saved hours with some sort of indication...
> > now that its happened once the lesson is pretty clear, but a lot of people
> > are going to stumble over stuff like that when they first get into Wicket.
> Yeah. If you can open up a JIRA issue for it, we can think/ discuss
> what we could do here.
> Eelco
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1138) Better warning of design errors
during development
Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541500 ]
Eelco Hillenius commented on WICKET-1138:
-----------------------------------------
Validation errors of user input is nothing exceptional though. So in that sense, I don't think we should log errors, not even in development mode. I could agree with warnings and then only when in development mode. I'm not sure whether we should pass the stack trace by default. I think we should log enough information so that you don't need it.
> Better warning of design errors during development
> --------------------------------------------------
>
> Key: WICKET-1138
> URL: https://issues.apache.org/jira/browse/WICKET-1138
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta4
> Reporter: Brill Pappin
>
> As suggested in this list post:
> http://www.nabble.com/Form%3A-onSubmit-not-called-tf4763217.html#a13659761
> > Although it was my own fault hands down (silly me didn't write a test first)
> > I'm thinking that I could have saved hours with some sort of indication...
> > now that its happened once the lesson is pretty clear, but a lot of people
> > are going to stumble over stuff like that when they first get into Wicket.
> Yeah. If you can open up a JIRA issue for it, we can think/ discuss
> what we could do here.
> Eelco
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1138) Better warning of design errors
during development
Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542825 ]
Eelco Hillenius commented on WICKET-1138:
-----------------------------------------
Yes, that would be my idea Gwyn. We can display all the component specific messages that were not rendered during that request. I think that will work.
> Better warning of design errors during development
> --------------------------------------------------
>
> Key: WICKET-1138
> URL: https://issues.apache.org/jira/browse/WICKET-1138
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta4
> Reporter: Brill Pappin
> Assignee: Eelco Hillenius
> Fix For: 1.3.0-rc2
>
>
> As suggested in this list post:
> http://www.nabble.com/Form%3A-onSubmit-not-called-tf4763217.html#a13659761
> > Although it was my own fault hands down (silly me didn't write a test first)
> > I'm thinking that I could have saved hours with some sort of indication...
> > now that its happened once the lesson is pretty clear, but a lot of people
> > are going to stumble over stuff like that when they first get into Wicket.
> Yeah. If you can open up a JIRA issue for it, we can think/ discuss
> what we could do here.
> Eelco
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1138) Better warning of design errors
during development
Posted by "Brill Pappin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541496 ]
Brill Pappin commented on WICKET-1138:
--------------------------------------
in this case it pointed me at the bean property that it was trying to set, and experience took over to know exactly what went wrong. However I would have preferred to have the actual exception message in this case.
> Better warning of design errors during development
> --------------------------------------------------
>
> Key: WICKET-1138
> URL: https://issues.apache.org/jira/browse/WICKET-1138
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta4
> Reporter: Brill Pappin
>
> As suggested in this list post:
> http://www.nabble.com/Form%3A-onSubmit-not-called-tf4763217.html#a13659761
> > Although it was my own fault hands down (silly me didn't write a test first)
> > I'm thinking that I could have saved hours with some sort of indication...
> > now that its happened once the lesson is pretty clear, but a lot of people
> > are going to stumble over stuff like that when they first get into Wicket.
> Yeah. If you can open up a JIRA issue for it, we can think/ discuss
> what we could do here.
> Eelco
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1138) Better warning of design errors
during development
Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541224 ]
Eelco Hillenius commented on WICKET-1138:
-----------------------------------------
The question is *when* to do this. You are not obliged to have a feedback panel in your pages, and you can even have multiple consumers of the same feedback messages on a page.
I guess one thing we could consider is to log a warning when component-specific messages aren't consumed after a request?
> Better warning of design errors during development
> --------------------------------------------------
>
> Key: WICKET-1138
> URL: https://issues.apache.org/jira/browse/WICKET-1138
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta4
> Reporter: Brill Pappin
>
> As suggested in this list post:
> http://www.nabble.com/Form%3A-onSubmit-not-called-tf4763217.html#a13659761
> > Although it was my own fault hands down (silly me didn't write a test first)
> > I'm thinking that I could have saved hours with some sort of indication...
> > now that its happened once the lesson is pretty clear, but a lot of people
> > are going to stumble over stuff like that when they first get into Wicket.
> Yeah. If you can open up a JIRA issue for it, we can think/ discuss
> what we could do here.
> Eelco
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1138) Better warning of design errors
during development
Posted by "Brill Pappin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541501 ]
Brill Pappin commented on WICKET-1138:
--------------------------------------
That would do... the goal being that without a feedback panel I still want to be able to see that something isn't working.
> Better warning of design errors during development
> --------------------------------------------------
>
> Key: WICKET-1138
> URL: https://issues.apache.org/jira/browse/WICKET-1138
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta4
> Reporter: Brill Pappin
>
> As suggested in this list post:
> http://www.nabble.com/Form%3A-onSubmit-not-called-tf4763217.html#a13659761
> > Although it was my own fault hands down (silly me didn't write a test first)
> > I'm thinking that I could have saved hours with some sort of indication...
> > now that its happened once the lesson is pretty clear, but a lot of people
> > are going to stumble over stuff like that when they first get into Wicket.
> Yeah. If you can open up a JIRA issue for it, we can think/ discuss
> what we could do here.
> Eelco
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1138) Better warning of design errors
during development
Posted by "Brill Pappin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541216 ]
Brill Pappin commented on WICKET-1138:
--------------------------------------
First ideas:
- in development mode:
- an ERROR log entry is written.
or
- exception is actually thrown out
> Better warning of design errors during development
> --------------------------------------------------
>
> Key: WICKET-1138
> URL: https://issues.apache.org/jira/browse/WICKET-1138
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta4
> Reporter: Brill Pappin
>
> As suggested in this list post:
> http://www.nabble.com/Form%3A-onSubmit-not-called-tf4763217.html#a13659761
> > Although it was my own fault hands down (silly me didn't write a test first)
> > I'm thinking that I could have saved hours with some sort of indication...
> > now that its happened once the lesson is pretty clear, but a lot of people
> > are going to stumble over stuff like that when they first get into Wicket.
> Yeah. If you can open up a JIRA issue for it, we can think/ discuss
> what we could do here.
> Eelco
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1138) Better warning of design errors
during development
Posted by "Brill Pappin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541601 ]
Brill Pappin commented on WICKET-1138:
--------------------------------------
So adding log output in dev mode would actually be the quickest and most efficient in terms of getting something into the codebase....
In that case I'd say go for it... it'll likely only take you 5 minutes and you will never get a ticket like this again... anything else is YAGNI after that.
> Better warning of design errors during development
> --------------------------------------------------
>
> Key: WICKET-1138
> URL: https://issues.apache.org/jira/browse/WICKET-1138
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta4
> Reporter: Brill Pappin
>
> As suggested in this list post:
> http://www.nabble.com/Form%3A-onSubmit-not-called-tf4763217.html#a13659761
> > Although it was my own fault hands down (silly me didn't write a test first)
> > I'm thinking that I could have saved hours with some sort of indication...
> > now that its happened once the lesson is pretty clear, but a lot of people
> > are going to stumble over stuff like that when they first get into Wicket.
> Yeah. If you can open up a JIRA issue for it, we can think/ discuss
> what we could do here.
> Eelco
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1138) Better warning of design errors
during development
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Compagner updated WICKET-1138:
------------------------------------
Fix Version/s: 1.3.0-rc2
Assignee: Eelco Hillenius
we already log it:
final void add(FeedbackMessage message)
{
if (log.isDebugEnabled())
{
log.debug("Adding feedback message " + message);
}
messages.add(message);
}
so if you enable debug logging then you would see a message added to the list.
assigning to eelco so he could see if we close this issue.
> Better warning of design errors during development
> --------------------------------------------------
>
> Key: WICKET-1138
> URL: https://issues.apache.org/jira/browse/WICKET-1138
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta4
> Reporter: Brill Pappin
> Assignee: Eelco Hillenius
> Fix For: 1.3.0-rc2
>
>
> As suggested in this list post:
> http://www.nabble.com/Form%3A-onSubmit-not-called-tf4763217.html#a13659761
> > Although it was my own fault hands down (silly me didn't write a test first)
> > I'm thinking that I could have saved hours with some sort of indication...
> > now that its happened once the lesson is pretty clear, but a lot of people
> > are going to stumble over stuff like that when they first get into Wicket.
> Yeah. If you can open up a JIRA issue for it, we can think/ discuss
> what we could do here.
> Eelco
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1138) Better warning of design errors
during development
Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541529 ]
Eelco Hillenius commented on WICKET-1138:
-----------------------------------------
But it is working. Validation is executing like it should and if it fails, it doesn't execute the form. This is exactly what it should do. So in order to make debugging easier, we could log warn messages when in development mode, so that you can see that something is going on (obviously, you'd have to follow these logs, but that's a smart idea to start with).
> Better warning of design errors during development
> --------------------------------------------------
>
> Key: WICKET-1138
> URL: https://issues.apache.org/jira/browse/WICKET-1138
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta4
> Reporter: Brill Pappin
>
> As suggested in this list post:
> http://www.nabble.com/Form%3A-onSubmit-not-called-tf4763217.html#a13659761
> > Although it was my own fault hands down (silly me didn't write a test first)
> > I'm thinking that I could have saved hours with some sort of indication...
> > now that its happened once the lesson is pretty clear, but a lot of people
> > are going to stumble over stuff like that when they first get into Wicket.
> Yeah. If you can open up a JIRA issue for it, we can think/ discuss
> what we could do here.
> Eelco
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1138) Better warning of design errors
during development
Posted by "Brill Pappin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542645 ]
Brill Pappin commented on WICKET-1138:
--------------------------------------
OK, that works...
but the ticket was started because I had *zero* feedback at all, so I think although it might be covered in the code, the issue has not been dealt with.
I assume debug mode is having the logger set to debug?
Maybe the check should be if the application is in DEVELOPMENT mode instead?
or if not in DEVELOPMENT then check the logger for debug... I think that would cover the issue.
> Better warning of design errors during development
> --------------------------------------------------
>
> Key: WICKET-1138
> URL: https://issues.apache.org/jira/browse/WICKET-1138
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta4
> Reporter: Brill Pappin
> Assignee: Eelco Hillenius
> Fix For: 1.3.0-rc2
>
>
> As suggested in this list post:
> http://www.nabble.com/Form%3A-onSubmit-not-called-tf4763217.html#a13659761
> > Although it was my own fault hands down (silly me didn't write a test first)
> > I'm thinking that I could have saved hours with some sort of indication...
> > now that its happened once the lesson is pretty clear, but a lot of people
> > are going to stumble over stuff like that when they first get into Wicket.
> Yeah. If you can open up a JIRA issue for it, we can think/ discuss
> what we could do here.
> Eelco
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1138) Better warning of design errors
during development
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-1138.
-----------------------------------
Resolution: Fixed
Assignee: Igor Vaynberg (was: Eelco Hillenius)
all unrendered component-targetted messages are now logged with WARN level before cleared from session.
> Better warning of design errors during development
> --------------------------------------------------
>
> Key: WICKET-1138
> URL: https://issues.apache.org/jira/browse/WICKET-1138
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Reporter: Brill Pappin
> Assignee: Igor Vaynberg
> Fix For: 1.4-M4
>
>
> As suggested in this list post:
> http://www.nabble.com/Form%3A-onSubmit-not-called-tf4763217.html#a13659761
> > Although it was my own fault hands down (silly me didn't write a test first)
> > I'm thinking that I could have saved hours with some sort of indication...
> > now that its happened once the lesson is pretty clear, but a lot of people
> > are going to stumble over stuff like that when they first get into Wicket.
> Yeah. If you can open up a JIRA issue for it, we can think/ discuss
> what we could do here.
> Eelco
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1138) Better warning of design errors
during development
Posted by "Martijn Dashorst (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martijn Dashorst updated WICKET-1138:
-------------------------------------
Fix Version/s: (was: 1.3.1)
1.4-M1
Affects Version/s: (was: 1.3.0-beta4)
> Better warning of design errors during development
> --------------------------------------------------
>
> Key: WICKET-1138
> URL: https://issues.apache.org/jira/browse/WICKET-1138
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Reporter: Brill Pappin
> Assignee: Eelco Hillenius
> Fix For: 1.4-M1
>
>
> As suggested in this list post:
> http://www.nabble.com/Form%3A-onSubmit-not-called-tf4763217.html#a13659761
> > Although it was my own fault hands down (silly me didn't write a test first)
> > I'm thinking that I could have saved hours with some sort of indication...
> > now that its happened once the lesson is pretty clear, but a lot of people
> > are going to stumble over stuff like that when they first get into Wicket.
> Yeah. If you can open up a JIRA issue for it, we can think/ discuss
> what we could do here.
> Eelco
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.