You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ki...@apache.org on 2013/02/12 22:34:48 UTC
svn commit: r1445397 - in /commons/proper/functor/trunk: build-tools/pom.xml
pom.xml
Author: kinow
Date: Tue Feb 12 21:34:47 2013
New Revision: 1445397
URL: http://svn.apache.org/r1445397
Log:
Setting groupId org.apache.commons in parent POM, and removing it from modules
Modified:
commons/proper/functor/trunk/build-tools/pom.xml
commons/proper/functor/trunk/pom.xml
Modified: commons/proper/functor/trunk/build-tools/pom.xml
URL: http://svn.apache.org/viewvc/commons/proper/functor/trunk/build-tools/pom.xml?rev=1445397&r1=1445396&r2=1445397&view=diff
==============================================================================
--- commons/proper/functor/trunk/build-tools/pom.xml (original)
+++ commons/proper/functor/trunk/build-tools/pom.xml Tue Feb 12 21:34:47 2013
@@ -21,9 +21,7 @@
<version>9</version>
</parent>
<modelVersion>4.0.0</modelVersion>
- <groupId>org.apache.commons</groupId>
<artifactId>commons-functor-build-tools</artifactId>
- <version>1.0-SNAPSHOT</version>
<name>Commons Functor Build Tools</name>
<description>Provide common setup, from http://maven.apache.org/plugins/maven-checkstyle-plugin/examples/multi-module-config.html</description>
</project>
Modified: commons/proper/functor/trunk/pom.xml
URL: http://svn.apache.org/viewvc/commons/proper/functor/trunk/pom.xml?rev=1445397&r1=1445396&r2=1445397&view=diff
==============================================================================
--- commons/proper/functor/trunk/pom.xml (original)
+++ commons/proper/functor/trunk/pom.xml Tue Feb 12 21:34:47 2013
@@ -23,6 +23,7 @@
<artifactId>commons-parent</artifactId>
<version>28</version>
</parent>
+ <groupId>org.apache.commons</groupId>
<artifactId>commons-functor-parent</artifactId>
<version>1.0-SNAPSHOT</version>
<packaging>pom</packaging>
Re: svn commit: r1445397 - in /commons/proper/functor/trunk: build-tools/pom.xml pom.xml
Posted by "Bruno P. Kinoshita" <ki...@apache.org>.
> The parent is using groupId org.apache, because it is NOT the functor
> top-level pom.
>
> So it is not possible to default to it.
I didn't see that, my bad. Matt changed the module to be under commons-functor-parent [1]
>> <modelVersion>4.0.0</modelVersion>
>> - <groupId>org.apache.commons</groupId>
>> <artifactId>commons-functor-build-tools</artifactId>
>> - <version>1.0-SNAPSHOT</version>
>
> Why did you remove the version?
> That was not discussed.
I thought it was under commons-functor-parent, and could inherit its version. Since its parent is now commons-functor-parent, I believe it's fine now?
[1] http://svn.apache.org/r1445422
Bruno P. Kinoshita
http://kinoshita.eti.br
http://tupilabs.com
----- Original Message -----
> From: sebb <se...@gmail.com>
> To: dev@commons.apache.org
> Cc:
> Sent: Tuesday, February 12, 2013 8:09 PM
> Subject: Re: svn commit: r1445397 - in /commons/proper/functor/trunk: build-tools/pom.xml pom.xml
>
> On 12 February 2013 21:34, <ki...@apache.org> wrote:
>> Author: kinow
>> Date: Tue Feb 12 21:34:47 2013
>> New Revision: 1445397
>>
>> URL: http://svn.apache.org/r1445397
>> Log:
>> Setting groupId org.apache.commons in parent POM, and removing it from
> modules
>>
>> Modified:
>> commons/proper/functor/trunk/build-tools/pom.xml
>> commons/proper/functor/trunk/pom.xml
>>
>> Modified: commons/proper/functor/trunk/build-tools/pom.xml
>> URL:
> http://svn.apache.org/viewvc/commons/proper/functor/trunk/build-tools/pom.xml?rev=1445397&r1=1445396&r2=1445397&view=diff
>>
> ==============================================================================
>> --- commons/proper/functor/trunk/build-tools/pom.xml (original)
>> +++ commons/proper/functor/trunk/build-tools/pom.xml Tue Feb 12 21:34:47
> 2013
>> @@ -21,9 +21,7 @@
>> <version>9</version>
>> </parent>
>
> The parent is using groupId org.apache, because it is NOT the functor
> top-level pom.
>
> So it is not possible to default to it.
>
>> <modelVersion>4.0.0</modelVersion>
>> - <groupId>org.apache.commons</groupId>
>> <artifactId>commons-functor-build-tools</artifactId>
>> - <version>1.0-SNAPSHOT</version>
>
> Why did you remove the version?
> That was not discussed.
>
>> <name>Commons Functor Build Tools</name>
>> <description>Provide common setup, from
> http://maven.apache.org/plugins/maven-checkstyle-plugin/examples/multi-module-config.html</description>
>> </project>
>
> -1, the build-tools module changes are wrong.
>
>> Modified: commons/proper/functor/trunk/pom.xml
>> URL:
> http://svn.apache.org/viewvc/commons/proper/functor/trunk/pom.xml?rev=1445397&r1=1445396&r2=1445397&view=diff
>>
> ==============================================================================
>> --- commons/proper/functor/trunk/pom.xml (original)
>> +++ commons/proper/functor/trunk/pom.xml Tue Feb 12 21:34:47 2013
>> @@ -23,6 +23,7 @@
>> <artifactId>commons-parent</artifactId>
>> <version>28</version>
>> </parent>
>> + <groupId>org.apache.commons</groupId>
>
> That's OK.
>
>> <artifactId>commons-functor-parent</artifactId>
>> <version>1.0-SNAPSHOT</version>
>> <packaging>pom</packaging>
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1445397 - in /commons/proper/functor/trunk:
build-tools/pom.xml pom.xml
Posted by sebb <se...@gmail.com>.
On 12 February 2013 21:34, <ki...@apache.org> wrote:
> Author: kinow
> Date: Tue Feb 12 21:34:47 2013
> New Revision: 1445397
>
> URL: http://svn.apache.org/r1445397
> Log:
> Setting groupId org.apache.commons in parent POM, and removing it from modules
>
> Modified:
> commons/proper/functor/trunk/build-tools/pom.xml
> commons/proper/functor/trunk/pom.xml
>
> Modified: commons/proper/functor/trunk/build-tools/pom.xml
> URL: http://svn.apache.org/viewvc/commons/proper/functor/trunk/build-tools/pom.xml?rev=1445397&r1=1445396&r2=1445397&view=diff
> ==============================================================================
> --- commons/proper/functor/trunk/build-tools/pom.xml (original)
> +++ commons/proper/functor/trunk/build-tools/pom.xml Tue Feb 12 21:34:47 2013
> @@ -21,9 +21,7 @@
> <version>9</version>
> </parent>
The parent is using groupId org.apache, because it is NOT the functor
top-level pom.
So it is not possible to default to it.
> <modelVersion>4.0.0</modelVersion>
> - <groupId>org.apache.commons</groupId>
> <artifactId>commons-functor-build-tools</artifactId>
> - <version>1.0-SNAPSHOT</version>
Why did you remove the version?
That was not discussed.
> <name>Commons Functor Build Tools</name>
> <description>Provide common setup, from http://maven.apache.org/plugins/maven-checkstyle-plugin/examples/multi-module-config.html</description>
> </project>
-1, the build-tools module changes are wrong.
> Modified: commons/proper/functor/trunk/pom.xml
> URL: http://svn.apache.org/viewvc/commons/proper/functor/trunk/pom.xml?rev=1445397&r1=1445396&r2=1445397&view=diff
> ==============================================================================
> --- commons/proper/functor/trunk/pom.xml (original)
> +++ commons/proper/functor/trunk/pom.xml Tue Feb 12 21:34:47 2013
> @@ -23,6 +23,7 @@
> <artifactId>commons-parent</artifactId>
> <version>28</version>
> </parent>
> + <groupId>org.apache.commons</groupId>
That's OK.
> <artifactId>commons-functor-parent</artifactId>
> <version>1.0-SNAPSHOT</version>
> <packaging>pom</packaging>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org