[GitHub] [echarts] infacto commented on issue #18198: [Feature] Change theme / dark mode dynamically.

["infacto (via GitHub)" <gi...@apache.org>]

infacto commented on issue #18198:
URL: https://github.com/apache/echarts/issues/18198#issuecomment-1420937979

   Afaik you can only pass the theme via `echarts.init(container, myThemeName)` and `dispose` before new `init`, right? 
   And btw. why is there also a [darkMode](https://echarts.apache.org/en/option.html#darkMode) property in options? In my case it has no effect or just slighly changes some texts. But it's far away from a real dark mode. 
   But anyway, I would expect to set the theme in options or new method. ...
   
   Another suggestion: The default dark theme `init(container, 'dark')` should be more decent in my opinion. The normal (light) theme has no background (transparent). The dark mode has a dark puple blue color. Usually you switch to dark theme, when your app is in dark mode. Means, the HTML container also have a dark background and I would expect a transparent background if the charts to harmonize with my app color. To be honest, I just want a light and dark mode that just changes the color contrast without being too flashy. And easy toggle between these themes without hasle dynamically (not init again).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org