[jira] [Commented] (CB-5942) targetWidth and targetHeight are not being interpreted consistently across platforms

["Shazron Abdullah (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-5942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14140059#comment-14140059 ] 

Shazron Abdullah commented on CB-5942:
--------------------------------------

I would suggest using the table notation here: https://issues.apache.org/jira/secure/WikiRendererHelpAction.jspa?section=tables for your table so it's easy to refer to in this bug without having to open the Excel file from your repo.

Here's the plan (We should break this up into two sub-tasks, one for iOS and one for WP8):

1.  We should support both properties
2. The API should never grow the image
3. The API should shrink the image while maintaining aspect ratio, such that both dimensions of the resized image fit within targetWidth and targetHeight.
4. Use the Android output as the expected output

> targetWidth and targetHeight are not being interpreted consistently across platforms
> ------------------------------------------------------------------------------------
>
>                 Key: CB-5942
>                 URL: https://issues.apache.org/jira/browse/CB-5942
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Camera
>    Affects Versions: 3.0.0, 3.1.0, 3.2.0
>         Environment: iOS, WP8
>            Reporter: John M. Wargo
>
> A while back I posted a question regarding Camera targetWidth & targetHeight properties and how they worked. After some discussion, the conclusion I reached was that the documentation couldn't be correct about how it worked since there was no way to determine the camera's resolution with the current API but the docs said I had to provide both parameters.  I said I'd do some testing and I have finally gotten around to completing it. Here's what I discovered:
> I created an application that allowed me to pass in different values for targetWidth & targetHeight when taking a picture. I tested at the following image sizes: 640x480, 800x600, 1024x768 as well as setting only the targetWidth to 1024 or only the targetHeight to 768.
> Here's the results:
> Android
> Portrait        Landscape
> 480x640         640x480
> 600x800         800x600
> 768x1024        1024x768
> 768x1024        1024x768
> 768x1024        1024x768
> iOS
> Portrait        Landscape
> 360x480         640x480
> 450x600         800x600
> 576x768         1024x768
> 2448x3264       3264x2448
> 2448x3264       3264x2448
> Windows Phone 8
> Portrait        Landscape
> 1836x3264       3264x1836
> 1836x3264       3264x1836
> 1836x3264       3264x1836
> 1836x3264       3264x1836
> 1836x3264       3264x1836
> As you can see, Android properly implements the targetWidth & targetHeight properties. On iOS, it supports setting both properties, but not instances where only one is specified. Windows Phone 8 ignores the parameters completely.  On iOS, when you turn the device on its side, the Camera API applies the target width or height to the wrong axis (Android does this well however).
> I'm trying to test this on a BlackBerry device, but my development environment is giving me fits right now. I'll work on it in the morning and publish my results when I get them.
> I would suggest that the android implementation is as expected and that the other platforms need their implementations of targetWidth & targetHeight adjusted so it works correctly. The documentation should be updated as well as it's incorrect today specifying that both properties must be provided.
> If the group doesn't want to support only providing one of the properties, then I would expect that the onError callback is called when only one is provided rather than simply ignoring them as is the case with iOS and Windows Phone.
> I posted my sample application and a spreadsheet with my results to https://github.com/johnwargo/camera_res_test
> The concensus on the dev list is the following:
> The API should never grow the image
> The API should shrink the image while maintaining aspect ratio, such that both dimensions of the resized image fit within targetWidth and targetHeight.
> I would propose as well that the API support only one of the parameters or both - the API should understand enough about the image file to maintain aspect ratio, the developer shouldn't have to tell it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)