You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/12/01 08:36:29 UTC

[GitHub] [incubator-mxnet] samskalicky opened a new pull request #19607: Support destructors for custom stateful ops

samskalicky opened a new pull request #19607:
URL: https://github.com/apache/incubator-mxnet/pull/19607


   ## Description ##
   Support destructors for custom stateful ops
   - Adds virtual destructor for CustomStatefulOp base class
   - Calls delete on customStatefulOp instance in CustomStatefulOpWrapper destructor
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19607: Support destructors for custom stateful ops

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19607:
URL: https://github.com/apache/incubator-mxnet/pull/19607#issuecomment-736312420


   Hey @samskalicky , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [windows-gpu, sanity, windows-cpu, centos-gpu, edge, miscellaneous, unix-cpu, website, clang, centos-cpu, unix-gpu]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] samskalicky merged pull request #19607: Support destructors for custom stateful ops

Posted by GitBox <gi...@apache.org>.
samskalicky merged pull request #19607:
URL: https://github.com/apache/incubator-mxnet/pull/19607


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] samskalicky commented on pull request #19607: Support destructors for custom stateful ops

Posted by GitBox <gi...@apache.org>.
samskalicky commented on pull request #19607:
URL: https://github.com/apache/incubator-mxnet/pull/19607#issuecomment-736315431


   FYI @rondogency


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org