You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/04 10:22:25 UTC
[GitHub] [skywalking] cngdkxw opened a new pull request #4443:
ClassCastException
cngdkxw opened a new pull request #4443: ClassCastException
URL: https://github.com/apache/skywalking/pull/4443
org.apache.skywalking.apm.plugin.spring.resttemplate.async.FutureGetInterceptor throw ClassCastException
before fix bug picture
after fix bug picture
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4443: ClassCastException
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4443: ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#issuecomment-594979937
I have asked @ascrutae to take a look. But in the process, I expect you to follow this doc https://github.com/apache/skywalking/blob/master/docs/README.md to provide rest-templete sync and async cases in the PR, which is missed before.
You could take reference from many existing tests at here, https://github.com/apache/skywalking/tree/master/test/plugin/scenarios
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4443:
RestTemplate async plugin ClassCastException
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4443: RestTemplate async plugin ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#issuecomment-596177065
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=h1) Report
> Merging [#4443](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/ff1ddb89d70a4024de1ed8643df590f8bc682dd9&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4443 +/- ##
=======================================
Coverage 25.52% 25.52%
=======================================
Files 1244 1244
Lines 28843 28843
Branches 3944 3944
=======================================
Hits 7363 7363
Misses 20801 20801
Partials 679 679
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=footer). Last update [ff1ddb8...ff1ddb8](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] dmsolr commented on issue #4443: ClassCastException
Posted by GitBox <gi...@apache.org>.
dmsolr commented on issue #4443: ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#issuecomment-594453285
Do you miss some files in PR? How can Object[] cast to Object?
Please make CI work right first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] cngdkxw commented on issue #4443: RestTemplate async
plugin ClassCastException
Posted by GitBox <gi...@apache.org>.
cngdkxw commented on issue #4443: RestTemplate async plugin ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#issuecomment-597172354
ok, I will
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4443:
RestTemplate async plugin ClassCastException
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4443: RestTemplate async plugin ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#discussion_r390050369
##########
File path: test/plugin/scenarios/resttemplate-4.x-scenario/support-version.list
##########
@@ -0,0 +1,34 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+4.3.8.RELEASE
Review comment:
The Supported-list.md in the doc says otherwise. Is there an incompatible change? Could you explain a little about this? Is the old implementation for old versions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4443: RestTemplate async
plugin ClassCastException
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4443: RestTemplate async plugin ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#issuecomment-597527424
> How can i download the image skywalking/agent-test-tomcat.
It is packaged locally. Run the command you put in the CI control file, all things run automatically on MacOS and Linux.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4443:
RestTemplate async plugin ClassCastException
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4443: RestTemplate async plugin ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#issuecomment-596177065
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=h1) Report
> Merging [#4443](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/74b0af9d85aa66e2666e98719b0a8c255c8cd934?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4443 +/- ##
==========================================
- Coverage 24.97% 24.94% -0.03%
==========================================
Files 1231 1231
Lines 28504 28504
Branches 3907 3907
==========================================
- Hits 7118 7111 -7
- Misses 20727 20734 +7
Partials 659 659
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...pring/resttemplate/async/FutureGetInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4443/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvcmVzdHRlbXBsYXRlLTQueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9zcHJpbmcvcmVzdHRlbXBsYXRlL2FzeW5jL0Z1dHVyZUdldEludGVyY2VwdG9yLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...walking/oap/server/core/analysis/Downsampling.java](https://codecov.io/gh/apache/skywalking/pull/4443/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93bnNhbXBsaW5nLmphdmE=) | `0% <0%> (-100%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=footer). Last update [74b0af9...d07e598](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] cngdkxw commented on issue #4443: RestTemplate async
plugin ClassCastException
Posted by GitBox <gi...@apache.org>.
cngdkxw commented on issue #4443: RestTemplate async plugin ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#issuecomment-598012954
In rest template 4.0-4.2 scenario tests, not found segments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] cngdkxw commented on issue #4443: ClassCastException
Posted by GitBox <gi...@apache.org>.
cngdkxw commented on issue #4443: ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#issuecomment-594552495
I find objInst.getSkyWalkingDynamicField() return EnhanceCacheObjects in debug.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4443:
RestTemplate async plugin ClassCastException
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4443: RestTemplate async plugin ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#discussion_r389382780
##########
File path: test/plugin/scenarios/resttemplate-4.x-scenario/support-version.list
##########
@@ -0,0 +1,38 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+1.5.0.RELEASE
Review comment:
Please correct me if I am wrong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4443:
RestTemplate async plugin ClassCastException
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4443: RestTemplate async plugin ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#discussion_r389382750
##########
File path: test/plugin/scenarios/resttemplate-4.x-scenario/support-version.list
##########
@@ -0,0 +1,38 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+1.5.0.RELEASE
Review comment:
Yes, I read that, and that is my question. Why we set these versions? We are testing different rest template versions, not spring versions. We should be able to use maven to set explicit rest template versions and use the same spring version at the same time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4443:
RestTemplate async plugin ClassCastException
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4443: RestTemplate async plugin ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#issuecomment-596177065
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=h1) Report
> Merging [#4443](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cbc692908fae97d44b4520eaa334efbd0c7f00f1?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4443 +/- ##
=======================================
Coverage 24.94% 24.94%
=======================================
Files 1231 1231
Lines 28504 28504
Branches 3907 3907
=======================================
Hits 7111 7111
Misses 20734 20734
Partials 659 659
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...pring/resttemplate/async/FutureGetInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4443/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvcmVzdHRlbXBsYXRlLTQueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9zcHJpbmcvcmVzdHRlbXBsYXRlL2FzeW5jL0Z1dHVyZUdldEludGVyY2VwdG9yLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=footer). Last update [cbc6929...e02be79](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4443:
ClassCastException
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4443: ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#issuecomment-596177065
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=h1) Report
> Merging [#4443](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/0439dccc3054a342d92a160f4e60352eba9ce4e5?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4443 +/- ##
=======================================
Coverage 24.97% 24.97%
=======================================
Files 1230 1230
Lines 28490 28490
Branches 3906 3906
=======================================
Hits 7115 7115
Misses 20718 20718
Partials 657 657
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...pring/resttemplate/async/FutureGetInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4443/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvcmVzdHRlbXBsYXRlLTQueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9zcHJpbmcvcmVzdHRlbXBsYXRlL2FzeW5jL0Z1dHVyZUdldEludGVyY2VwdG9yLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=footer). Last update [0439dcc...6673c3d](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4443: RestTemplate async
plugin ClassCastException
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4443: RestTemplate async plugin ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#issuecomment-597965828
So, the rest template 4.0-4.2 are not supported, could you share why? Is there something incompatible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4443:
RestTemplate async plugin ClassCastException
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4443: RestTemplate async plugin ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#discussion_r390115650
##########
File path: test/plugin/scenarios/resttemplate-4.x-scenario/support-version.list
##########
@@ -0,0 +1,34 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+4.3.8.RELEASE
Review comment:
OK. Work for me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng edited a comment on issue #4443:
ClassCastException
Posted by GitBox <gi...@apache.org>.
wu-sheng edited a comment on issue #4443: ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#issuecomment-594979937
I have asked @ascrutae to take a look. But in the process, I expect you to follow this doc https://github.com/apache/skywalking/blob/master/docs/en/guides/Plugin-test.md to provide rest-templete sync and async cases in the PR, which is missed before.
You could take reference from many existing tests at here, https://github.com/apache/skywalking/tree/master/test/plugin/scenarios
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] cngdkxw commented on a change in pull request #4443:
RestTemplate async plugin ClassCastException
Posted by GitBox <gi...@apache.org>.
cngdkxw commented on a change in pull request #4443: RestTemplate async plugin ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#discussion_r390060129
##########
File path: test/plugin/scenarios/resttemplate-4.x-scenario/config/expectedData.yaml
##########
@@ -19,11 +19,29 @@ registryItems:
instances:
- {resttemplate-4.x-scenario: 1}
operationNames:
- - resttemplate-4.x-scenario: [/resttemplate/case/resttemplate, /resttemplate/back]
+ - resttemplate-4.x-scenario: [/resttemplate/case/healthcheck, /resttemplate/case/resttemplate, /resttemplate/back]
Review comment:
okay
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4443:
RestTemplate async plugin ClassCastException
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4443: RestTemplate async plugin ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#discussion_r390034447
##########
File path: test/plugin/scenarios/resttemplate-4.x-scenario/src/main/java/org/apache/skywalking/testcase/resttemplate/FrontController.java
##########
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.testcase.resttemplate;
+
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.http.ResponseEntity;
+import org.springframework.util.concurrent.ListenableFuture;
+import org.springframework.web.bind.annotation.GetMapping;
+import org.springframework.web.bind.annotation.RequestMapping;
+import org.springframework.web.bind.annotation.RestController;
+import org.springframework.web.client.AsyncRestTemplate;
+import org.springframework.web.client.RestTemplate;
+
+@RestController
+@RequestMapping("/resttemplate/case")
+public class FrontController {
+
+ private static Logger logger = LogManager.getLogger(FrontController.class);
+
+ @Autowired
+ private AsyncRestTemplate asyncRestTemplate;
+
+ @Autowired
+ private RestTemplate restTemplate;
+
+ @GetMapping("/healthcheck")
+ public String healthcheck() {
+ return "Success";
+ }
+
+ @GetMapping("/resttemplate")
+ public String front() {
+ asyncRequest("http://127.0.0.1:8080/resttemplate/back");
+ syncRequest("http://127.0.0.1:8080/resttemplate/back");
Review comment:
As your tests called `Resttemplate`, could do add a sync request here and in the expected data file too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] cngdkxw closed pull request #4443: RestTemplate async
plugin ClassCastException
Posted by GitBox <gi...@apache.org>.
cngdkxw closed pull request #4443: RestTemplate async plugin ClassCastException
URL: https://github.com/apache/skywalking/pull/4443
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4443: RestTemplate async
plugin ClassCastException
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4443: RestTemplate async plugin ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#issuecomment-597487988
Your tests are still failing, please recheck.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4443:
RestTemplate async plugin ClassCastException
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4443: RestTemplate async plugin ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#discussion_r389375403
##########
File path: test/plugin/scenarios/resttemplate-4.x-scenario/support-version.list
##########
@@ -0,0 +1,38 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+1.5.0.RELEASE
Review comment:
I am confused, the plugin called restteamplate 4.x, why all these versions are `1.5.x`? From test/plugin/scenarios/resttemplate-4.x-scenario/pom.xml, you are switching the spring boot version.
Could you explain why?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] cngdkxw commented on a change in pull request #4443:
RestTemplate async plugin ClassCastException
Posted by GitBox <gi...@apache.org>.
cngdkxw commented on a change in pull request #4443: RestTemplate async plugin ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#discussion_r390060259
##########
File path: test/plugin/scenarios/resttemplate-4.x-scenario/support-version.list
##########
@@ -0,0 +1,34 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+4.3.8.RELEASE
Review comment:
Later, I will take the time to write a non-springboot project and test it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4443: RestTemplate async
plugin ClassCastException
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4443: RestTemplate async plugin ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#issuecomment-598552300
@cngdkxw What do you do? I found the PR closed by you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] cngdkxw commented on issue #4443: RestTemplate async
plugin ClassCastException
Posted by GitBox <gi...@apache.org>.
cngdkxw commented on issue #4443: RestTemplate async plugin ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#issuecomment-597523524
How can i download the image skywalking/agent-test-tomcat.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4443:
ClassCastException
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4443: ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#issuecomment-596177065
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=h1) Report
> Merging [#4443](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/0439dccc3054a342d92a160f4e60352eba9ce4e5?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4443 +/- ##
=======================================
Coverage 24.97% 24.97%
=======================================
Files 1230 1230
Lines 28490 28490
Branches 3906 3906
=======================================
Hits 7115 7115
Misses 20718 20718
Partials 657 657
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...pring/resttemplate/async/FutureGetInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4443/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvcmVzdHRlbXBsYXRlLTQueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9zcHJpbmcvcmVzdHRlbXBsYXRlL2FzeW5jL0Z1dHVyZUdldEludGVyY2VwdG9yLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=footer). Last update [0439dcc...6144019](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4443: ClassCastException
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4443: ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#issuecomment-594556820
Reading `RestExecuteInterceptor`
> Object[] cacheValues = (Object[]) objInst.getSkyWalkingDynamicField();
All codes show the dynamic field is an object array.
And look at your CI, all fails.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] cngdkxw commented on issue #4443: ClassCastException
Posted by GitBox <gi...@apache.org>.
cngdkxw commented on issue #4443: ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#issuecomment-594996035
In this weekend, I will provide rest-templete sync and async cases in the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] cngdkxw commented on a change in pull request #4443:
RestTemplate async plugin ClassCastException
Posted by GitBox <gi...@apache.org>.
cngdkxw commented on a change in pull request #4443: RestTemplate async plugin ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#discussion_r389379775
##########
File path: test/plugin/scenarios/resttemplate-4.x-scenario/support-version.list
##########
@@ -0,0 +1,38 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+1.5.0.RELEASE
Review comment:
`<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-web</artifactId>
<version>${test.framework.version}</version>
</dependency>`
In resttemplate scenario, use this denpendency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4443: RestTemplate async
plugin ClassCastException
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4443: RestTemplate async plugin ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#issuecomment-598016075
> In rest template 4.0-4.2 scenario tests, not found segments.
@cngdkxw Have you read the rest template source codes of those versions? I think we may need to determine what is real difference.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4443:
ClassCastException
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4443: ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#discussion_r389359414
##########
File path: .github/workflows/plugins-test.yaml
##########
@@ -300,6 +300,8 @@ jobs:
run: ./mvnw --batch-mode -f test/plugin/pom.xml clean package -DskipTests docker:build -DBUILD_NO=local >/dev/null
- name: Run spring 4.1.x-4.2.x (20)
run: bash test/plugin/run.sh spring-4.1.x-scenario
+ - name: Run resttemplate 1.5.0.RELEASE-1.5.22.RELEASE (23)
Review comment:
https://github.com/apache/skywalking/blob/47c84deea7f534f4cbb37d3b089b4b2d0ca4a4c7/.github/workflows/plugins-test.yaml#L275
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4443:
RestTemplate async plugin ClassCastException
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4443: RestTemplate async plugin ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#discussion_r389375496
##########
File path: test/plugin/scenarios/resttemplate-4.x-scenario/support-version.list
##########
@@ -0,0 +1,38 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+1.5.0.RELEASE
Review comment:
From the plugin pom codes, clearly, it is spring version of 4.x
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] cngdkxw commented on a change in pull request #4443:
RestTemplate async plugin ClassCastException
Posted by GitBox <gi...@apache.org>.
cngdkxw commented on a change in pull request #4443: RestTemplate async plugin ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#discussion_r390049841
##########
File path: test/plugin/scenarios/resttemplate-4.x-scenario/support-version.list
##########
@@ -0,0 +1,34 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+4.3.8.RELEASE
Review comment:
no support
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4443: ClassCastException
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4443: ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#issuecomment-596177065
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=h1) Report
> Merging [#4443](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/0439dccc3054a342d92a160f4e60352eba9ce4e5?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4443 +/- ##
=======================================
Coverage 24.97% 24.97%
=======================================
Files 1230 1230
Lines 28490 28490
Branches 3906 3906
=======================================
Hits 7115 7115
Misses 20718 20718
Partials 657 657
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...pring/resttemplate/async/FutureGetInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4443/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvcmVzdHRlbXBsYXRlLTQueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9zcHJpbmcvcmVzdHRlbXBsYXRlL2FzeW5jL0Z1dHVyZUdldEludGVyY2VwdG9yLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=footer). Last update [0439dcc...6144019](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4443:
RestTemplate async plugin ClassCastException
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4443: RestTemplate async plugin ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#discussion_r390034203
##########
File path: test/plugin/scenarios/resttemplate-4.x-scenario/support-version.list
##########
@@ -0,0 +1,34 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+4.3.8.RELEASE
Review comment:
Does this plugin support 4.0, 4.1, 4.2? If so, please add some(not need to add all) to the tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4443: ClassCastException
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4443: ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#issuecomment-596197005
Your test cases fail. Please recheck.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4443:
ClassCastException
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4443: ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#discussion_r389342840
##########
File path: test/plugin/scenarios/resttemplate-4.x-scenario/support-version.list
##########
@@ -0,0 +1,16 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+1.5.9.RELEASE
Review comment:
Should be multiple versions, included all supported ones. How many versions are there?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4443:
RestTemplate async plugin ClassCastException
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4443: RestTemplate async plugin ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#discussion_r390033896
##########
File path: test/plugin/scenarios/resttemplate-4.x-scenario/config/expectedData.yaml
##########
@@ -0,0 +1,125 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+registryItems:
+ services:
+ - {resttemplate-4.x-scenario: nq 0}
+ instances:
+ - {resttemplate-4.x-scenario: 1}
+ operationNames:
+ - resttemplate-4.x-scenario: [/resttemplate/case/resttemplate, /resttemplate/back]
+segmentItems:
+- serviceName: resttemplate-4.x-scenario
+ segmentSize: ge 3
+ segments:
+ - segmentId: not null
+ spans:
+ - operationName: /resttemplate/back
+ operationId: 0
+ parentSpanId: -1
+ spanId: 0
+ spanLayer: Http
+ startTime: nq 0
+ endTime: nq 0
+ componentId: not null
+ componentName: ''
+ isError: false
+ spanType: Entry
+ peer: ''
+ peerId: 0
+ tags:
+ - {key: url, value: 'http://127.0.0.1:8080/resttemplate/back' }
+ - {key: http.method, value: GET }
+ - segmentId: not null
Review comment:
You miss the reference check for these two entry spans.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng edited a comment on issue #4443: RestTemplate
async plugin ClassCastException
Posted by GitBox <gi...@apache.org>.
wu-sheng edited a comment on issue #4443: RestTemplate async plugin ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#issuecomment-596215029
We used to support
- [Spring RestTemplete](https://github.com/spring-projects/spring-framework) 4.x
Are you trying to add supports to 1.5.x?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4443:
ClassCastException
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4443: ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#discussion_r389359301
##########
File path: .github/workflows/plugins-test.yaml
##########
@@ -300,6 +300,8 @@ jobs:
run: ./mvnw --batch-mode -f test/plugin/pom.xml clean package -DskipTests docker:build -DBUILD_NO=local >/dev/null
- name: Run spring 4.1.x-4.2.x (20)
run: bash test/plugin/run.sh spring-4.1.x-scenario
+ - name: Run resttemplate 1.5.0.RELEASE-1.5.22.RELEASE (23)
Review comment:
Name is not right. Notice, There is another group name. You should change that too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4443: RestTemplate async
plugin ClassCastException
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4443: RestTemplate async plugin ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#issuecomment-598553033
I can't merge now. Do you delete anything.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4443:
RestTemplate async plugin ClassCastException
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4443: RestTemplate async plugin ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#discussion_r390060421
##########
File path: test/plugin/scenarios/resttemplate-4.x-scenario/src/main/java/org/apache/skywalking/testcase/resttemplate/FrontController.java
##########
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.testcase.resttemplate;
+
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.http.ResponseEntity;
+import org.springframework.util.concurrent.ListenableFuture;
+import org.springframework.web.bind.annotation.GetMapping;
+import org.springframework.web.bind.annotation.RequestMapping;
+import org.springframework.web.bind.annotation.RestController;
+import org.springframework.web.client.AsyncRestTemplate;
+import org.springframework.web.client.RestTemplate;
+
+@RestController
+@RequestMapping("/resttemplate/case")
+public class FrontController {
+
+ private static Logger logger = LogManager.getLogger(FrontController.class);
+
+ @Autowired
+ private AsyncRestTemplate asyncRestTemplate;
+
+ @Autowired
+ private RestTemplate restTemplate;
+
+ @GetMapping("/healthcheck")
+ public String healthcheck() {
+ return "Success";
+ }
+
+ @GetMapping("/resttemplate")
+ public String front() {
+ asyncRequest("http://127.0.0.1:8080/resttemplate/back");
+ syncRequest("http://127.0.0.1:8080/resttemplate/back");
Review comment:
Yes, that is point, the sync request should be tested too, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4443:
ClassCastException
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4443: ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#issuecomment-596177065
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=h1) Report
> Merging [#4443](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/74b0af9d85aa66e2666e98719b0a8c255c8cd934?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4443 +/- ##
==========================================
- Coverage 24.97% 24.94% -0.03%
==========================================
Files 1231 1231
Lines 28504 28504
Branches 3907 3907
==========================================
- Hits 7118 7110 -8
- Misses 20727 20734 +7
- Partials 659 660 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...pring/resttemplate/async/FutureGetInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4443/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvcmVzdHRlbXBsYXRlLTQueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9zcHJpbmcvcmVzdHRlbXBsYXRlL2FzeW5jL0Z1dHVyZUdldEludGVyY2VwdG9yLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...walking/oap/server/core/analysis/Downsampling.java](https://codecov.io/gh/apache/skywalking/pull/4443/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93bnNhbXBsaW5nLmphdmE=) | `0% <0%> (-100%)` | :arrow_down: |
| [.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/4443/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=) | `24.73% <0%> (-1.08%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=footer). Last update [74b0af9...47c84de](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] cngdkxw commented on a change in pull request #4443:
RestTemplate async plugin ClassCastException
Posted by GitBox <gi...@apache.org>.
cngdkxw commented on a change in pull request #4443: RestTemplate async plugin ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#discussion_r390052384
##########
File path: test/plugin/scenarios/resttemplate-4.x-scenario/src/main/java/org/apache/skywalking/testcase/resttemplate/FrontController.java
##########
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.testcase.resttemplate;
+
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.http.ResponseEntity;
+import org.springframework.util.concurrent.ListenableFuture;
+import org.springframework.web.bind.annotation.GetMapping;
+import org.springframework.web.bind.annotation.RequestMapping;
+import org.springframework.web.bind.annotation.RestController;
+import org.springframework.web.client.AsyncRestTemplate;
+import org.springframework.web.client.RestTemplate;
+
+@RestController
+@RequestMapping("/resttemplate/case")
+public class FrontController {
+
+ private static Logger logger = LogManager.getLogger(FrontController.class);
+
+ @Autowired
+ private AsyncRestTemplate asyncRestTemplate;
+
+ @Autowired
+ private RestTemplate restTemplate;
+
+ @GetMapping("/healthcheck")
+ public String healthcheck() {
+ return "Success";
+ }
+
+ @GetMapping("/resttemplate")
+ public String front() {
+ asyncRequest("http://127.0.0.1:8080/resttemplate/back");
+ syncRequest("http://127.0.0.1:8080/resttemplate/back");
Review comment:
One call contains both sync and async requests, the expecedData.yaml file contains also sync request result.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4443:
RestTemplate async plugin ClassCastException
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4443: RestTemplate async plugin ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#issuecomment-596177065
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=h1) Report
> Merging [#4443](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/fdb816c799d468458c51ee019916b9afb75e4528?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4443 +/- ##
=======================================
Coverage 25.55% 25.55%
=======================================
Files 1244 1244
Lines 28843 28843
Branches 3944 3944
=======================================
Hits 7371 7371
Misses 20794 20794
Partials 678 678
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...pring/resttemplate/async/FutureGetInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4443/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvcmVzdHRlbXBsYXRlLTQueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9zcHJpbmcvcmVzdHRlbXBsYXRlL2FzeW5jL0Z1dHVyZUdldEludGVyY2VwdG9yLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=footer). Last update [fdb816c...b449970](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4443: ClassCastException
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4443: ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#issuecomment-594996305
@dmsolr will update this part and some name of the expected YAML in these days, I will ping you if that PR raised.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] cngdkxw commented on issue #4443: ClassCastException
Posted by GitBox <gi...@apache.org>.
cngdkxw commented on issue #4443: ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#issuecomment-594614603
> Reading `RestExecuteInterceptor`
>
> > Object[] cacheValues = (Object[]) objInst.getSkyWalkingDynamicField();
>
> All codes show the dynamic field is an object array.
>
> And look at your CI, all fails.
Reading RestExecuteInterceptor, in afterMethod method, I find `((EnhancedInstance) ret).setSkyWalkingDynamicField(new EnhanceCacheObjects(uri, ComponentsDefine.SPRING_REST_TEMPLATE, SpanLayer.HTTP, (ContextSnapshot) cacheValues[2])); `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4443: RestTemplate async
plugin ClassCastException
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4443: RestTemplate async plugin ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#issuecomment-597097123
@cngdkxw There are two required changed, could you fix them, then we could merge this into the 7.0.0 release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4443: RestTemplate async
plugin ClassCastException
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4443: RestTemplate async plugin ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#issuecomment-596215029
We used to supported
- [Spring RestTemplete](https://github.com/spring-projects/spring-framework) 4.x
Are you trying to add supports to 1.5.x?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4443:
RestTemplate async plugin ClassCastException
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4443: RestTemplate async plugin ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#discussion_r390059176
##########
File path: test/plugin/scenarios/resttemplate-4.x-scenario/config/expectedData.yaml
##########
@@ -19,11 +19,29 @@ registryItems:
instances:
- {resttemplate-4.x-scenario: 1}
operationNames:
- - resttemplate-4.x-scenario: [/resttemplate/case/resttemplate, /resttemplate/back]
+ - resttemplate-4.x-scenario: [/resttemplate/case/healthcheck, /resttemplate/case/resttemplate, /resttemplate/back]
Review comment:
`/resttemplate/case/healthcheck` should not be added into here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4443: RestTemplate async
plugin ClassCastException
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4443: RestTemplate async plugin ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#issuecomment-598526403
Thanks for following the review. Prepare to merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4443:
RestTemplate async plugin ClassCastException
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4443: RestTemplate async plugin ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#issuecomment-596177065
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=h1) Report
> Merging [#4443](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/74b0af9d85aa66e2666e98719b0a8c255c8cd934?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4443 +/- ##
==========================================
- Coverage 24.97% 24.96% -0.01%
==========================================
Files 1231 1231
Lines 28504 28504
Branches 3907 3907
==========================================
- Hits 7118 7117 -1
Misses 20727 20727
- Partials 659 660 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...pring/resttemplate/async/FutureGetInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4443/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvcmVzdHRlbXBsYXRlLTQueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9zcHJpbmcvcmVzdHRlbXBsYXRlL2FzeW5jL0Z1dHVyZUdldEludGVyY2VwdG9yLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/4443/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=) | `24.73% <0%> (-1.08%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=footer). Last update [74b0af9...d07e598](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4443: ClassCastException
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4443: ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#issuecomment-596154964
As #4458 merged, the expected YAML file has fields been renamed. Take a look the PR and updated plugin test doc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4443:
RestTemplate async plugin ClassCastException
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4443: RestTemplate async plugin ClassCastException
URL: https://github.com/apache/skywalking/pull/4443#discussion_r390838479
##########
File path: .github/workflows/plugins-test.yaml
##########
@@ -306,6 +306,8 @@ jobs:
run: ./mvnw --batch-mode -f test/plugin/pom.xml clean package -DskipTests docker:build -DBUILD_NO=local >/dev/null
- name: Run spring 4.1.x-4.2.x (20)
run: bash test/plugin/run.sh spring-4.1.x-scenario
+ - name: Run resttemplate 4.0.0.RELEASE-4.3.26.RELEASE (57)
+ run: bash test/plugin/run.sh resttemplate-4.x-scenario
Review comment:
This line triggers all things including image build.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services