You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "baulea (via GitHub)" <gi...@apache.org> on 2025/01/11 17:57:20 UTC
Re: [PR] [IO-783] Remove NTFS ADS separator check in FilenameUtils.getExtension [commons-io]
baulea commented on PR #629:
URL: https://github.com/apache/commons-io/pull/629#issuecomment-2585357837
@garydgregory
In https://issues.apache.org/jira/projects/IO/issues/IO-783 Jochen Wiedmann pointed out, that filenames like "C:file.txt" without backslash are valid under Windows (relative path from current directory).
But currently `FilenameUtils.getExtension("C:file.txt")` and `FilenameUtils.indexOfExtension("C:file.txt")` throw an IllegalArgumentException because of the NTFS ADS separator check.
Would you please rethink, if that shouldn't be fixed?
If you agree, I could create a revised pull request, which adds unit tests for this case and also removes private methods now being superfluous. You might check the diff here: https://github.com/baulea/commons-io/commit/31b73aee1075f75fbdcc0a9876562158f1edab6d
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org