Re: [PR] Add EVDP SDW if EVDP is not both [daffodil]

["olabusayoT (via GitHub)" <gi...@apache.org>]

olabusayoT commented on code in PR #1577:
URL: https://github.com/apache/daffodil/pull/1577#discussion_r2524274512


##########
daffodil-core/src/main/scala/org/apache/daffodil/core/grammar/ElementBaseGrammarMixin.scala:
##########
@@ -81,6 +82,20 @@ trait ElementBaseGrammarMixin
     }
   }
 
+  final lazy val checkDelimitedLengthEVDP: Unit = {
+    if (
+      optionEmptyValueDelimiterPolicy.isDefined
+      && emptyValueDelimiterPolicy != EmptyValueDelimiterPolicy.Both
+      && (hasInitiator || hasTerminator)
+    ) {
+      SDW(
+        WarnID.EmptyValueDelimiterPolicyWarning,
+        "dfdl:emptyValueDelimiterPolicy='%s' will be ignored as it's only implemented for 'both'",

Review Comment:
   Right as Steve mentioned, setting this to SDE results in many failures in our test suite, most concerning is the IBM ones because we can't update the evdp...so that's why we SDW. I will update the tunable to strict/lax instead of a boolean (with lax being the default), and note in the SDW that we will eventually move to strict



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org