You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Nathaniel Cook (JIRA)" <ji...@apache.org> on 2012/11/27 18:43:58 UTC
[jira] [Created] (THRIFT-1761) Make generated exceptions have a
common unique parent
Nathaniel Cook created THRIFT-1761:
--------------------------------------
Summary: Make generated exceptions have a common unique parent
Key: THRIFT-1761
URL: https://issues.apache.org/jira/browse/THRIFT-1761
Project: Thrift
Issue Type: Improvement
Reporter: Nathaniel Cook
It would be nice to be able to have exceptions that are thrown by services be caught independently of other thrift exceptions. Currently generated exceptions extend TException directly. They should extend a TServiceException which in turn extends TException. This would allow client code to catch all exceptions thrown by the service without catching exceptions related to the actual thrift communication layer
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1761) Make generated exceptions have a
common unique parent
Posted by "Henrique Mendonca (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506675#comment-13506675 ]
Henrique Mendonca commented on THRIFT-1761:
-------------------------------------------
I see your point, it kind of increases the complexity of the things, specially when there is already some synchronisation problem between the different libs, but I'd be probably OK if it. However, I believe those classes should be in reality abstract classes.
Anyway, I looking forward to hear someone else's opinion here too.
Cheers,
Henrique
> Make generated exceptions have a common unique parent
> -----------------------------------------------------
>
> Key: THRIFT-1761
> URL: https://issues.apache.org/jira/browse/THRIFT-1761
> Project: Thrift
> Issue Type: Improvement
> Reporter: Nathaniel Cook
> Labels: exception-handling, exceptions
> Attachments: thrift-1761_php_py_java_cpp_js.patch
>
>
> It would be nice to be able to have exceptions that are thrown by services be caught independently of other thrift exceptions. Currently generated exceptions extend TException directly. They should extend a TServiceException which in turn extends TException. This would allow client code to catch all exceptions thrown by the service without catching exceptions related to the actual thrift communication layer
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1761) Make generated exceptions have a
common unique parent
Posted by "Nathaniel Cook (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nathaniel Cook updated THRIFT-1761:
-----------------------------------
Attachment: thrift-1761_php_py_java_cpp_js.patch
Patch for several languages
> Make generated exceptions have a common unique parent
> -----------------------------------------------------
>
> Key: THRIFT-1761
> URL: https://issues.apache.org/jira/browse/THRIFT-1761
> Project: Thrift
> Issue Type: Improvement
> Reporter: Nathaniel Cook
> Labels: exception-handling, exceptions
> Attachments: thrift-1761_php_py_java_cpp_js.patch
>
>
> It would be nice to be able to have exceptions that are thrown by services be caught independently of other thrift exceptions. Currently generated exceptions extend TException directly. They should extend a TServiceException which in turn extends TException. This would allow client code to catch all exceptions thrown by the service without catching exceptions related to the actual thrift communication layer
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1761) Make generated exceptions have a
common unique parent
Posted by "Nathaniel Cook (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nathaniel Cook updated THRIFT-1761:
-----------------------------------
Comment: was deleted
(was: Patch off of trunk for several languages:
java
javame
js
py
php
cpp
)
> Make generated exceptions have a common unique parent
> -----------------------------------------------------
>
> Key: THRIFT-1761
> URL: https://issues.apache.org/jira/browse/THRIFT-1761
> Project: Thrift
> Issue Type: Improvement
> Reporter: Nathaniel Cook
> Labels: exception-handling, exceptions
>
> It would be nice to be able to have exceptions that are thrown by services be caught independently of other thrift exceptions. Currently generated exceptions extend TException directly. They should extend a TServiceException which in turn extends TException. This would allow client code to catch all exceptions thrown by the service without catching exceptions related to the actual thrift communication layer
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1761) Make generated exceptions have a
common unique parent
Posted by "Nathaniel Cook (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nathaniel Cook updated THRIFT-1761:
-----------------------------------
Attachment: (was: thrift-1761_php_py_java_cpp_js.patch)
> Make generated exceptions have a common unique parent
> -----------------------------------------------------
>
> Key: THRIFT-1761
> URL: https://issues.apache.org/jira/browse/THRIFT-1761
> Project: Thrift
> Issue Type: Improvement
> Reporter: Nathaniel Cook
> Labels: exception-handling, exceptions
>
> It would be nice to be able to have exceptions that are thrown by services be caught independently of other thrift exceptions. Currently generated exceptions extend TException directly. They should extend a TServiceException which in turn extends TException. This would allow client code to catch all exceptions thrown by the service without catching exceptions related to the actual thrift communication layer
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1761) Make generated exceptions have a
common unique parent
Posted by "Nathaniel Cook (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nathaniel Cook updated THRIFT-1761:
-----------------------------------
Attachment: thrift-1761_php_py_java_cpp_js.patch
Patch off of trunk for several languages:
java
javame
js
py
php
cpp
> Make generated exceptions have a common unique parent
> -----------------------------------------------------
>
> Key: THRIFT-1761
> URL: https://issues.apache.org/jira/browse/THRIFT-1761
> Project: Thrift
> Issue Type: Improvement
> Reporter: Nathaniel Cook
> Labels: exception-handling, exceptions
> Attachments: thrift-1761_php_py_java_cpp_js.patch
>
>
> It would be nice to be able to have exceptions that are thrown by services be caught independently of other thrift exceptions. Currently generated exceptions extend TException directly. They should extend a TServiceException which in turn extends TException. This would allow client code to catch all exceptions thrown by the service without catching exceptions related to the actual thrift communication layer
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1761) Make generated exceptions have a
common unique parent
Posted by "Nathaniel Cook (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nathaniel Cook updated THRIFT-1761:
-----------------------------------
Patch Info: Patch Available
> Make generated exceptions have a common unique parent
> -----------------------------------------------------
>
> Key: THRIFT-1761
> URL: https://issues.apache.org/jira/browse/THRIFT-1761
> Project: Thrift
> Issue Type: Improvement
> Reporter: Nathaniel Cook
> Labels: exception-handling, exceptions
> Attachments: thrift-1761_php_py_java_cpp_js.patch
>
>
> It would be nice to be able to have exceptions that are thrown by services be caught independently of other thrift exceptions. Currently generated exceptions extend TException directly. They should extend a TServiceException which in turn extends TException. This would allow client code to catch all exceptions thrown by the service without catching exceptions related to the actual thrift communication layer
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira