You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Attila Doroszlai <ad...@hortonworks.com> on 2017/11/06 10:36:55 UTC
Re: Review Request 63357: AMBARI-22322. Alert definition support for
multi-service
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63357/
-----------------------------------------------------------
(Updated Nov. 6, 2017, 11:36 a.m.)
Review request for Ambari, Jayush Luniya, Madhuvanthi Radhakrishnan, and Swapan Shridhar.
Changes
-------
rebased
Bugs: AMBARI-22322
https://issues.apache.org/jira/browse/AMBARI-22322
Repository: ambari
Description
-------
* Introduce events for service type addition/removal to signal "first/last service of the same type" events.
* Bind alert definition lifecycle to service type events instead of service events.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java c88c5145d0aa415fb78210084a1acb0a5c169ba7
ambari-server/src/main/java/org/apache/ambari/server/events/ServiceGroupInstalledEvent.java e66d8a002a32336c49fc519a1ffe0676cf75ac12
ambari-server/src/main/java/org/apache/ambari/server/events/ServiceGroupRemovedEvent.java b29a9a4fdc80d2d0bf0f61b10bed19d5483a34c0
ambari-server/src/main/java/org/apache/ambari/server/events/ServiceInstalledEvent.java aa0a5ea8c30594208c574049cd98cd967db25a99
ambari-server/src/main/java/org/apache/ambari/server/events/ServiceTypeAddedEvent.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/events/ServiceTypeEvent.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/events/ServiceTypeRemovedEvent.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertServiceStateListener.java 41ae4e8e9ceab1e1f009b5c44b995b9357f8fe6c
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDispatchDAO.java 5c6a82ffcfa53dfc1dee6fd97e9098c4f1ce56d2
ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 27d37e3c43d572c471a29fa597a93e5f3e45fafe
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionHash.java 025015a3e2bf30d5dfb714a46f3c1998a7183c6a
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 755a80fcc3fead63481b3df9acda858e6235dc64
ambari-server/src/main/java/org/apache/ambari/server/utils/EventBusSynchronizer.java c72ffbe032445fec725db04836d373c5ea15c603
ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java 6ebd444e5541d84043ea8e51d1a2e50eb458b0ee
ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java bd8be3b67225faa2bb33bedbd9fa42cb27dee694
Diff: https://reviews.apache.org/r/63357/diff/2/
Changes: https://reviews.apache.org/r/63357/diff/1-2/
Testing
-------
* Tested multiple service creation/removal manually
* Adjusted `EventsTest` to cover the multiple services scenario
Thanks,
Attila Doroszlai