You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@pivot.apache.org by "Greg Brown (JIRA)" <ji...@apache.org> on 2010/09/11 00:08:33 UTC

[jira] Created: (PIVOT-632) Add a source argument to Action#perform()

Add a source argument to Action#perform()
-----------------------------------------

                 Key: PIVOT-632
                 URL: https://issues.apache.org/jira/browse/PIVOT-632
             Project: Pivot
          Issue Type: Improvement
          Components: wtk
            Reporter: Greg Brown
             Fix For: 1.5.2, 2.0


Without this argument, it is impossible to identify the source object that triggered the action, which makes implementing many application features (particularly menu item handlers) difficult.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Issue Comment Edited: (PIVOT-632) Add a source argument to Action#perform()

Posted by "Greg Brown (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/jira/browse/PIVOT-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12927689#action_12927689 ] 

Greg Brown edited comment on PIVOT-632 at 11/2/10 8:07 PM:
-----------------------------------------------------------

That's true, and in general we try to stay away from breaking API changes like this in a minor release. However, at least one major project required this change, and it's pretty easy to identify and correct, so we decided to go ahead with it.



      was (Author: gbrown):
    That's true, and in general we try to stay away from breaking API changes like this in a minor release. However, at least one major project required this change, so we decided to go ahead with it.


  
> Add a source argument to Action#perform()
> -----------------------------------------
>
>                 Key: PIVOT-632
>                 URL: https://issues.apache.org/jira/browse/PIVOT-632
>             Project: Pivot
>          Issue Type: Improvement
>          Components: wtk
>            Reporter: Greg Brown
>             Fix For: 1.5.2, 2.0
>
>
> Without this argument, it is impossible to identify the source object that triggered the action, which makes implementing many application features (particularly menu item handlers) difficult.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (PIVOT-632) Add a source argument to Action#perform()

Posted by "Greg Brown (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/PIVOT-632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Greg Brown resolved PIVOT-632.
------------------------------

    Resolution: Fixed

> Add a source argument to Action#perform()
> -----------------------------------------
>
>                 Key: PIVOT-632
>                 URL: https://issues.apache.org/jira/browse/PIVOT-632
>             Project: Pivot
>          Issue Type: Improvement
>          Components: wtk
>            Reporter: Greg Brown
>             Fix For: 1.5.2, 2.0
>
>
> Without this argument, it is impossible to identify the source object that triggered the action, which makes implementing many application features (particularly menu item handlers) difficult.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (PIVOT-632) Add a source argument to Action#perform()

Posted by "Greg Brown (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/jira/browse/PIVOT-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12927689#action_12927689 ] 

Greg Brown commented on PIVOT-632:
----------------------------------

That's true, and in general we try to stay away from breaking API changes like this in a minor release. However, at least one major project required this change, so we decided to go ahead with it.



> Add a source argument to Action#perform()
> -----------------------------------------
>
>                 Key: PIVOT-632
>                 URL: https://issues.apache.org/jira/browse/PIVOT-632
>             Project: Pivot
>          Issue Type: Improvement
>          Components: wtk
>            Reporter: Greg Brown
>             Fix For: 1.5.2, 2.0
>
>
> Without this argument, it is impossible to identify the source object that triggered the action, which makes implementing many application features (particularly menu item handlers) difficult.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (PIVOT-632) Add a source argument to Action#perform()

Posted by "Christian Schlichtherle (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/jira/browse/PIVOT-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12927587#action_12927587 ] 

Christian Schlichtherle commented on PIVOT-632:
-----------------------------------------------

Well OK, but changing this in a minor version number release is not a good idea - I just stumbled over this API change.

> Add a source argument to Action#perform()
> -----------------------------------------
>
>                 Key: PIVOT-632
>                 URL: https://issues.apache.org/jira/browse/PIVOT-632
>             Project: Pivot
>          Issue Type: Improvement
>          Components: wtk
>            Reporter: Greg Brown
>             Fix For: 1.5.2, 2.0
>
>
> Without this argument, it is impossible to identify the source object that triggered the action, which makes implementing many application features (particularly menu item handlers) difficult.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.