[GitHub] [superset] dpgaspar commented on a diff in pull request #21180: feat: add snowflake private key support

[GitBox <gi...@apache.org>]

dpgaspar commented on code in PR #21180:
URL: https://github.com/apache/superset/pull/21180#discussion_r958299751


##########
superset/databases/commands/test_connection.py:
##########
@@ -73,8 +74,12 @@ def run(self) -> None:
 
             database.set_sqlalchemy_uri(uri)
             database.db_engine_spec.mutate_db_for_connection_test(database)
-
-            engine = database.get_sqla_engine()
+            
+            engine = None
+            if "snowflake" in str(url) and "privatekey" in str(url):

Review Comment:
   Following @villebro comment, we should avoid having specific engine assertion at this layer, it's also not the most robust solution to search for "snowflake" inside the url str. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org