You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/02 11:26:13 UTC
[GitHub] [flink] wangyang0918 opened a new pull request #11619:
[FLINK-16921][e2e] Make Kubernetes e2e test stable
wangyang0918 opened a new pull request #11619: [FLINK-16921][e2e] Make Kubernetes e2e test stable
URL: https://github.com/apache/flink/pull/11619
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Use the following optimization to make this K8s e2e test more stable both in azure/travis and local.
* Remove start/stop code for non-linux environment, let the user manually start/stop minikube. Since we will encounter various problem in local environment(e.g. Mac), including disk problem, network problem, docker daemon, driver setup(virtualbox, etc.).
* Print more debug information so that when the test failed it is easier to investigate
* Explicitly wait for the dispatcher running and then submit the job to the existing cluster
## Brief change log
* Do not start/stop minikube in non-linux environment for k8s e2e tests
* Print more information for debugging when Kubernetes e2e tests failed
* Wait for rest endpoint up and then submit Flink job to existing Kubernetes session
## Verifying this change
* Run in local environment(Mac) more than 10 times, all should pass
* Run in azure more that 3 times, all should pass
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on issue #11619: [FLINK-16921][e2e]
Make Kubernetes e2e test stable
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on issue #11619: [FLINK-16921][e2e] Make Kubernetes e2e test stable
URL: https://github.com/apache/flink/pull/11619#issuecomment-608287863
@rmetzger It seems that the azure pipeline is cancelled by timeout(4h). The two Kubernetes related tests could always pass in the recent two azure run.
I also have run the test locally more that 10 times. It could always pass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11619:
[FLINK-16921][e2e] Make Kubernetes e2e test stable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11619: [FLINK-16921][e2e] Make Kubernetes e2e test stable
URL: https://github.com/apache/flink/pull/11619#issuecomment-607793023
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68c82eef3469c403b1a0f8a64c13f04d989bf145",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/157750104",
"triggerID" : "68c82eef3469c403b1a0f8a64c13f04d989bf145",
"triggerType" : "PUSH"
}, {
"hash" : "68c82eef3469c403b1a0f8a64c13f04d989bf145",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6989",
"triggerID" : "68c82eef3469c403b1a0f8a64c13f04d989bf145",
"triggerType" : "PUSH"
}, {
"hash" : "6bd37e40b9333d646bbf1bb1fbe286ad21d1e709",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6bd37e40b9333d646bbf1bb1fbe286ad21d1e709",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 68c82eef3469c403b1a0f8a64c13f04d989bf145 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/157750104) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6989)
* 6bd37e40b9333d646bbf1bb1fbe286ad21d1e709 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11619:
[FLINK-16921][e2e] Make Kubernetes e2e test stable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11619: [FLINK-16921][e2e] Make Kubernetes e2e test stable
URL: https://github.com/apache/flink/pull/11619#issuecomment-607793023
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68c82eef3469c403b1a0f8a64c13f04d989bf145",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/157750104",
"triggerID" : "68c82eef3469c403b1a0f8a64c13f04d989bf145",
"triggerType" : "PUSH"
}, {
"hash" : "68c82eef3469c403b1a0f8a64c13f04d989bf145",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6989",
"triggerID" : "68c82eef3469c403b1a0f8a64c13f04d989bf145",
"triggerType" : "PUSH"
}, {
"hash" : "6bd37e40b9333d646bbf1bb1fbe286ad21d1e709",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7013",
"triggerID" : "6bd37e40b9333d646bbf1bb1fbe286ad21d1e709",
"triggerType" : "PUSH"
}, {
"hash" : "6bd37e40b9333d646bbf1bb1fbe286ad21d1e709",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158126927",
"triggerID" : "6bd37e40b9333d646bbf1bb1fbe286ad21d1e709",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6bd37e40b9333d646bbf1bb1fbe286ad21d1e709 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/158126927) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7013)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] rmetzger commented on issue #11619: [FLINK-16921][e2e] Make
Kubernetes e2e test stable
Posted by GitBox <gi...@apache.org>.
rmetzger commented on issue #11619: [FLINK-16921][e2e] Make Kubernetes e2e test stable
URL: https://github.com/apache/flink/pull/11619#issuecomment-608301698
The e2e failure is known: https://issues.apache.org/jira/browse/FLINK-16423
Since the failing e2e test is running after the kubernetes test, I'm +1 to merge this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] rmetzger commented on issue #11619: [FLINK-16921][e2e] Make
Kubernetes e2e test stable
Posted by GitBox <gi...@apache.org>.
rmetzger commented on issue #11619: [FLINK-16921][e2e] Make Kubernetes e2e test stable
URL: https://github.com/apache/flink/pull/11619#issuecomment-608306281
I'm merging the PR now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11619: [FLINK-16921][e2e] Make
Kubernetes e2e test stable
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11619: [FLINK-16921][e2e] Make Kubernetes e2e test stable
URL: https://github.com/apache/flink/pull/11619#issuecomment-607788828
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 68c82eef3469c403b1a0f8a64c13f04d989bf145 (Thu Apr 02 11:29:35 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-16921).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] rmetzger merged pull request #11619: [FLINK-16921][e2e]
Make Kubernetes e2e test stable
Posted by GitBox <gi...@apache.org>.
rmetzger merged pull request #11619: [FLINK-16921][e2e] Make Kubernetes e2e test stable
URL: https://github.com/apache/flink/pull/11619
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11619:
[FLINK-16921][e2e] Make Kubernetes e2e test stable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11619: [FLINK-16921][e2e] Make Kubernetes e2e test stable
URL: https://github.com/apache/flink/pull/11619#issuecomment-607793023
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68c82eef3469c403b1a0f8a64c13f04d989bf145",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/157750104",
"triggerID" : "68c82eef3469c403b1a0f8a64c13f04d989bf145",
"triggerType" : "PUSH"
}, {
"hash" : "68c82eef3469c403b1a0f8a64c13f04d989bf145",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6989",
"triggerID" : "68c82eef3469c403b1a0f8a64c13f04d989bf145",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 68c82eef3469c403b1a0f8a64c13f04d989bf145 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/157750104) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6989)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11619:
[FLINK-16921][e2e] Make Kubernetes e2e test stable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11619: [FLINK-16921][e2e] Make Kubernetes e2e test stable
URL: https://github.com/apache/flink/pull/11619#issuecomment-607793023
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68c82eef3469c403b1a0f8a64c13f04d989bf145",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/157750104",
"triggerID" : "68c82eef3469c403b1a0f8a64c13f04d989bf145",
"triggerType" : "PUSH"
}, {
"hash" : "68c82eef3469c403b1a0f8a64c13f04d989bf145",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6989",
"triggerID" : "68c82eef3469c403b1a0f8a64c13f04d989bf145",
"triggerType" : "PUSH"
}, {
"hash" : "6bd37e40b9333d646bbf1bb1fbe286ad21d1e709",
"status" : "CANCELED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7013",
"triggerID" : "6bd37e40b9333d646bbf1bb1fbe286ad21d1e709",
"triggerType" : "PUSH"
}, {
"hash" : "6bd37e40b9333d646bbf1bb1fbe286ad21d1e709",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158126927",
"triggerID" : "6bd37e40b9333d646bbf1bb1fbe286ad21d1e709",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6bd37e40b9333d646bbf1bb1fbe286ad21d1e709 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/158126927) Azure: [CANCELED](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7013)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on a change in pull request #11619:
[FLINK-16921][e2e] Make Kubernetes e2e test stable
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #11619: [FLINK-16921][e2e] Make Kubernetes e2e test stable
URL: https://github.com/apache/flink/pull/11619#discussion_r402715315
##########
File path: flink-end-to-end-tests/test-scripts/common_kubernetes.sh
##########
@@ -88,22 +86,43 @@ function start_kubernetes_if_not_running {
}
function start_kubernetes {
- [[ "${OS_TYPE}" = "linux" ]] && setup_kubernetes_for_linux
- if ! retry_times ${MINIKUBE_START_RETRIES} ${MINIKUBE_START_BACKOFF} start_kubernetes_if_not_running; then
- echo "Could not start minikube. Aborting..."
- exit 1
+ if [[ "${OS_TYPE}" != "linux" ]]; then
+ if ! check_kubernetes_status; then
+ echo "$NON_LINUX_ENV_NOTE"
+ exit 1
+ fi
+ else
+ setup_kubernetes_for_linux
+ if ! retry_times ${MINIKUBE_START_RETRIES} ${MINIKUBE_START_BACKOFF} start_kubernetes_if_not_running; then
+ echo "Could not start minikube. Aborting..."
+ exit 1
+ fi
fi
eval $(minikube docker-env)
}
function stop_kubernetes {
- echo "Stopping minikube ..."
- stop_command="minikube stop"
- [[ "${OS_TYPE}" = "linux" ]] && stop_command="sudo ${stop_command}"
- if ! retry_times ${MINIKUBE_START_RETRIES} ${MINIKUBE_START_BACKOFF} "${stop_command}"; then
- echo "Could not stop minikube. Aborting..."
- exit 1
+ if [[ "${OS_TYPE}" != "linux" ]]; then
+ echo "$NON_LINUX_ENV_NOTE"
+ else
+ echo "Stopping minikube ..."
+ stop_command="sudo minikube stop"
+ if ! retry_times ${MINIKUBE_START_RETRIES} ${MINIKUBE_START_BACKOFF} "${stop_command}"; then
+ echo "Could not stop minikube. Aborting..."
+ exit 1
+ fi
fi
}
+function debug_copy_and_show_logs {
+ echo "Debugging failed Kubernetes test:"
+ echo "Currently exiting Kubernetes resources"
Review comment:
Nice catch. I will fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11619:
[FLINK-16921][e2e] Make Kubernetes e2e test stable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11619: [FLINK-16921][e2e] Make Kubernetes e2e test stable
URL: https://github.com/apache/flink/pull/11619#issuecomment-607793023
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68c82eef3469c403b1a0f8a64c13f04d989bf145",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/157750104",
"triggerID" : "68c82eef3469c403b1a0f8a64c13f04d989bf145",
"triggerType" : "PUSH"
}, {
"hash" : "68c82eef3469c403b1a0f8a64c13f04d989bf145",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6989",
"triggerID" : "68c82eef3469c403b1a0f8a64c13f04d989bf145",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 68c82eef3469c403b1a0f8a64c13f04d989bf145 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/157750104) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6989)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11619: [FLINK-16921][e2e] Make
Kubernetes e2e test stable
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11619: [FLINK-16921][e2e] Make Kubernetes e2e test stable
URL: https://github.com/apache/flink/pull/11619#issuecomment-607793023
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68c82eef3469c403b1a0f8a64c13f04d989bf145",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "68c82eef3469c403b1a0f8a64c13f04d989bf145",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 68c82eef3469c403b1a0f8a64c13f04d989bf145 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11619:
[FLINK-16921][e2e] Make Kubernetes e2e test stable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11619: [FLINK-16921][e2e] Make Kubernetes e2e test stable
URL: https://github.com/apache/flink/pull/11619#issuecomment-607793023
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68c82eef3469c403b1a0f8a64c13f04d989bf145",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/157750104",
"triggerID" : "68c82eef3469c403b1a0f8a64c13f04d989bf145",
"triggerType" : "PUSH"
}, {
"hash" : "68c82eef3469c403b1a0f8a64c13f04d989bf145",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6989",
"triggerID" : "68c82eef3469c403b1a0f8a64c13f04d989bf145",
"triggerType" : "PUSH"
}, {
"hash" : "6bd37e40b9333d646bbf1bb1fbe286ad21d1e709",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7013",
"triggerID" : "6bd37e40b9333d646bbf1bb1fbe286ad21d1e709",
"triggerType" : "PUSH"
}, {
"hash" : "6bd37e40b9333d646bbf1bb1fbe286ad21d1e709",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158126927",
"triggerID" : "6bd37e40b9333d646bbf1bb1fbe286ad21d1e709",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 68c82eef3469c403b1a0f8a64c13f04d989bf145 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/157750104) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6989)
* 6bd37e40b9333d646bbf1bb1fbe286ad21d1e709 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/158126927) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7013)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11619:
[FLINK-16921][e2e] Make Kubernetes e2e test stable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11619: [FLINK-16921][e2e] Make Kubernetes e2e test stable
URL: https://github.com/apache/flink/pull/11619#issuecomment-607793023
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68c82eef3469c403b1a0f8a64c13f04d989bf145",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/157750104",
"triggerID" : "68c82eef3469c403b1a0f8a64c13f04d989bf145",
"triggerType" : "PUSH"
}, {
"hash" : "68c82eef3469c403b1a0f8a64c13f04d989bf145",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6989",
"triggerID" : "68c82eef3469c403b1a0f8a64c13f04d989bf145",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 68c82eef3469c403b1a0f8a64c13f04d989bf145 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/157750104) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6989)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] rmetzger commented on a change in pull request #11619:
[FLINK-16921][e2e] Make Kubernetes e2e test stable
Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #11619: [FLINK-16921][e2e] Make Kubernetes e2e test stable
URL: https://github.com/apache/flink/pull/11619#discussion_r402261366
##########
File path: flink-end-to-end-tests/test-scripts/common_kubernetes.sh
##########
@@ -88,22 +86,43 @@ function start_kubernetes_if_not_running {
}
function start_kubernetes {
- [[ "${OS_TYPE}" = "linux" ]] && setup_kubernetes_for_linux
- if ! retry_times ${MINIKUBE_START_RETRIES} ${MINIKUBE_START_BACKOFF} start_kubernetes_if_not_running; then
- echo "Could not start minikube. Aborting..."
- exit 1
+ if [[ "${OS_TYPE}" != "linux" ]]; then
+ if ! check_kubernetes_status; then
+ echo "$NON_LINUX_ENV_NOTE"
+ exit 1
+ fi
+ else
+ setup_kubernetes_for_linux
+ if ! retry_times ${MINIKUBE_START_RETRIES} ${MINIKUBE_START_BACKOFF} start_kubernetes_if_not_running; then
+ echo "Could not start minikube. Aborting..."
+ exit 1
+ fi
fi
eval $(minikube docker-env)
}
function stop_kubernetes {
- echo "Stopping minikube ..."
- stop_command="minikube stop"
- [[ "${OS_TYPE}" = "linux" ]] && stop_command="sudo ${stop_command}"
- if ! retry_times ${MINIKUBE_START_RETRIES} ${MINIKUBE_START_BACKOFF} "${stop_command}"; then
- echo "Could not stop minikube. Aborting..."
- exit 1
+ if [[ "${OS_TYPE}" != "linux" ]]; then
+ echo "$NON_LINUX_ENV_NOTE"
+ else
+ echo "Stopping minikube ..."
+ stop_command="sudo minikube stop"
+ if ! retry_times ${MINIKUBE_START_RETRIES} ${MINIKUBE_START_BACKOFF} "${stop_command}"; then
+ echo "Could not stop minikube. Aborting..."
+ exit 1
+ fi
fi
}
+function debug_copy_and_show_logs {
+ echo "Debugging failed Kubernetes test:"
+ echo "Currently exiting Kubernetes resources"
Review comment:
```suggestion
echo "Currently existing Kubernetes resources"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services