[GitHub] [beam] BjornPrime commented on a diff in pull request #24435: slow draining fix

["BjornPrime (via GitHub)" <gi...@apache.org>]

BjornPrime commented on code in PR #24435:
URL: https://github.com/apache/beam/pull/24435#discussion_r1101981792


##########
sdks/python/apache_beam/transforms/core.py:
##########
@@ -2474,9 +2474,13 @@ def typed(transform):
       # Capture in closure (avoiding capturing self).
       args, kwargs = self.args, self.kwargs
 
+      #TODO: We need to add support for multi-window inputs to CombineGlobally()
       def inject_default(_, combined):
         if combined:
-          assert len(combined) == 1
+          if len(combined) > 1:
+            raise ValueError(
+                "Input from multiple simultaneous windows"
+                "isn't currently supported for CombineGlobally()")

Review Comment:
   Do we agree that this PR is at least a step in the right direction for now? I only set it to "address" #24438, so approving this PR won't close that issue.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org