[GitHub] [skywalking] BFergerson commented on a change in pull request #5914: Support collecting logs of log4j, log4j2, and logback in the tracing context

[GitBox <gi...@apache.org>]

BFergerson commented on a change in pull request #5914:
URL: https://github.com/apache/skywalking/pull/5914#discussion_r539445891



##########
File path: docs/en/setup/service-agent/java-agent/agent-optional-plugins/Logger-plugin.md
##########
@@ -0,0 +1,78 @@
+# Overview
+
+`logger-plugin` can store the logs generated by the program during the call, such as the content of the error log, into the span log.  Through the configuration file, you can control the log source (log4j2, logback, log4j), package name, and level. Please pay attention that  the original `log4j.xml`(or other log framework config files) has high priority than the `logconfig.properties`.

Review comment:
       ```suggestion
   `logger-plugin` can store the logs generated by the program during the call, such as the content of the error log, into the span log.  Through the configuration file, you can control the log source (log4j2, logback, log4j), package name, and level. Please note that the original `log4j.xml`(or other log framework config files) has a higher priority than the `logconfig.properties`.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org