You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/10/03 16:31:51 UTC
[GitHub] [shardingsphere] alikaanbaci opened a new pull request #12898: Unit tests added for DataSourceWrapper
alikaanbaci opened a new pull request #12898:
URL: https://github.com/apache/shardingsphere/pull/12898
Fixes #12540.
Changes proposed in this pull request:
- Unit tests implemented for public methods of DataSourceWrapper class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on pull request #12898: Unit tests added for DataSourceWrapper
Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #12898:
URL: https://github.com/apache/shardingsphere/pull/12898#issuecomment-937458900
Hi @alikaanbaci Dose `hacktoberfest` bring you to come here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] alikaanbaci commented on pull request #12898: Unit tests added for DataSourceWrapper
Posted by GitBox <gi...@apache.org>.
alikaanbaci commented on pull request #12898:
URL: https://github.com/apache/shardingsphere/pull/12898#issuecomment-937467530
Hi @tristaZero, Actually no, I was researching for about database sharding technologies, so I saw shardingspehere and liked it. Then wanted to contribute for the project and picked up an issue :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #12898: Unit tests added for DataSourceWrapper
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #12898:
URL: https://github.com/apache/shardingsphere/pull/12898
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on pull request #12898: Unit tests added for DataSourceWrapper
Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #12898:
URL: https://github.com/apache/shardingsphere/pull/12898#issuecomment-937458900
Hi @alikaanbaci Dose `hacktoberfest` bring you to come here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] alikaanbaci commented on pull request #12898: Unit tests added for DataSourceWrapper
Posted by GitBox <gi...@apache.org>.
alikaanbaci commented on pull request #12898:
URL: https://github.com/apache/shardingsphere/pull/12898#issuecomment-937467530
Hi @tristaZero, Actually no, I was researching for about database sharding technologies, so I saw shardingspehere and liked it. Then wanted to contribute for the project and picked up an issue :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on pull request #12898: Unit tests added for DataSourceWrapper
Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #12898:
URL: https://github.com/apache/shardingsphere/pull/12898#issuecomment-935923070
/ci
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero removed a comment on pull request #12898: Unit tests added for DataSourceWrapper
Posted by GitBox <gi...@apache.org>.
tristaZero removed a comment on pull request #12898:
URL: https://github.com/apache/shardingsphere/pull/12898#issuecomment-935923070
/ci
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #12898: Unit tests added for DataSourceWrapper
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #12898:
URL: https://github.com/apache/shardingsphere/pull/12898
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] alikaanbaci commented on pull request #12898: Unit tests added for DataSourceWrapper
Posted by GitBox <gi...@apache.org>.
alikaanbaci commented on pull request #12898:
URL: https://github.com/apache/shardingsphere/pull/12898#issuecomment-935726637
Hi @tristaZero I fixed ci tests fails, can you please take a look again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org