[GitHub] [lucene-solr] moshebla commented on a change in pull request #455: SOLR-12638

[GitBox <gi...@apache.org>]

moshebla commented on a change in pull request #455: SOLR-12638
URL: https://github.com/apache/lucene-solr/pull/455#discussion_r270726667
 
 

 ##########
 File path: solr/core/src/java/org/apache/solr/update/processor/AtomicUpdateDocumentMerger.java
 ##########
 @@ -83,6 +86,17 @@ public static boolean isAtomicUpdate(final AddUpdateCommand cmd) {
     
     return false;
   }
+
+  /**
+   *
+   * @param sdoc doc to be updated
+   * @param rootDoc the root document
+   * @return whether sdoc's id equals to rootDoc's id
+   */
+  public boolean isRootDoc(SolrInputDocument sdoc, SolrInputDocument rootDoc) {
 
 Review comment:
   
   > * Can solrconfig-block-atomic-update.xml be deleted?
   
   Yes :+1: 
   
   >     * I didn't notice where you are using/testing the signatureField; I only noticed your edit to add the schema portion.
   
   I started using solrconfig-tlog.xml, which uses the signature field URP.
   It is now required that the schema have the required signatureFields.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org